smart-scopes-proxy doesn't use cached list of remote scopes if network is not available

Bug #1401560 reported by Paweł Stołowski
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Critical
Unassigned
unity-scopes-api (Ubuntu)
Fix Released
Critical
Paweł Stołowski
unity-scopes-api (Ubuntu RTM)
Fix Released
Critical
Paweł Stołowski

Bug Description

It seems that network failure is not correctly handled where it should be while fetching list of remote scopes, and we attempt to parse empty string -
smart-scopes-proxy.log:

[2014-12-11 14:31:16.212609] INFO: SSRegistry: SmartScopesClient.get_remote_scopes(): Remote scopes:

[2014-12-11 14:31:16.214007] ERROR: SSRegistry: SmartScopesClient.get_remote_scopes() Failed to parse json response from uri: https://dash.ubuntu.com/smartscopes/v2/remote-scopes: unity::ResourceException: Failed to parse json string: * Line 1, Column 1
  Syntax error: value, object or array expected.

[2014-12-11 14:31:16.214467] ERROR: SSRegistry: SSRegistryObject: get_remote_scopes() failed: unity::ResourceException: Failed to parse json string: * Line 1, Column 1
  Syntax error: value, object or array expected.

This causes cached remote-scopes.json to be ignored, and all remote scopes disappear from Manage Dash until network becomes available.

Steps to reproduce:
1) Make sure you see remote scopes in Manage Dash - All.
2) Enable flight mode
3) Reboot the phone
4) Watch /home/phablet/.cache/upstart/smart-scopes-proxy.log
5) Go to Manage Dash - All: NO remote scopes are listed.

Tags: rtm-14.09

Related branches

description: updated
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity-scopes-api (Ubuntu):
status: New → Confirmed
Changed in unity-scopes-api (Ubuntu):
assignee: nobody → Pawel Stolowski (stolowski)
description: updated
Changed in unity-scopes-api (Ubuntu):
status: Confirmed → In Progress
description: updated
summary: - smart-scopes-proxy reports JSON parsing errors if network is not
+ smart-scopes-proxy doesn't use cached remote scopes if network is not
available
description: updated
description: updated
Changed in unity-scopes-api (Ubuntu):
importance: Undecided → Critical
summary: - smart-scopes-proxy doesn't use cached remote scopes if network is not
- available
+ smart-scopes-proxy doesn't use cached list remote scopes if network is
+ not available
summary: - smart-scopes-proxy doesn't use cached list remote scopes if network is
- not available
+ smart-scopes-proxy doesn't use cached list of remote scopes if network
+ is not available
summary: - smart-scopes-proxy doesn't use cached list of remote scopes if network
+ smart-scopes-proxy doesn't use cached list of remote scopes of network
is not available
tags: added: rtm-14.09
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: smart-scopes-proxy doesn't use cached list of remote scopes of network is not available

This bug was fixed in the package unity-scopes-api - 0.6.10+15.04.20141212-0ubuntu1

---------------
unity-scopes-api (0.6.10+15.04.20141212-0ubuntu1) vivid; urgency=low

  [ Pawel Stolowski ]
  * Use get() on future of the http request to get exceptions reported
    when error occur (std::future::wait() doesn't throw). (LP: #1401560)
 -- Ubuntu daily release <email address hidden> Fri, 12 Dec 2014 11:48:25 +0000

Changed in unity-scopes-api (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww51-2014
status: New → Confirmed
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Bumping priority for scope experience

Changed in canonical-devices-system-image:
importance: High → Critical
milestone: ww51-2014 → ww03-2015
summary: - smart-scopes-proxy doesn't use cached list of remote scopes of network
+ smart-scopes-proxy doesn't use cached list of remote scopes if network
is not available
Changed in unity-scopes-api (Ubuntu RTM):
importance: Undecided → Critical
assignee: nobody → Pawel Stolowski (stolowski)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scopes-api - 0.6.9+15.04.20141216.2~rtm-0ubuntu1

---------------
unity-scopes-api (0.6.9+15.04.20141216.2~rtm-0ubuntu1) 14.09; urgency=low

  [ Pawel Stolowski ]
  * Use get() on future of the http request to get exceptions reported
    when error occur (std::future::wait() doesn't throw). Cherry-picked
    trunk rev. 274. (LP: #1401560)
  * Cherry-picked support for passing partner id from /custom/partner-id
    with remote-scopes requests maded by Smart Scopes Proxy. (LP:
    #1389273)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 16 Dec 2014 22:07:29 +0000

Changed in unity-scopes-api (Ubuntu RTM):
status: New → Fix Released
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.