Replace QNetwork with net-cpp
Bug #1326816 reported by
Marcus Tomlinson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api (Ubuntu) |
Fix Released
|
Low
|
Marcus Tomlinson | ||
Bug Description
There really is no need for us to over complicate unity-scopes-api by dragging Qt into the mix, when we have a cleaner pure C++ solution available: net-cpp.
We should replace the use of QNetwork with net-cpp, hence removing our dependency on Qt all together.
Related branches
lp:~marcustomlinson/unity-scopes-api/switch-to-net-cpp
- PS Jenkins bot (community): Approve (continuous-integration)
- Michi Henning: Pending requested
-
Diff: 1370 lines (+357/-698)19 files modifiedCMakeLists.txt (+27/-47)
debian/control (+1/-1)
include/unity/scopes/OnlineAccountClient.h (+1/-1)
include/unity/scopes/internal/smartscopes/HttpClientInterface.h (+1/-1)
include/unity/scopes/internal/smartscopes/HttpClientNetCpp.h (+78/-0)
include/unity/scopes/internal/smartscopes/HttpClientQt.h (+0/-91)
include/unity/scopes/internal/smartscopes/HttpClientQtThread.h (+0/-100)
src/scopes/internal/JsonCppNode.cpp (+4/-4)
src/scopes/internal/RegistryObject.cpp (+1/-1)
src/scopes/internal/smartscopes/CMakeLists.txt (+2/-31)
src/scopes/internal/smartscopes/HttpClientNetCpp.cpp (+189/-0)
src/scopes/internal/smartscopes/HttpClientQt.cpp (+0/-151)
src/scopes/internal/smartscopes/HttpClientQtThread.cpp (+0/-186)
src/scopes/internal/smartscopes/SSRegistryObject.cpp (+2/-2)
src/scopes/internal/smartscopes/SmartScopesClient.cpp (+41/-30)
test/gtest/scopes/internal/smartscopes/HttpClient/HttpClient_test.cpp (+3/-3)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/FakeSss.py (+4/-1)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+3/-2)
valgrind-suppress (+0/-46)
| Changed in unity-scopes-api: | |
| assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
| importance: | Undecided → Low |
| affects: | unity-scopes-api → unity-scopes-api (Ubuntu) |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity-scopes-api (Ubuntu RTM): | |
| status: | New → In Progress |
| assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
| no longer affects: | unity-scopes-api (Ubuntu RTM) |
To post a comment you must log in.
This bug was fixed in the package unity-scopes-api - 0.6.11+
---------------
unity-scopes-api (0.6.11+
[ Ubuntu daily release ]
* debian/
[ thomas-voss ]
* Switch from QNetwork to net-cpp (LP: #1326816, #1409995)
[ Michał Sawicz ]
* Depend on :native version of g++ to allow cross-compiling to work.
Also run `wrap-and-sort -at` (LP: #1353855)
[ Marcus Tomlinson ]
* Switch from QNetwork to net-cpp (LP: #1326816, #1409995)
[ Michi Henning ]
* Added utility subdir to header tests.
* Bunch of miscellaneous fixes:
[ James Henstridge ]
* Expose the deserialize() static method on FilterBase and FilterState
for use by the Go bindings.
-- Ubuntu daily release <email address hidden> Wed, 21 Jan 2015 12:46:41 +0000