Do not use class static translatable messages

Bug #1354501 reported by Albert Astals Cid
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-scope-click (Ubuntu)
Fix Released
High
Alejandro J. Cura

Bug Description

const std::string PreviewStrategy::INFO_LABEL = _("Info");
const std::string PreviewStrategy::UPDATES_LABEL = _("Updates");
const std::string PreviewStrategy::WHATS_NEW_LABEL = _("What's new");

Are wrong because as they are class static they are initialized "at the beginning of the times" and thus the language and translation domain are not set which means you end up with stuff untranslated even if it is correctly translated in the .po file.

Related branches

tags: added: qa-daily-testing rtm14
Changed in unity-scope-click (Ubuntu):
importance: Undecided → High
status: New → Triaged
assignee: nobody → Alejandro J. Cura (alecu)
Leo Arias (elopio)
tags: added: touch
Changed in unity-scope-click (Ubuntu):
status: Triaged → In Progress
Changed in unity-scope-click (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scope-click - 0.1.1+14.10.20140821.1-0ubuntu1

---------------
unity-scope-click (0.1.1+14.10.20140821.1-0ubuntu1) utopic; urgency=medium

  [ Alejandro J. Cura (alecu) ]
  * New upstream release.
    - Display Ubuntu logo in the header of apps scope. (LP: #1350610)
    - Pass the sha512 hash from the details webservice to download manager.
      (LP: #1330770)
    - Sort departments alphabetically. (LP: #1354044)
    - Exclude empty departments from the departments tree in Apps.
      (LP: #1350609)
    - Provide updated departments to match latest server changes. Bumped
      schema to 3.
    - New script to enable purchases in the scope during beta. (LP: #1356419)
    - Add dependency on libglib2.0-bin and upstart-bin for script above.
    - Enable QNetworkDiskCache for http GET requests. (LP: #1351212)
    - Query download manager for in-progress downloads. (LP: #1234965)
    - Only show extended info for apps from the store. (LP: #1350571)
    - Don't expand categories by default in the store. (LP: #1355221)
    - Do not use static const strings for translations. (LP: #1354501)
    - Change "All departments" to just "All". (LP: #1351536)
    - Localize the extra department title in the store. (LP: #1358790)
    - Updated translations.

  [ Martin Pitt ]
  * Mark for using language packs.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Thu, 21 Aug 2014 20:40:59 +0000

Changed in unity-scope-click (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.