Shows available click packages even if no framework is installed
Bug #1320975 reported by
Michael Vogt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scope-click (Ubuntu) |
Fix Released
|
High
|
dobey | ||
Bug Description
When testing with unity8-
We should either depend on a ubuntu-sdk-libs package or send a empty framework to the click search server.
Related branches
lp:~mvo/unity-scope-click/empty-frameworks-query
- dobey (community): Disapprove
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 58 lines (+16/-2)4 files modifiedHACKING (+4/-0)
scope/click/index.cpp (+4/-1)
scope/click/index.h (+0/-1)
scope/tests/test_index.cpp (+8/-0)
lp:~dobey/unity-scope-click/frameworks-dep
- Paweł Stołowski (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 11 lines (+1/-0)1 file modifieddebian/control (+1/-0)
| summary: |
- Shows available click packages even if no framework is instaled + Shows available click packages even if no framework is installed |
| Changed in unity-scope-click (Ubuntu): | |
| importance: | Undecided → Medium |
Revision history for this message
| dobey (dobey) wrote | #1 |
| Changed in unity-scope-click (Ubuntu): | |
| importance: | Medium → High |
| status: | New → Confirmed |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Rodney Dawes (dobey) |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think with current tip of /devel we are actually sending an empty frameworks header in the search request. However, it seems the server is still returning all packages with an empty frameworks header.
I think with your branch, if you tested it against the server, the server might have been interpreting "architecture" as a framework name, and then you were getting no results because it's not a valid framework. I don't think the server should be sending no results for an empty framework in the request.
I think we should fail in some way in the client if we cannot get the list of installed frameworks, and we should have a proper dependency on the ubuntu-sdk-libs package, which provides the frameworks info.