Embedded .desktop files make tests fragile

Bug #1317274 reported by dobey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-scope-click (Ubuntu)
Fix Released
High
dobey

Bug Description

Currently, there are a lot of .desktop files which are simply copied into the tree from a system where the packages that own them were installed at a specific time. In order to test the results of loading these files, we must also have hard-coded vectors in the tests which contain data matching the contents of those files. As we fix bugs or add new features which require the parsing of additional data, or parsing current data in a different way, this can cause some existing tests to break, when they shouldn't be breaking. It's also a bit of a burden to have to maintain an in-memory copy of the contents of the .desktop files.

We should only have a minimal set of .desktop files that are designed to specifically test certain aspects of the code, rather than a bunch of general .desktop files copied in. Ideally, the tests would all be encoded in the test sources directly, and not require any extra files on disk to run the tests.

Related branches

dobey (dobey)
Changed in unity-scope-click (Ubuntu):
status: New → Triaged
importance: Undecided → High
dobey (dobey)
Changed in unity-scope-click (Ubuntu):
assignee: nobody → Rodney Dawes (dobey)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scope-click - 0.1.1+16.10.20160922-0ubuntu1

---------------
unity-scope-click (0.1.1+16.10.20160922-0ubuntu1) yakkety; urgency=medium

  [ Alejandro J. Cura ]
  * Do not show the link to the store scope from the apps scope

  [ Rodney Dawes ]
  * Switch to UAL and libclick for listing installed apps. (LP:
    #1317274)
  * Add the terminal app desktop file to whitelist.
  * Drop the departmentsdb and ubuntu-sdk-libs deps from binary package.

 -- Rodney Dawes <email address hidden> Thu, 22 Sep 2016 15:32:56 +0000

Changed in unity-scope-click (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers