uninstall confirmation and error previews send "close_preview" action, which causes scope to send installed preview
Bug #1289434 reported by
Mike McCracken
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
Pat McGowan | ||
unity-scope-click (Ubuntu) |
Fix Released
|
High
|
Alejandro J. Cura | ||
Vivid |
New
|
Undecided
|
Unassigned | ||
unity-scope-click (Ubuntu RTM) |
Fix Released
|
High
|
Unassigned |
Bug Description
So if the user sees a download error and clicks 'close', they will be shown a screen that looks like the app was installed, when it really wasn't.
The error previews should use an action that lets the scope know which error was displayed, so it can show the correct next preview.
Related branches
lp:~alecu/unity-scope-click/split-close-preview
- PS Jenkins bot: Approve (continuous-integration)
- dobey (community): Approve
-
Diff: 94 lines (+18/-9)4 files modifiedlibclickscope/click/preview.cpp (+6/-4)
libclickscope/click/preview.h (+2/-1)
scope/clickapps/apps-scope.cpp (+5/-2)
scope/clickstore/store-scope.cpp (+5/-2)
lp:~dobey/unity-scope-click/refunds-texts
- Charles Kerr (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 953 lines (+461/-44)17 files modifieddebian/control (+1/-1)
libclickscope/click/CMakeLists.txt (+4/-0)
libclickscope/click/pay.cpp (+33/-3)
libclickscope/click/pay.h (+4/-3)
libclickscope/click/preview.cpp (+138/-9)
libclickscope/click/preview.h (+37/-4)
libclickscope/tests/CMakeLists.txt (+1/-0)
libclickscope/tests/mock_pay.h (+1/-1)
libclickscope/tests/test_preview.cpp (+200/-6)
scope/clickapps/apps-scope.cpp (+11/-2)
scope/clickstore/CMakeLists.txt (+0/-4)
scope/clickstore/store-query.cpp (+13/-4)
scope/clickstore/store-query.h (+2/-2)
scope/clickstore/store-scope.cpp (+14/-2)
scope/clickstore/store-scope.h (+1/-1)
scope/tests/CMakeLists.txt (+0/-1)
scope/tests/test_query.cpp (+1/-1)
Changed in unity-scope-click (Ubuntu): | |
status: | Triaged → In Progress |
assignee: | nobody → Alejandro J. Cura (alecu) |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Pat McGowan (pat-mcgowan) |
importance: | Undecided → Medium |
milestone: | none → ww28-2015 |
status: | New → Fix Released |
To post a comment you must log in.
I'm raising the priority on this, as I hit this a few times yesterday on my Nexus 4, while it was having some sort of network connectivity issue. I got an error preview a couple times, which upon tapping close, gave me a blank preview. This will result in poor user experience for people on slow/patchy network.