client library does not expose getAllDownloadsWithMetadata
Bug #1277814 reported by
Mike McCracken
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-download-manager |
Fix Released
|
Critical
|
Manuel de la Peña | ||
| ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| unity-scope-click (Ubuntu) |
Fix Released
|
High
|
Alejandro J. Cura | ||
Bug Description
The vala click scope uses the DBus method getAllDownloads
There doesn't appear to be a way to search the current downloads in the client library.
While a nice API might give us a way to get Download objects for the matching downloads, for our purposes in the C++ click scope, we just need the object path (the same thing the Download::id() method returns.
Related branches
lp:~mandel/ubuntu-download-manager/all-downloads-client
- dobey (community): Approve
- Alejandro J. Cura (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Mike McCracken: Pending requested
-
Diff: 1359 lines (+708/-161)30 files modifieddebian/control (+3/-3)
debian/libubuntu-download-manager-client-dev.install (+1/-1)
debian/libubuntu-download-manager-common-dev.install (+1/-1)
debian/libubuntu-upload-manager-common-dev.install (+1/-1)
debian/libudm-common-dev.install (+1/-1)
debian/ubuntu-download-manager.install (+1/-1)
debian/ubuntu-upload-manager.install (+1/-1)
src/common/priv/udm-priv-common.pro.THIS (+0/-67)
src/common/public/CMakeLists.txt (+1/-1)
src/downloads/client/CMakeLists.txt (+4/-1)
src/downloads/client/ubuntu/download_manager/download_impl.cpp (+4/-4)
src/downloads/client/ubuntu/download_manager/download_impl.h (+4/-2)
src/downloads/client/ubuntu/download_manager/download_pendingcall_watcher.cpp (+4/-4)
src/downloads/client/ubuntu/download_manager/download_pendingcall_watcher.h (+2/-2)
src/downloads/client/ubuntu/download_manager/downloads_list.h (+50/-0)
src/downloads/client/ubuntu/download_manager/downloads_list_impl.cpp (+64/-0)
src/downloads/client/ubuntu/download_manager/downloads_list_impl.h (+53/-0)
src/downloads/client/ubuntu/download_manager/error.h (+5/-3)
src/downloads/client/ubuntu/download_manager/group_download.h (+1/-1)
src/downloads/client/ubuntu/download_manager/manager.h (+67/-2)
src/downloads/client/ubuntu/download_manager/manager_impl.cpp (+44/-22)
src/downloads/client/ubuntu/download_manager/manager_impl.h (+11/-2)
src/downloads/client/ubuntu/download_manager/manager_pendingcall_watcher.cpp (+111/-20)
src/downloads/client/ubuntu/download_manager/manager_pendingcall_watcher.h (+60/-17)
src/downloads/common/CMakeLists.txt (+1/-1)
src/downloads/daemon/CMakeLists.txt (+1/-1)
src/uploads/common/CMakeLists.txt (+1/-1)
src/uploads/daemon/CMakeLists.txt (+1/-1)
tests/test_client_manager.cpp (+202/-0)
tests/test_client_manager.h (+8/-0)
| Changed in ubuntu-download-manager: | |
| status: | New → In Progress |
| Changed in unity-scope-click (Ubuntu): | |
| assignee: | nobody → Mike McCracken (mikemc) |
| status: | New → Triaged |
| Changed in unity-scope-click (Ubuntu): | |
| assignee: | Mike McCracken (mikemc) → nobody |
| tags: | added: regression-release |
| Changed in unity-scope-click (Ubuntu): | |
| importance: | Undecided → High |
| Changed in ubuntu-download-manager: | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | New → Fix Released |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
