Use the resource_url instead of building it

Bug #1233638 reported by Alejandro J. Cura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-scope-click (Ubuntu)
Won't Fix
Medium
Alejandro J. Cura

Bug Description

The resource url is being built from the package name. The one used should be taken straight from the json.

Changed in unity-scope-click:
importance: Undecided → High
status: New → Triaged
importance: High → Medium
assignee: nobody → Alejandro J. Cura (alecu)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

This is not as easy as it looks in the current scope architecture, because the value being passed around is the package_name, not the resource_url, and that's no longer available when building that url.

dobey (dobey)
affects: unity-scope-click → unity-scope-click (Ubuntu)
Revision history for this message
dobey (dobey) wrote :

Is this an issue with the new c++ scope?

Changed in unity-scope-click (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Alejandro J. Cura (alecu) wrote :

This is still an issue in the new scope:

    QSharedPointer<click::web::Response> response = client->call
        (get_base_url() + click::DETAILS_PATH + package_name);

Changed in unity-scope-click (Ubuntu):
status: Incomplete → Opinion
status: Opinion → Triaged
Revision history for this message
dobey (dobey) wrote :

I'm just gong to close this as Won't Fix, because we need to hit the server to show the preview for installed apps, but there is no reference to a resource URL for the package details in the client side, so we must build the URL.

Changed in unity-scope-click (Ubuntu):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.