"debian/rules clean" does not clean adequately

[Ben Harris]

This is a problem in the unity-lens-applications source package.

According to Ubuntu policy, the "clean" rule in debian/rules "must undo any effects that the build and binary targets may have had, except that it should leave alone any output files created in the parent directory by a run of a binary target." That target in unity-lens-applications does not do this:

root@chickatrice:/tmp# apt-get source unity-lens-applications=7.1.0+13.10.20131011-0ubuntu2 >/dev/null 2>&1
root@chickatrice:/tmp# find unity-lens-applications-7.1.0+13.10.20131011 | wc -l92
root@chickatrice:/tmp# ( cd unity-lens-applications-7.1.0+13.10.20131011 && debian/rules build && debian/rules clean ) >/dev/null 2>&1
root@chickatrice:/tmp# find unity-lens-applications-7.1.0+13.10.20131011 | wc -l103
root@chickatrice:/tmp# rm -r unity*
root@chickatrice:/tmp# apt-get source unity-lens-applications=7.1.0+13.10.20131011-0ubuntu2 >/dev/null 2>&1
root@chickatrice:/tmp# find unity-lens-applications-7.1.0+13.10.20131011 > files.before
root@chickatrice:/tmp# ( cd unity-lens-applications-7.1.0+13.10.20131011 && debian/rules build && debian/rules clean ) >/dev/null 2>&1
root@chickatrice:/tmp# find unity-lens-applications-7.1.0+13.10.20131011 > files.after
root@chickatrice:/tmp# diff files.before files.after | grep '^>'
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/aptd-client.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/software-center-data-cache.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/xapian-utils.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/schemas.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/software-center-utils.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/software-center-app-details.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/utils.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/purchase-info-helper.c
> unity-lens-applications-7.1.0+13.10.20131011/tests/unit/app-watcher.c
> unity-lens-applications-7.1.0+13.10.20131011/data/applications.scope
> unity-lens-applications-7.1.0+13.10.20131011/data/scopes.scope

It looks like some of the files generating while building are not correctly removed while cleaning. This is a problem if (as I do) you want to convert the package to use the "3.0 (quilt)" source format.

The attached patch fixes the problem, but probably more crudely than is acceptable.

[Ben Harris (bjh21)]

I failed to mention: this problem affects Ubuntu 14.04 LTS.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Crude fix for the problem" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]