The transition wallpaper does not have right scale on HiDPI monitor.

Bug #1557893 reported by Kai-Heng Feng
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-greeter (Ubuntu)
Fix Released
High
Unassigned
Trusty
Triaged
High
Unassigned
vala-0.20 (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
New
Undecided
Unassigned

Bug Description

Ubuntu Release: 16.04
Package Version: 16.04.0-0ubuntu1

What you expected to happen:
    The wallpaper scales to whole HiDPI monitor.

 What happened instead:
    The wallpaper only shows on upper left corner.

Related branches

Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Great work Kai, thanks for looking to that bug, the fix seems to work nicely!

@Artur, why did you nominate for trusty? I don't think we have hidpi working in that Ubuntu serie at the moment so the bug shouldn't impact it

Changed in unity-greeter (Ubuntu):
importance: Undecided → High
status: New → In Progress
Revision history for this message
Sebastien Bacher (seb128) wrote :

Ok, after talking to Shih-Yuan there are still plans to backport some of the hidpi work to trusty so it might become relevant for that serie, accepting the nomination

Changed in unity-greeter (Ubuntu Trusty):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

@Sebastien, thanks.

Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

Hi Sebastien,

When we enabled OEM products with HiDPI display, the "let's wait before xsettings settle down" hack was applied [1], so the unity-greeter is actually scaled to the right resolution, hence this issue.

So it would be great if this fix can be put into Trusty.

[1] https://bazaar.launchpad.net/~fourdollars/unity-greeter/add-hidpi-support/revision/1497

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-greeter - 16.04.1-0ubuntu1

---------------
unity-greeter (16.04.1-0ubuntu1) xenial; urgency=medium

  * New upstream release:
    - Fix background after login being scaled incorrectly (LP: #1557893)

 -- Robert Ancell <email address hidden> Fri, 18 Mar 2016 09:46:32 +1300

Changed in unity-greeter (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

In order to make the change build-able on Trusty, we need to add new interface into cairo.vapi:

--- vala-0.22-0.22.1.orig/vapi/cairo.vapi
+++ vala-0.22-0.22.1/vapi/cairo.vapi
@@ -645,6 +645,8 @@ namespace Cairo {
                public void mark_dirty_rectangle (int x, int y, int width, int height);
                public void set_device_offset (double x_offset, double y_offset);
                public void get_device_offset (out double x_offset, out double y_offset);
+ public void set_device_scale (double x_scale, double y_scale);
+ public void get_device_scale (out double x_scale, out double y_scale);
                public void set_fallback_resolution (double x_pixels_per_inch, double y_pixels_per_inch);
                public void show_page ();
                public Status status ();

Those two functions are indeed in Trusty's cairo, so I think it's safe to expose these interface for Vala.

Changed in vala-0.20 (Ubuntu):
status: New → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.