Changing user from no password login to disabled leaves user in no password login group

Bug #1314886 reported by Eric Chaskes on 2014-05-01
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-control-center (Ubuntu)
High
Unassigned
Trusty
Undecided
Unassigned

Bug Description

* Impact
disabling accounts which are set to "log in without password" leads to users still able to log in

* Test case
- use unity-control-center to configure an user password more to "log in without password"
- change the mode to "desactivated"
- try to log in with that user

The user shouldn't be able to log in

* Regression potential
check that the different password modes work as they should

--------

If a user is set to login without a password and subsequently the account is disabled, the user is not removed from the nopassword login group. The result is that the user can still login even though the admin has disabled to account.

This is a security issue and is present in 12.04, 13.10, and 14.04.

This stems from the failure to reset to the password mode away from password_mode_none to password_mode_regular.

I have submitted a merge proposal to fix this at https://code.launchpad.net/~echaskes/unity-control-center/fix-user-password-dialog

Related branches

lp:~echaskes/unity-control-center/fix-user-password-dialog
Merged into lp:unity-control-center/14.04 at revision 12777
Unity Control Center development team: Pending requested 2014-06-04
Merged into lp:unity-control-center at revision 12780
Sebastien Bacher: Approve on 2014-06-04
Changed in unity-control-center (Ubuntu):
importance: Undecided → High
status: New → Triaged
Changed in unity-control-center (Ubuntu):
status: Triaged → Fix Committed
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-control-center - 14.10.0+14.10.20140604-0ubuntu1

---------------
unity-control-center (14.10.0+14.10.20140604-0ubuntu1) utopic; urgency=low

  [ Robert Ancell ]
  * Build depend on libkrb5-dev - fixes FTBFS (LP: #1324538)

  [ Eric Chaskes ]
  * Updated um-password-dialog.c to removed users to change password
    mode to regular when locking the account (LP: #1314886)
 -- Ubuntu daily release <email address hidden> Wed, 04 Jun 2014 14:25:58 +0000

Changed in unity-control-center (Ubuntu):
status: Fix Committed → Fix Released

Hello Eric, or anyone else affected,

Accepted unity-control-center into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity-control-center/14.04.3+14.04.20140604-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity-control-center (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Eric Chaskes (echaskes) wrote :

This change fixed the bug for me. Installed version: unity-control-center 14.04.3+14.04.20140604-0ubuntu1

Test case:

1. Used unity-control-center to configure a user to log in without password.
    User was added to the nopasswdlogin group and was able to log in without password.

2. Used unity-control-center to disabled user account.
    User was removed from the nopasswdlogin group and was *not* able to log in.

Switching the user from various password/login configurations and in various sequences did not show any regression.
Behavior remained as intended in all password modes in all sequences.

tags: added: verification-done
removed: verification-needed

The verification of the Stable Release Update for unity-control-center has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-control-center - 14.04.3+14.04.20140604-0ubuntu1

---------------
unity-control-center (14.04.3+14.04.20140604-0ubuntu1) trusty; urgency=low

  [ Eric Chaskes ]
  * Updated um-password-dialog.c to removed users to change password
    mode to regular when locking the account (LP: #1314886)
 -- Ubuntu daily release <email address hidden> Wed, 04 Jun 2014 19:58:11 +0000

Changed in unity-control-center (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers