Activity log for bug #1788622

Date Who What changed Old value New value Message
2018-08-23 14:12:20 Alexey Dushechkin bug added bug
2018-08-24 05:27:37 Christian Ehrhardt  tags server-next
2018-08-24 05:27:45 Christian Ehrhardt  bug added subscriber Ubuntu Server
2018-08-24 05:27:58 Christian Ehrhardt  unbound (Ubuntu): status New Triaged
2018-08-24 05:28:02 Christian Ehrhardt  bug added subscriber  Christian Ehrhardt 
2018-08-27 11:23:31 Christian Ehrhardt  nominated for series Ubuntu Bionic
2018-08-27 11:23:31 Christian Ehrhardt  bug task added unbound (Ubuntu Bionic)
2018-08-27 11:23:36 Christian Ehrhardt  unbound (Ubuntu): status Triaged Fix Released
2018-08-27 11:23:38 Christian Ehrhardt  unbound (Ubuntu Bionic): status New Triaged
2018-08-27 12:58:48 Christian Ehrhardt  description Unbound 1.6.7-1ubuntu2.1 on 18.04 (bionic): $ sudo systemctl reload unbound Job for unbound.service failed because a timeout was exceeded. See "systemctl status unbound.service" and "journalctl -xe" for details. Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892914 (Debian) and https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4108 (upstream) to me, with patch available. [Impact] * Due to a bug in the upstream code on a reload command all worker processes will exit and the reload will fail. After a while a kill- detection kicks and restarts things, but the reload was intended to not shred the main process after all. * Backport upstream fix to Bionic to unbreak reloading the service [Test Case] * Install unbound $ apt get install unbound * Reload it $ systemctl reload unbound Job for unbound.service failed because a timeout was exceeded. See "systemctl status unbound.service" and "journalctl -xe" for details. * You might also see the timeout detection kick in and restarting the service now. systemd[1]: unbound.service: State 'stop-sigterm' timed out. Killing. systemd[1]: unbound.service: Killing process 13713 (unbound) with signal SIGKILL. systemd[1]: unbound.service: Main process exited, code=killed, status=9/KILL systemd[1]: unbound.service: Failed with result 'timeout'. systemd[1]: Reload failed for Unbound DNS server. * This takes a while and can break the service, to reset for a new test you might need to start the service again. [Regression Potential] * The code changed is rather small, which is good for a review. I'd think if there is a regression it might be around unexpected conditions leading to not all workers shutting down in cases one wants to shut them down. I wasn't able to trigger such in my tests, but that is what would come to my mind. [Other Info] * Test PPA at https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3382 -- Unbound 1.6.7-1ubuntu2.1 on 18.04 (bionic): $ sudo systemctl reload unbound Job for unbound.service failed because a timeout was exceeded. See "systemctl status unbound.service" and "journalctl -xe" for details. Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892914 (Debian) and https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4108 (upstream) to me, with patch available.
2018-08-27 13:26:18 Christian Ehrhardt  description [Impact] * Due to a bug in the upstream code on a reload command all worker processes will exit and the reload will fail. After a while a kill- detection kicks and restarts things, but the reload was intended to not shred the main process after all. * Backport upstream fix to Bionic to unbreak reloading the service [Test Case] * Install unbound $ apt get install unbound * Reload it $ systemctl reload unbound Job for unbound.service failed because a timeout was exceeded. See "systemctl status unbound.service" and "journalctl -xe" for details. * You might also see the timeout detection kick in and restarting the service now. systemd[1]: unbound.service: State 'stop-sigterm' timed out. Killing. systemd[1]: unbound.service: Killing process 13713 (unbound) with signal SIGKILL. systemd[1]: unbound.service: Main process exited, code=killed, status=9/KILL systemd[1]: unbound.service: Failed with result 'timeout'. systemd[1]: Reload failed for Unbound DNS server. * This takes a while and can break the service, to reset for a new test you might need to start the service again. [Regression Potential] * The code changed is rather small, which is good for a review. I'd think if there is a regression it might be around unexpected conditions leading to not all workers shutting down in cases one wants to shut them down. I wasn't able to trigger such in my tests, but that is what would come to my mind. [Other Info] * Test PPA at https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3382 -- Unbound 1.6.7-1ubuntu2.1 on 18.04 (bionic): $ sudo systemctl reload unbound Job for unbound.service failed because a timeout was exceeded. See "systemctl status unbound.service" and "journalctl -xe" for details. Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892914 (Debian) and https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4108 (upstream) to me, with patch available. [Impact]  * Due to a bug in the upstream code on a reload command all worker    processes will exit and the reload will fail. After a while a kill-    detection kicks and restarts things, but the reload was intended to not    shred the main process after all.  * Backport upstream fix to Bionic to unbreak reloading the service [Test Case] Note: can be tested in a LXD container  * Install unbound    $ apt get install unbound  * Reload it    $ systemctl reload unbound      Job for unbound.service failed because a timeout was exceeded.      See "systemctl status unbound.service" and "journalctl -xe" for      details.  * You might also see the timeout detection kick in and restarting the service now.    systemd[1]: unbound.service: State 'stop-sigterm' timed out. Killing.    systemd[1]: unbound.service: Killing process 13713 (unbound) with signal SIGKILL.    systemd[1]: unbound.service: Main process exited, code=killed, status=9/KILL    systemd[1]: unbound.service: Failed with result 'timeout'.    systemd[1]: Reload failed for Unbound DNS server.  * This takes a while and can break the service, to reset for a new test    you might need to start the service again. [Regression Potential]  * The code changed is rather small, which is good for a review. I'd think    if there is a regression it might be around unexpected conditions    leading to not all workers shutting down in cases one wants to shut    them down. I wasn't able to trigger such in my tests, but that is what    would come to my mind. [Other Info]  * Test PPA at https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3382 -- Unbound 1.6.7-1ubuntu2.1 on 18.04 (bionic): $ sudo systemctl reload unbound Job for unbound.service failed because a timeout was exceeded. See "systemctl status unbound.service" and "journalctl -xe" for details. Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892914 (Debian) and https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4108 (upstream) to me, with patch available.
2018-08-27 13:29:41 Christian Ehrhardt  tags server-next bitesize server-next
2018-08-27 13:31:48 Christian Ehrhardt  merge proposal linked https://code.launchpad.net/~paelzer/ubuntu/+source/unbound/+git/unbound/+merge/353786
2018-08-30 13:48:10 Łukasz Zemczak unbound (Ubuntu Bionic): status Triaged Fix Committed
2018-08-30 13:48:12 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2018-08-30 13:48:14 Łukasz Zemczak bug added subscriber SRU Verification
2018-08-30 13:48:19 Łukasz Zemczak tags bitesize server-next bitesize server-next verification-needed verification-needed-bionic
2018-08-31 05:52:13 Christian Ehrhardt  tags bitesize server-next verification-needed verification-needed-bionic bitesize server-next verification-done verification-done-bionic
2018-09-06 08:28:37 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2018-09-06 08:28:36 Launchpad Janitor unbound (Ubuntu Bionic): status Fix Committed Fix Released