RecursionError error in call_adjusted()

Bug #1785093 reported by errors.ubuntu.com bug bridge on 2018-08-02
20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unattended-upgrades (Ubuntu)
Undecided
Unassigned
Xenial
Undecided
Unassigned
Bionic
Undecided
Unassigned

Bug Description

[Impact]

 * Unattended-upgrades may crash and stop installing security updates on users' system due to entering infinite loop.
 * The fix ensures terminating the recursive calls.

[Test Case]

 * TODO / observe the crash not being reported for fixed releases on errors.ubuntu.com.

[Regression Potential]

 * Unattended-upgrades now adjusts package candidates only to lower versions than the one originally offered by apt's resolver. This is a change in behavior which aligns well with the default configuration, i.e. installing packages from -security but not from -updates, since -updates almost always have higher version numbers. This change may cause using different upgrade paths when PPAs are involved and all packages can't be upgraded to the highest versions found in allowed origins, because of Conflicts: for example.
 * Unexpected regressions can cause candidate adjustments not taking place, but please note that autopkgtest now includes applying all outstanding security updates for the release thus the new code is covered, too.

[Original Bug report]

The Ubuntu Error Tracker has been receiving reports about a problem regarding unattended-upgrades. This problem was most recently seen with package version 1.1ubuntu1.18.04.5, the problem page at https://errors.ubuntu.com/problem/fa706afe2f0e04b661fe54da0a59b9fc3da50734 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

Traceback (most recent call last):
  File "/usr/bin/unattended-upgrade", line 1991, in <module>
    sys.exit(main(options))
  File "/usr/bin/unattended-upgrade", line 1647, in main
    cache, options, allowed_origins, blacklisted_pkgs, whitelisted_pkgs)
  File "/usr/bin/unattended-upgrade", line 1349, in calculate_upgradable_pkgs
    whitelisted_pkgs)
  File "/usr/bin/unattended-upgrade", line 1288, in try_to_upgrade
    cache.mark_upgrade_adjusted(pkg, from_user=not pkg.is_auto_installed)
  File "/usr/bin/unattended-upgrade", line 212, in mark_upgrade_adjusted
    self.call_adjusted(apt.package.Package.mark_upgrade, pkg, **kwargs)
  File "/usr/bin/unattended-upgrade", line 206, in call_adjusted
    self.call_adjusted(function, pkg, **kwargs)
  File "/usr/bin/unattended-upgrade", line 206, in call_adjusted

Balint Reczey (rbalint) on 2018-08-03
summary: - /usr/bin/unattended-
- upgrade:RecursionError:__getitem__:__getitem__:_rawpkg_to_pkg:__getitem__:/usr/bin
- /unattended-
- upgrade@1991:main:calculate_upgradable_pkgs:try_to_upgrade:mark_upgrade_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:call_adjusted:__getitem__:_rawpkg_to_pkg:__setitem__:__init__
+ RecursionError error in call_adjusted()
summary: - RecursionError error in call_adjusted()
+ RecursionError error in call_adjusted() when packaga is pinned < 100
summary: - RecursionError error in call_adjusted() when packaga is pinned < 100
+ RecursionError error in call_adjusted() when package is pinned < 100
description: updated

This bug was fixed in the package unattended-upgrades - 1.5ubuntu2

---------------
unattended-upgrades (1.5ubuntu2) cosmic; urgency=medium

  * Reopen Cache after commit() even when frontend locking is supported.
    This fixes build and operation with latest python-apt.

 -- Balint Reczey <email address hidden> Tue, 28 Aug 2018 15:46:25 +0200

Changed in unattended-upgrades (Ubuntu):
status: New → Fix Released
Balint Reczey (rbalint) on 2018-08-30
summary: - RecursionError error in call_adjusted() when package is pinned < 100
+ RecursionError error in call_adjusted()
Balint Reczey (rbalint) on 2018-08-30
description: updated
Brian Murray (brian-murray) wrote :

The bucket_id for this crash is ridiculously long and ends causing the Errors site to throw a 414 error. I was able to manually query the database using the bucket_id and discovered the following.

In [10]: cassandra.get_versions_for_bucket(urllib.unquote(bucket2))
Out[10]: OrderedDict([(('Ubuntu 18.04', '1.1ubuntu1.18.04.5'), 16)])

So with that information we should be able to verify that the SRU'ed version of the package is not affected.

Hello errors.ubuntu.com, or anyone else affected,

Accepted unattended-upgrades into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in unattended-upgrades (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Balint Reczey (rbalint) wrote :

@brian-murray: I'm not observing the crash with 1.1ubuntu1.18.04.6, but if you could check the database manually that would be a better verification, I think.
https://errors.ubuntu.com/?package=unattended-upgrades&period=year&version=1.1ubuntu1.18.04.6

Brian Murray (brian-murray) wrote :

I've gone ahead and ran the same query as before and we only see 1.1.ubuntu1.18.04.5 in the bucket.

In [6]: cassandra.get_versions_for_bucket(urllib.unquote(bucket2))
Out[6]: OrderedDict([(('Ubuntu 18.04', '1.1ubuntu1.18.04.5'), 41)])

Balint Reczey (rbalint) wrote :

Marking as verification done based on the crash not appearing with the fixed release.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic

The verification of the Stable Release Update for unattended-upgrades has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unattended-upgrades - 1.1ubuntu1.18.04.6

---------------
unattended-upgrades (1.1ubuntu1.18.04.6) bionic; urgency=medium

  * Unlock for dpkg operations with apt_pkg.pkgsystem_unlock_inner() when it is
    available. Also stop running when reacquiring the lock fails.
    Thanks to Julian Andres Klode for original partial patch (LP: #1789637)
  * Skip rebuilding python-apt in upgrade autopkgtests.
    Python-apt has a new build dependency making the rebuilding as is failing
    and the reference handling issue is worked around in unattended-upgrades
    already. (LP: #1781586)
  * Stop trying when no adjustment could be made and adjust package candidates
    only to lower versions (LP: #1785093)
  * Skip already adjusted packages from being checked for readjusting.
    This makes it clearer that the recursion ends and can also be a bit quicker.
    (LP: #1785093)

 -- Balint Reczey <email address hidden> Tue, 02 Oct 2018 19:18:02 +0200

Changed in unattended-upgrades (Ubuntu Bionic):
status: Fix Committed → Fix Released

Hello errors.ubuntu.com, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in unattended-upgrades (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
removed: verification-done
Łukasz Zemczak (sil2100) wrote :

Hello errors.ubuntu.com, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers