Replacing configuration file directory with file breaks unattended-upgrades

Bug #1737637 reported by errors.ubuntu.com bug bridge on 2017-12-11
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unattended-upgrades (Ubuntu)
Undecided
Balint Reczey
Xenial
Undecided
Unassigned

Bug Description

[Impact]

 * Unattended-upgrades crashes when a package update changes a config dir to a config file.
 * U-u stops installing security updates when it crashes.

[Test Case] (Xenial)

 * Install an older version of the git package than the one available from xenial-security:
 # apt install git=1:2.7.4-0ubuntu1

 * Change a configuration file to a directory and observe not fixed u-u crashing and fixed u-u installing the update.
# mv /etc/bash_completion.d/git-prompt /etc/bash_completion.d/git-prompt.bak
# mkdir /etc/bash_completion.d/git-prompt
# unattended-upgrade --verbose --dry-run
Initial blacklisted packages:
Initial whitelisted packages:
Starting unattended upgrades script
Allowed origins are: ['o=Ubuntu,a=xenial', 'o=Ubuntu,a=xenial-security', 'o=UbuntuESM,a=xenial']
Traceback (most recent call last):
  File "/usr/bin/unattended-upgrade", line 1485, in <module>
    main(options)
  File "/usr/bin/unattended-upgrade", line 1275, in main
    if conffile_prompt(item.destfile):
  File "/usr/bin/unattended-upgrade", line 671, in conffile_prompt
    with open(prefix + conf_file, 'rb') as fb:
IsADirectoryError: [Errno 21] Is a directory: '/etc/bash_completion.d/git-prompt'

# fixed u-u:
# unattended-upgrade --verbose --dry-run
...
Unpacking git (1:2.17.1-1ubuntu0.4) over (1:2.17.1-1ubuntu0.3) ...
dpkg: warning: git: conffile '/etc/bash_completion.d/git-prompt' is not a plain file or symlink (= '/etc/bash_completion.d/git-prompt')
Setting up git (1:2.17.1-1ubuntu0.4) ...
dpkg: warning: git: conffile '/etc/bash_completion.d/git-prompt' is not a plain file or symlink (= '/etc/bash_completion.d/git-prompt')
...

[Regression Potential]

 * As a known and demonstrated regression configuration files replaced with directories by the local administrator are overwritten and this is dpkg's default behavior. The same thing would happen when applying the security update using apt, and this is still better than skipping the security update.

[Original Bug Text]

The Ubuntu Error Tracker has been receiving reports about a problem regarding unattended-upgrades. This problem was most recently seen with package version 0.98ubuntu1, the problem page at https://errors.ubuntu.com/problem/ed79dbb4e6eba8c7b89fcd7e0cbf60b0db4920ce contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

Traceback (most recent call last):
  File "/usr/bin/unattended-upgrade", line 1556, in <module>
    main(options)
  File "/usr/bin/unattended-upgrade", line 1348, in main
    if conffile_prompt(item.destfile):
  File "/usr/bin/unattended-upgrade", line 725, in conffile_prompt
    with open(prefix + conf_file, 'rb') as fp:
IsADirectoryError: [Errno 21] Is a directory: '/etc/fonts/conf.avail/65-0-fonts-guru-extra.conf'

Balint Reczey (rbalint) on 2017-12-11
summary: - /usr/bin/unattended-upgrade:IsADirectoryError:/usr/bin/unattended-
- upgrade@1556:main:conffile_prompt
+ Replacing configuration file directory with file breaks unattended-
+ upgrades
Balint Reczey (rbalint) on 2017-12-12
description: updated
Changed in unattended-upgrades (Ubuntu):
status: New → In Progress
assignee: nobody → Balint Reczey (rbalint)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unattended-upgrades - 0.99ubuntu2

---------------
unattended-upgrades (0.99ubuntu2) bionic; urgency=medium

  * Run upgrade-between-snapshots only on amd64.
    The test exercises only unattented-upgrade's Python code and uses
    dependencies from the frozen Debian snapshot archive thus running
    it on all architectures would provide little benefit.

 -- Balint Reczey <email address hidden> Tue, 13 Feb 2018 11:41:20 +0700

Changed in unattended-upgrades (Ubuntu):
status: In Progress → Fix Released
Balint Reczey (rbalint) on 2018-11-30
description: updated

Hello errors.ubuntu.com, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in unattended-upgrades (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Łukasz Zemczak (sil2100) wrote :

Hello errors.ubuntu.com, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers