Bug #1680599 “unattended-upgrades crashes without writing to the...” : Bugs : unattended-upgrades package : Ubuntu

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-05-09:

#1

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unattended-upgrades (Ubuntu):
status:	New → Confirmed

Revision history for this message

Patrik Karisch (patkar) wrote on 2017-05-09:

#2

Same error with 0.90ubuntu0.5 on Ubuntu 16.04

# unattended-upgrades --debug --dry-run
Initial blacklisted packages:
Initial whitelisted packages:
Starting unattended upgrades script
Allowed origins are: ['o=Ubuntu,a=xenial-security', 'o=Ubuntu,a=xenial-updates', 'o=Ubuntu,a=xenial', 'o=packagecloud.io/slacktechnologies/slack', 'o=Google, Inc.', 'o=Node Source,n=xenial']
Traceback (most recent call last):
  File "/usr/bin/unattended-upgrades", line 1473, in <module>
    main(options)
  File "/usr/bin/unattended-upgrades", line 1198, in main
    allowed_origins=allowed_origins)
  File "/usr/bin/unattended-upgrades", line 105, in __init__
    self.adjust_candidate_versions()
  File "/usr/bin/unattended-upgrades", line 126, in adjust_candidate_versions
    if is_allowed_origin(pkg.candidate, self.allowed_origins):
  File "/usr/bin/unattended-upgrades", line 512, in is_allowed_origin
    if match_whitelist_string(allowed, origin):
  File "/usr/bin/unattended-upgrades", line 363, in match_whitelist_string
    for s in token.split("=")]
ValueError: not enough values to unpack (expected 2, got 1)

Brian Murray (brian-murray) on 2017-05-09

tags:

added: rls-aa-incoming

Revision history for this message

Patrik Karisch (patkar) wrote on 2017-05-10:

#4

Ok, that's a strange behavior. As long as there are no pending updates, it's fine.

When there is an update available it errors:

Traceback (most recent call last):
  File "/usr/bin/unattended-upgrades", line 1473, in <module>
    main(options)
  File "/usr/bin/unattended-upgrades", line 1198, in main
    allowed_origins=allowed_origins)
  File "/usr/bin/unattended-upgrades", line 105, in __init__
    self.adjust_candidate_versions()
  File "/usr/bin/unattended-upgrades", line 126, in adjust_candidate_versions
    if is_allowed_origin(pkg.candidate, self.allowed_origins):
  File "/usr/bin/unattended-upgrades", line 512, in is_allowed_origin
    if match_whitelist_string(allowed, origin):
  File "/usr/bin/unattended-upgrades", line 363, in match_whitelist_string
    for s in token.split("=")]
ValueError: not enough values to unpack (expected 2, got 1)

Revision history for this message

Aex Rauch (centaurie) wrote on 2017-05-13:

#5

xenial with unattended-upgrades:
Installiert: 0.90ubuntu0.5
Installationskandidat: 0.90ubuntu0.5

unattended-upgrades --debug
Traceback (most recent call last):
  File "/usr/bin/unattended-upgrades", line 1473, in <module>
    main(options)
  File "/usr/bin/unattended-upgrades", line 1139, in main
    allowed_origins = get_allowed_origins()
  File "/usr/bin/unattended-upgrades", line 341, in get_allowed_origins
    allowed_origins = get_allowed_origins_legacy()
  File "/usr/bin/unattended-upgrades", line 326, in get_allowed_origins_legacy
    (distro_id, distro_codename) = s.split()
ValueError: not enough values to unpack (expected 2, got 1)

Revision history for this message

Aex Rauch (centaurie) wrote on 2017-05-14:

#6

I run sudo dpkg-reconfigure -plow unattended-upgrades.

I'm not sure if relevant.

http://www.directupload.net/file/d/4721/m66f7gh6_png.html

Really Debian?

Brian Murray (brian-murray) on 2017-05-17

Changed in unattended-upgrades (Ubuntu):
importance:	Undecided → Low
status:	Confirmed → Triaged
importance:	Low → Medium
assignee:	nobody → Brian Murray (brian-murray)

Revision history for this message

Brian Murray (brian-murray) wrote on 2017-05-17:

#7

I've recreated this and submitted it to the Ubuntu Error Tracker and apparently I'm the only one who has.

https://errors.ubuntu.com/bucket/?id=/usr/bin/unattended-upgrade%3AValueError%3A/usr/bin/unattended-upgrade%401558%3Amain%3Aget_allowed_origins%3Aget_allowed_origins_legacy

Regardless, I'll get it fixed in the development release of Ubuntu.

Brian Murray (brian-murray) on 2017-05-17

Changed in unattended-upgrades (Ubuntu):
status:	Triaged → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-05-18:

#8

This bug was fixed in the package unattended-upgrades - 0.93.1ubuntu6

---------------
unattended-upgrades (0.93.1ubuntu6) artful; urgency=medium

* unattended-upgrades: Do not automatically upgrade the development release
of Ubuntu unless Unattended-Upgrade::DevRelease is true. (LP: #1649709)

-- Brian Murray <email address hidden> Wed, 17 May 2017 16:28:32 -0700

Changed in unattended-upgrades (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2017-05-24:

#9

There is an upstream pull request for this fix here:

https://github.com/mvo5/unattended-upgrades/pull/53

Revision history for this message

Brian Murray (brian-murray) wrote on 2018-12-03: Please test proposed package

#10

Hello Dan, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in unattended-upgrades (Ubuntu Xenial):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-xenial

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2018-12-13:

#11

Hello Dan, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2019-02-28:

#12

Hello Dan, or anyone else affected,

Accepted unattended-upgrades into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unattended-upgrades/1.1ubuntu1.18.04.7~16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message

Balint Reczey (rbalint) wrote on 2019-03-13:

#13

Tested with 1.1ubuntu1.18.04.7~16.04.2 on Xenial:

root@x-uu-lp-1260041:~# unattended-upgrade --dry-run --debug
Unable to parse Unattended-Upgrade::Allowed-Origins.
Traceback (most recent call last):
  File "/usr/bin/unattended-upgrade", line 1998, in <module>
    sys.exit(main(options))
  File "/usr/bin/unattended-upgrade", line 1565, in main
    allowed_origins = get_allowed_origins()
  File "/usr/bin/unattended-upgrade", line 475, in get_allowed_origins
    allowed_origins = get_allowed_origins_legacy()
  File "/usr/bin/unattended-upgrade", line 454, in get_allowed_origins_legacy
    (distro_id, distro_codename) = s.split()
ValueError: not enough values to unpack (expected 2, got 1)
root@x-uu-lp-1260041:~# cat /var/log/unattended-upgrades/unattended-upgrades.log
2019-03-13 17:23:53,035 ERROR Unable to parse Unattended-Upgrade::Allowed-Origins.
root@x-uu-lp-1260041:~# dpkg -l unattended-upgrades | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-===================-==========================-============-===========================================
ii unattended-upgrades 1.1ubuntu1.18.04.7~16.04.2 all automatic installation of security upgrades

tags:

added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial

Revision history for this message

Launchpad Janitor (janitor) wrote on 2019-04-25:

#14

Download full text (33.9 KiB)

This bug was fixed in the package unattended-upgrades - 1.1ubuntu1.18.04.7~16.04.2

---------------
unattended-upgrades (1.1ubuntu1.18.04.7~16.04.2) xenial; urgency=medium

  * Don't check blacklist too early and report updates from not allowed origins
    as kept back. (LP: #1781176)
  * test/test_blacklisted_wrong_origin.py: Fix and enable test
  * Filter out progress indicator from dpkg log (LP: #1599646)
  * Clear cache when autoremoval fails (LP: #1779157)
  * Find autoremovable kernel packages using the patterns in APT's way
    (LP: #1815494)

unattended-upgrades (1.1ubuntu1.18.04.7~16.04.1) xenial; urgency=medium

  * Start service after systemd-logind.service to be able to take inhibition
    lock (LP: #1806487)
  * Handle gracefully when logind is down (LP: #1806487)

unattended-upgrades (1.1ubuntu1.18.04.7~16.04.0) xenial; urgency=medium

  * Backport to Xenial (LP: #1702793)
  * Revert to build-depending on debhelper (>= 9~) and dh-systemd
  * Revert configuration example changes to avoid triggering a debconf question
  * debian/postinst: Update recovery to be triggered on Xenial's package versions

unattended-upgrades (1.1ubuntu1.18.04.7) bionic; urgency=medium

  * Trigger unattended-upgrade-shutdown actions with PrepareForShutdown()
    Performing upgrades in service's ExecStop did not work when the upgrades
    involved restarting services because systemd blocked other stop/start
    actions making maintainer scripts time out and be killed leaving a broken
    system behind.
    Running unattended-upgrades.service before shutdown.target as a oneshot
    service made it run after unmounting filesystems and scheduling services
    properly on shutdown is a complex problem and adding more services to the
    mix make it even more fragile.
    The solution of monitoring PrepareForShutdown() signal from DBus
    allows Unattended Upgrade to run _before_ the jobs related to shutdown are
    queued thus package upgrades can safely restart services without
    risking causing deadlocks or breaking part of the shutdown actions.
    Also ask running unattended-upgrades to stop when shutdown starts even in
    InstallOnShutdown mode and refactor most of unattended-upgrade-shutdown to
    UnattendedUpgradesShutdown class. (LP: #1778219)
  * Increase logind's InhibitDelayMaxSec to 30s. (LP: #1778219)
    This allows more time for unattended-upgrades to shut down gracefully
    or even install a few packages in InstallOnShutdown mode, but is still a
    big step back from the 30 minutes allowed for InstallOnShutdown previously.
    Users enabling InstallOnShutdown node are advised to increase
    InhibitDelayMaxSec even further possibly to 30 minutes.
    - Add NEWS entry about increasing InhibitDelayMaxSec and InstallOnShutdown
      changes
  * Ignore "W503 line break before binary operator"
    because it will become the best practice and breaks the build
  * Stop using ActionGroups, they interfere with apt.Cache.clear()
    causing all autoremovable packages to be handled as newly autoremovable
    ones and be removed by default. Dropping ActionGroup usage does not slow
    down the most frequent case of not having anything to upgrade a...

This bug was fixed in the package unattended-upgrades - 1.1ubuntu1.18.04.7~16.04.2

---------------
unattended-upgrades (1.1ubuntu1.18.04.7~16.04.2) xenial; urgency=medium

* Don't check blacklist too early and report updates from not allowed origins
    as kept back. (LP: #1781176)
  * test/test_blacklisted_wrong_origin.py: Fix and enable test
  * Filter out progress indicator from dpkg log (LP: #1599646)
  * Clear cache when autoremoval fails (LP: #1779157)
  * Find autoremovable kernel packages using the patterns in APT's way
    (LP: #1815494)

unattended-upgrades (1.1ubuntu1.18.04.7~16.04.1) xenial; urgency=medium

* Start service after systemd-logind.service to be able to take inhibition
    lock (LP: #1806487)
  * Handle gracefully when logind is down (LP: #1806487)

unattended-upgrades (1.1ubuntu1.18.04.7~16.04.0) xenial; urgency=medium

* Backport to Xenial (LP: #1702793)
  * Revert to build-depending on debhelper (>= 9~) and dh-systemd
  * Revert configuration example changes to avoid triggering a debconf question
  * debian/postinst: Update recovery to be triggered on Xenial's package versions

unattended-upgrades (1.1ubuntu1.18.04.7) bionic; urgency=medium

* Trigger unattended-upgrade-shutdown actions with PrepareForShutdown()
    Performing upgrades in service's ExecStop did not work when the upgrades
    involved restarting services because systemd blocked other stop/start
    actions making maintainer scripts time out and be killed leaving a broken
    system behind.
    Running unattended-upgrades.service before shutdown.target as a oneshot
    service made it run after unmounting filesystems and scheduling services
    properly on shutdown is a complex problem and adding more services to the
    mix make it even more fragile.
    The solution of monitoring PrepareForShutdown() signal from DBus
    allows Unattended Upgrade to run _before_ the jobs related to shutdown are
    queued thus package upgrades can safely restart services without
    risking causing deadlocks or breaking part of the shutdown actions.
    Also ask running unattended-upgrades to stop when shutdown starts even in
    InstallOnShutdown mode and refactor most of unattended-upgrade-shutdown to
    UnattendedUpgradesShutdown class. (LP: #1778219)
  * Increase logind's InhibitDelayMaxSec to 30s. (LP: #1778219)
    This allows more time for unattended-upgrades to shut down gracefully
    or even install a few packages in InstallOnShutdown mode, but is still a
    big step back from the 30 minutes allowed for InstallOnShutdown previously.
    Users enabling InstallOnShutdown node are advised to increase
    InhibitDelayMaxSec even further possibly to 30 minutes.
    - Add NEWS entry about increasing InhibitDelayMaxSec and InstallOnShutdown
      changes
  * Ignore "W503 line break before binary operator"
    because it will become the best practice and breaks the build
  * Stop using ActionGroups, they interfere with apt.Cache.clear()
    causing all autoremovable packages to be handled as newly autoremovable
    ones and be removed by default. Dropping ActionGroup usage does not slow
    down the most frequent case of not having anything to upgrade and when
    there are packages to upgrade the gain is small compared to the actual
    package installation.
    Also collect autoremovable packages before adjusting candidates because that
    also changed .is_auto_removable attribute of some of them. (LP: #1803749)
    (Closes: #910874)

unattended-upgrades (1.1ubuntu1.18.04.6) bionic; urgency=medium

* Unlock for dpkg operations with apt_pkg.pkgsystem_unlock_inner() when it is
    available. Also stop running when reacquiring the lock fails.
    Thanks to Julian Andres Klode for original partial patch (LP: #1789637)
  * Skip rebuilding python-apt in upgrade autopkgtests.
    Python-apt has a new build dependency making the rebuilding as is failing
    and the reference handling issue is worked around in unattended-upgrades
    already. (LP: #1781586)
  * Stop trying when no adjustment could be made and adjust package candidates
    only to lower versions (LP: #1785093)
  * Skip already adjusted packages from being checked for readjusting.
    This makes it clearer that the recursion ends and can also be a bit quicker.
    (LP: #1785093)

unattended-upgrades (1.1ubuntu1.18.04.5) bionic; urgency=medium

* Stop updating the system when reacquiring the dpkg system lock fails.
    (LP: #1260041)

unattended-upgrades (1.1ubuntu1.18.04.4) bionic; urgency=medium

* Redirect stderr output in upgrade-between-snapshots, too, otherwise it
    breaks the test sometimes (LP: #1781446)

unattended-upgrades (1.1ubuntu1.18.04.3) bionic; urgency=medium

* Redirect stderr output in upgrade-all-security, otherwise it breaks the
    test (LP: #1781446)

unattended-upgrades (1.1ubuntu1.18.04.2) bionic; urgency=medium

[ Balint Reczey ]
  * Clear cache when autoremoval is invalid for a package set marked for
    removal and clear cache after failed commits to return from a possibly
    invalid state (LP: #1779157)
  * Don't start or gracefully stop upgrade on battery (LP: #1773033)
  * Skip updates on metered connections (Closes: #855570) (LP: #1781183)
  * Add debian/tests/upgrade-all-security to install all current security updates.
    On development releases this tests latest stable, on stable releases it tests
    the release itself.
  * Speed up unattended-upgrade (Closes: #892028, #899366) (LP: #1396787)
    - Adjust candidates only for packages to be possibly installed
    - Filter out packages cheaper when they are not from allowed origins
    - Collect autoremovable packages, too, when looking for upgradable ones
    - Measure time of running with --dry-run in autopkgtests
  * Skip starting init.d script in debhelper-generated postinst part
    (LP: #1778800)

[ Ivan Kurnosov ]
  * Fixed is_pkgname_in_blacklist to be side-effect free. (LP: #1781176)
    Otherwise 'is_pkgname_in_blacklist' mutates the 'pkgs_kept_back' and
    'unattended-upgrades' treats the package as a blacklisted candidate

unattended-upgrades (1.1ubuntu1.18.04.1) bionic; urgency=medium

[ Michael Vogt ]
  * unattended-upgrades: fix Unlocked context manager. (LP: #1602536)
    The Unlocked context manager did correctly unlock but did not
    reacquire the lock which means that in minimal-upgrade step
    mode it is possible to run apt code without a lock. If something
    else (like landscape, apt, synaptic, packagekit) locks the cache
    in the meantime this will work and u-u will get dpkg errors
    because dpkg will not be able to perform its operations. It is
    less of an issue in non-minimal mode, but even then the auto-remove
    step may fail in this way.

[ Balint Reczey ]
  * Fix adjusting candidates (LP: #1775292)
  * Relock apt lock before reopening the cache (LP: #1602536)
  * Fix crashing while adjusting candidates and save candidates to adjust only
    in first sweep run, not emptying the set later
    (Closes: #901258) (LP: #1775307)

unattended-upgrades (1.1ubuntu1) bionic; urgency=medium

* Merge from Debian unstable (LP: #1764797)
    - Remaining changes:
      - unattended-upgrades: Do not automatically upgrade the development
        release of Ubuntu unless Unattended-Upgrade::DevRelease is true.
    - Dropped changes, included in Debian:
      - Rename d/NEWS.Debian to d/NEWS to have it shipped
      - Fix typo in NEWS file
      - d/rules: Exclude mypy cache from source package.

unattended-upgrades (1.1) unstable; urgency=medium

[ cgail914 ]
  * Update 50unattended-upgrades.Raspbian
    added a semi-column sign on line 86 to facilitate uncommenting the line
    for users and not end up with an error message when running
    unattended-upgrades. And make the whole file consistent.

[ Tobias Bannert ]
  * completed german translation

[ Simon McVittie ]
  * d/rules: Exclude mypy cache from source package.

[ Julian Andres Klode ]
  * Do not reuse old apt.Version objects after reopening cache (LP: #1737441)

[ Balint Reczey ]
  * Rename d/NEWS.Debian to d/NEWS to have it shipped
  * Fix typo in NEWS file
  * Add missing semicolon to commented-out Remove-Unused-Kernel-Packages option
  * Set UnattendedUpgradesCache.allowed_origins before calling
    apt.Cache.__init__()
  * Find package candidates to adjust sweeping through all packages only once.
    Later reuse the list candidates and filter out packages installed in the
    meantime. Thanks to Julian Andres Klode for the original patch
  * Use updated python-apt in upgrade-between-snapshots test
  * upgrade-between-snapshots: Mount /proc, too, in the chroot.
    Also clean up chroot properly on exit.
  * upgrade-between-snapshots: Use http_proxy environment variable in chroot,
    too
  * upgrade-between-snapshots: Remove packages installed as the side-effect of
    updating apt and python-apt
  * Ignore errors from compiling backported packages
  * Make is_autoremove_valid() nondestructive.
    Also fix autoremoval of packages when one package can't be removed and
    keeps back other package removals due to missing cache.clear()
  * Fix tracking removed packages
  * Suggest default-mta | mail-transport-agent to keep Lintian happy

[ Michael Vogt ]
  * unattanded-upgrades: refactor get_candidates_to_adjust() to
    adjust_candidates()

unattended-upgrades (1.0ubuntu2) bionic; urgency=medium

[ Balint Reczey ]
  * Rename d/NEWS.Debian to d/NEWS to have it shipped
  * Fix typo in NEWS file

[ Simon McVittie ]
  * d/rules: Exclude mypy cache from source package.

unattended-upgrades (1.0ubuntu1) bionic; urgency=medium

* Merge from Debian unstable
    - Remaining changes:
      - unattended-upgrades: Do not automatically upgrade the development
        release of Ubuntu unless Unattended-Upgrade::DevRelease is true.
    - Dropped changes, included in Debian:
      - Run upgrade-between-snapshots only on amd64.
        The test exercises only unattented-upgrade's Python code and uses
        dependencies from the frozen Debian snapshot archive thus running
        it on all architectures would provide little benefit.

unattended-upgrades (1.0) unstable; urgency=medium

[ Simon Arlott ]
  * Revert sending mails on WARNINGS when in MailOnlyOnError mode"
  * Consider conffile prompts to be errors (Closes: #852465)
    Flag packages that have to be upgraded manually because of a conffile
    prompt and consider this to be an error when sending email or exiting.

[ Simon McVittie ]
  * Add python, python3, setuptools, DistutilsExtra to Build-Depends.
    They are needed for `clean`, so Build-Depends-Indep is not enough.
  * Add .gitignore and debian/.gitignore
  * Remove bzr configuration.
    This is unnecessary now that u-u is in git.

[ Michael Vogt ]
  * unattended-upgrades: tweak mail-on-warnings PR
  * unattended-upgrade: extract is_autoremove_valid helper

[ Balint Reczey ]
  * Run upgrade-between-snapshots only on amd64.
    The test exercises only unattented-upgrade's Python code and uses
    dependencies from the frozen Debian snapshot archive thus running
    it on all architectures would provide little benefit.
  * Clean up processes started for getting md5 sums
  * Don't keep /var/lib/dpkg/status open multiple times
  * Adjust candidates in UnattendedUpgradesCache.open()
  * Perform autoremovals in minimal steps, too.
    Also add check to remove only the set of packages selected for autoremoval.
    Without that check unattended-upgrades when (by default) configured to
    remove newly unused packages could also remove auto removable packages
    which were unused before starting starting the upgrade step.
  * Remove unused automatically installed kernel packages
    (LP: #1357093, #1624644, #1675079, #1698159)
  * Stop including Python syntax in the report (Closes: #876796)
  * Do not auto remove packages related to the running kernel (LP: #1615381)
  * Check packages to be autoremoved against blacklists, whitelists.
    Also check if the packages are held.
  * Report package removals in the summary email (Closes: #876797)
  * Run upgrade-between-snapshots test with debugging enabled
  * Don't create new UnattendedUpgradesCache for checking for autoremovals
    .open() refreshes the state in each cache_commit(), this is enough
  * Update .pot and .po files
  * Update .travis.yml to actually build and test u-u from the repo
  * Run only a simple installation test on Travis, the system upgrade
    test was always failing

unattended-upgrades (0.99ubuntu2) bionic; urgency=medium

* Run upgrade-between-snapshots only on amd64.
    The test exercises only unattented-upgrade's Python code and uses
    dependencies from the frozen Debian snapshot archive thus running
    it on all architectures would provide little benefit.

unattended-upgrades (0.99ubuntu1) bionic; urgency=medium

* Merge from Debian unstable (LP: #1722426)
    - Remaining changes:
      - unattended-upgrades: Do not automatically upgrade the development
        release of Ubuntu unless Unattended-Upgrade::DevRelease is true.
    - Dropped changes, included in Debian:
      - Fix version of test package in test_remove_unused_dependencies
      - Do not touch reboot-required on linux-image-extra removal
      - unattended-upgrades: Do not reboot during a dry-run.

unattended-upgrades (0.99) unstable; urgency=medium

[ Peter Nowee ]
  * Fix Raspbian default config codename matching.
    Using `archive=${distro_codename}` does not match, at least not in
    Raspbian Stretch anymore. Changing it to `codename=${distro_codename}`.
    I tested that it now works and did not notice any regressions.
    Same change was made to the Debian-specific configuration 3 years ago,
    see commit 9a2afa5.
  * Enable RPi-specific upgrades on Raspbian.
    In addition to the Raspbian repository, Raspbian images distributed by
    the Raspberry Pi Foundation (RPF) depend on the RPF repository for
    kernel and firmware updates.
    This commit adds a pattern matching line for packages from the RPF
    repository to the Raspbian config file for unattended-upgrades.

[ Alexandre Detiste ]
  * Drop unused dependency on apt-utils (Closes: #876425)

[ Frans Spiesschaert ]
  * Dutch translation update

[ Chris Leick ]
  * German translation update

[ Ben Wong ]
  * Fix configuration file examples (Closes: #877395)

[ Balint Reczey ]
  * Test for running systemd on Debian, too, when applying workaround for it
  * Fix calling dh_installinit during build
  * Tidy up d/control using cme fix
  * Fix log file location in man page.
    Thanks to Jaakov for the bug report (Closes: #817974)
  * Build-depend on debhelper (>= 9.20160709) instead of dh-systemd
  * Link unattended-upgrades.8 to unattended-upgrade.8 man page
  * Add Auto-Submitted header to email report (LP: #1230246)
  * Exit with error when package installation failed or u-u is signalled to
    stop (Closes: #838368)
  * Process packages needing smaller upgrade sets earlier in generating
    minimal upgrade sets.
    Inspired by Michael Vogt's partition pre-calculation code
  * Exit with printing error when apt errors prevent initialization
    (LP: #1737442)
  * Mark invalid UTF-8 characters in dpkg's log, but don't crash
    (LP: #1737635)
  * Try upgrading packages replacing configuration dir with configuration file
    (LP: #1737637)
  * Make unattended-upgrade-shutdown exit with error when apt config is
    invalid (LP: #1737717)
  * Exit when an apt error prevents checking a package for conffile prompt
  * Install upgrades from ${distro_codename}, label=Debian by default.
    This enables updates from stable point releases but also lets testing
    and sid being updated with the package updates.
    Fixes #33. (Closes: #787945, #597061)
  * Fix debian/NEWS.Debian's format
  * Add NEWS item about unattended-uprades installing stable/all updates
  * Stop asking debconf question about Origins-Pattern.
    50unattended-upgrades now contains multiple origins by default and setting
    them from debconf can't be made really easy. Users should change the
    configuration file itself instead. (LP: #1577215)
  * Update PO files about debconf templates
  * Don't log exceptions which did not happen
  * Add autopkgtest for upgrading unstable between two snapshots from
    snapshot.d.o
  * Remove tabs from Debian's configuration file
  * Catch SystemError instead of apt_pkg.Error for backwards compatibility
  * Check in autopkgtest if unattended-upgrades mark additional packages as
    manually installed
  * Test upgrading a full system with desktop packages in autopkgtest.
    Also pick different shapshots with which does not contain
    broken packages.
  * Test sending email after upgrading a full system
  * Show "please don't turn off the computer" while installing updates on
    shutdown.
    This is more informational for users than the original "sleeping for 5s".
    Thanks to Mario Loderer for the suggestion (LP: #1741579)
  * Use eatmydata for system upgrade autopkgtest
  * Run upgrade-between-snapshots autopkgtest even on other distros
  * Apt install built u-u in snapshot upgrade test
  * Update .pot file
  * Fix version of test package in test_remove_unused_dependencies
    (Closes: #886803)
  * Refresh cache after committing changes to avoid reinstalling packages
    (Closes: #875383)
  * Relax calculating truly minimal sets to sets expected to be minimal.
    This speeds up calculation by making it from ~O(n^2) to ~O(n) at the
    expense of creating slightly bigger sets in rare cases.

[ Evilham ]
  * Add Devuan support.

[ Brian Murray ]
  * unattended-upgrades: Do not reboot during a dry-run (LP: #1269177)

[ Michael Vogt ]
  * enable pep484 test
  * mypy fixes
  * add two missing return values
  * tests: cleanup test_mail.py to use proper tmpdirs

[ Julian Andres Klode ]
  * Do not touch reboot-required on linux-image-extra removal (LP: #1458204)

[ Sjoerd Job Postmus ]
  * Adjust candidate version of packages to be newly installed (LP: #1446552)

unattended-upgrades (0.98ubuntu4) bionic; urgency=medium

* Cherry pick from git:
    - Fix version of test package in test_remove_unused_dependencies (Closes: #886803)

unattended-upgrades (0.98ubuntu3) bionic; urgency=medium

*  Do not touch reboot-required on linux-image-extra removal (LP: #1458204)

unattended-upgrades (0.98ubuntu2) bionic; urgency=medium

* unattended-upgrades: Do not reboot during a dry-run. (LP: #1269177)

unattended-upgrades (0.98ubuntu1) artful; urgency=medium

* Merge from Debian unstable (LP: #1722426)
    - Remaining changes:
      - unattended-upgrades: Do not automatically upgrade the development
        release of Ubuntu unless Unattended-Upgrade::DevRelease is true.
    - Dropped changes, included in Debian:
      - Use lsb_release instead of dpkg-vendor in postinst

unattended-upgrades (0.98) unstable; urgency=medium

* Rename test to test_non_minimal_steps_upgrade to reflect content
  * Catch SystemError while keeping apt lock unlocked (LP: #1632361)
  * Add --stop-only option to unattended-upgrade-shutdown and use it on
    hibernation. This prevents starting unattended-upgrades right before
    hibernating when Unattended-Upgrade::InstallOnShutdown is true.
    (Closes: #610333)
  * Stop already running unattended-upgrades before hibernation even with
    systemd (LP: #1455097)
  * Use lsb_release instead of dpkg-vendor in postinst (LP: #1719630)
  * Update README.md with the fact that unattended=upgrades is enabled
    by default (Closes: #865519)

unattended-upgrades (0.97ubuntu2) artful; urgency=medium

* Use lsb_release instead of dpkg-vendor in postinst (LP: #1719630)

unattended-upgrades (0.97ubuntu1) artful; urgency=medium

* Merge from Debian unstable (LP: #1718419)
    - Remaining changes:
      - unattended-upgrades: Do not automatically upgrade the development
        release of Ubuntu unless Unattended-Upgrade::DevRelease is true.
    - Dropped changes, included in Debian:
      - Recover from broken dh_installinit override in versions < 0.93.1ubuntu3

unattended-upgrades (0.97) unstable; urgency=medium

* Handle recovering from broken dh_installinit override on Ubuntu, too
  * Declare needs-reboot for autopkgtests
  * Clean up more test artifacts
  * Run u-u-s only when running on AC power
  * Catch SystemError from fetcher.run(), too
  * Default to MinimalSteps=True in most tests to excercise default setting
  * Check only changed packages in check_changes_for_sanity()
  * Store candidate versions to adjust in UnattendedUpgradesCache()'s constructor

unattended-upgrades (0.96ubuntu1) artful; urgency=low

* Merge from Debian unstable (LP: #1714019)
    - Remaining changes:
      - Recover from broken dh_installinit override in versions < 0.93.1ubuntu3
      - unattended-upgrades: Do not automatically upgrade the development
        release of Ubuntu unless Unattended-Upgrade::DevRelease is true.
    - Dropped changes, included in Debian:
      - Cherry-pick 2e5deed, f26edb4 from upstream to add support for a
        --download-only option, enabling us to download updates at a random
        time of day by default but apply them predictably in the 6am-7am
        window.
      - Fix PEP8 failures (replace except: with except Exception:)
      - unattended-upgrades: Provide some information and create a log entry
        when there is a failure to parse the allowed origins.
      - Add UbuntuESM to the list of sources automatically upgraded from by
        default.
      - Complete the solution for the unattended-upgrades.service unit not
        correctly working
      - d/rules : Remove the override_dh_installinit. The stop option is no
        longer available so the command falls back to default. This is the
        normal behavior so the override is not required
      - d/unattended-upgrades.init : Add Default-Start runlevels, otherwise
        the unattended-upgrades.service unit cannot be enabled on boot
      - d/postinst : Cleanup the stop symlinks created by the wrong
        override_dh_installinit. Without that, the systemd unit cannot be
        enabled correctly.
        Force disable the service before deb-systemd-helper runs so the old
        symlink is not left dangling (workaround for Debian Bug #797108).
        Force enable and start of the systemd unit to work around Debian Bug
        #797108 which fails to enable systemd units correctly when
        WantedBy= statement is changed which is the case here.
      - d/unattended-upgrades.service : Fix the service so it runs correctly on
        shutdown :
        - Remove DefaultDependencies=no : Breaks normal shutdown dependencies
        - Set After= to network.target and local-fs.target. Since our service
          is now ExecStop, it will run before network and local-fs become
          unavailable.
        - Add RequiresMountsFor=/var/log /var/run /var/lib /boot : Necessary if
          /var is a separate file system. Set WantedBy= to multi-user.target
      - Add DEP8 tests to verify the following :
        - Verify that the unattended-upgrades.service unit is enabled and
          started.
        - Verify that InstallOnShutdown works when configured.
      - The systemd unit needs to be an ExecStop since it is is activated on
        shutdown. Otherwise, it will get scheduled after completion of
        the local-fs.target. In the case where /var is a separate
        filesystem, unattended-upgrade-shutdown will hang until timeout
        since /var/run is expected but no longer there
      - When performing a sanity check for packages to install or upgrade
        return false when either there are no packages in the cache or the
        package to upgrade is not in the change set.
      - Do not mark packages for deletion / autoremoval if unattended-upgrades
        is being run in dry-run mode.
      - Store delay command line option as an int not a string since we do
        maths with it.

unattended-upgrades (0.96) unstable; urgency=medium

* Use test/aptroot instead of / as APT root directory in tests
    (Closes: #873079)

unattended-upgrades (0.95) unstable; urgency=medium

[ Michael Vogt ]
  * fix some type hints

[ Balint Reczey ]
  * Increase timeout to 30 minutes for u-u-s to finish before killing it.
    Soft timeout until u-u-s is considered to be finished properly
    is also increased to 25 minutes from 10 minutes.
  * Update the signal used to SIGTERM in the documentation
  * Default to performing upgrades in minimal steps
  * Use same progress logfile when performing upgrades in minimal steps.
    This allows u-u-s to always show the progress.
  * Joining maintaining the package as an uploader
  * Log when not all upgrades could be installed
  * Fix incorrect example for Update-Days.
  * Add Debian backports example to Origins-Pattern.
  * Don't restart unattended-upgrades when the package is upgraded
  * Silence lintinan warning  init.d-script-possible-missing-stop
  * Update .pot and .po file

unattended-upgrades (0.94) unstable; urgency=medium

[ Brian Murray ]
  * Add apt history log to apport reports
  * unattended-upgrades: Provide some information and create a log entry when
    there is a failure to parse the allowed origins. (LP: #1680599)
  * improve the changes sanity check to cache more insane cases
  * Do not mark packages for deletion / autoremoval if unattended-upgrades
    is being run in dry-run mode.

[ Louis Bouchard ]
  * Fix --delay type in unattended-upgrade-shutdown (Closes: #837161)

[ Balint Reczey ]
  * ACK NMU
  * Fix indentation in test-systemd.py
  * Keep apt's partial dir in tests.
    This fixes make -C test in a clean repository
  * Clean up all generated files in override_dh_auto_clean
  * Update debhelper compat level to 9
  * Move acquiring shutdown_lock earlier in u-u to cover dpkg --configure step
  * Start handling SIGUSR1 gracefully earlier in unattended-upgrade
    (LP: #1690980)
  * Handle SIGTERM instead of SIGUSR1 as a graceful shutdown signal
  * Place unattended-upgrade pid file early and remove it on exit.
  * Override maintainer-script-calls-systemctl lintian warnings
  * Don't start package downloads when shutdown has already started
  * Let unattended-upgrade run uninterrupted in shutdown mode until timeout
  * Fix indentation in test-systemd.py

[ Julian Andres Klode ]
  * Add a --download-only option (Closes: #863911) (LP: #1686470)
  * Fix PEP8 failures (replace except: with except Exception:)
    (Closes: #865897)

[ Steve Langasek ]
  * Add UbuntuESM to the list of sources automatically upgraded from by default
    (LP: #1687129)

[ Jonatan Nyberg ]
  * Update Swedish debconf strings (Closes: #855361)

[ Peter Lewis ]
  * Multiple typo fixes

[ Michael Vogt ]
  * add HACKING.md
  * add pep484 type hints
  * add spread test
  * Enable updates on Raspbian

[ John Horne ]
  * Blacklisted packages are now added to the pkgs_kept_back list.
  * Reduced instance of line too long.
  * Some typos corrected in the README file.
  * Fix for pep8 - closing bracket missing visual indentation
  * Added tests that blacklisted packages are mentioned in email messages.
  * Updated argument type comment for is_pkgname_in_blacklist function.

[ nachoparker ]
  * There is noRaspbian-Security label

unattended-upgrades (0.93.1+nmu2) unstable; urgency=medium

* Non-maintainer upload.
  * Fix PEP8 failures (replace except: with except Exception:)
    (Closes: #865897)

unattended-upgrades (0.93.1+nmu1) unstable; urgency=medium

* Non-maintainer upload.

[ Louis Bouchard ]
  * Fix the unattended-upgrades.service unit not correctly working:
    - d/rules : Remove the override_dh_installinit. The stop option is no longer
      available so the command falls back to default. This is the normal
      behavior so the override is not required
    - d/unattended-upgrades.init : Add Default-Start runlevels, otherwise the
      unattended-upgrades.service unit cannot be enabled on boot
    - d/postinst : Cleanup the stop symlinks created by the wrong
      override_dh_installinit. Without that, the systemd unit cannot be
      enabled correctly.
      Force disable the service before deb-systemd-helper runs so the old
      symlink is not left dangling (workaround for Debian Bug #797108).
      Force enable and start of the systemd unit to work around Debian Bug
      #797108 which fails to enable systemd units correctly when WantedBy=
      statement is changed which is the case here.
    - d/unattended-upgrades.service : Fix the service so it runs correctly on
      shutdown :
        Remove DefaultDependencies=no : Breaks normal shutdown dependencies
        Set After= to network.target and local-fs.target. Since our service is
        now ExecStop, it will run before network and local-fs become
        unavailable. Add RequiresMountsFor=/var/log /var/run /var/lib /boot :
        Necessary if /var is a separate file system. Set WantedBy= to
        multi-user.target
    - Add DEP8 tests to verify the following :
      Verify that the unattended-upgrades.service unit is enabled and started.
      Verify that InstallOnShutdown works when configured.
    (Closes: #809669)

unattended-upgrades (0.93.1ubuntu8) artful; urgency=medium

[ Steve Langasek ]
  * Cherry-pick 2e5deed, f26edb4 from upstream to add support for a
    --download-only option, enabling us to download updates at a random time
    of day by default but apply them predictably in the 6am-7am window.
    LP: #1686470.

unattended-upgrades (0.93.1ubuntu7) artful; urgency=medium

* Fix PEP8 failures (replace except: with except Exception:)

unattended-upgrades (0.93.1ubuntu6) artful; urgency=medium

* unattended-upgrades: Do not automatically upgrade the development release
    of Ubuntu unless Unattended-Upgrade::DevRelease is true. (LP: #1649709)

unattended-upgrades (0.93.1ubuntu5) artful; urgency=medium

* unattended-upgrades: Provide some information and create a log entry when
    there is a failure to parse the allowed origins. (LP: #1680599)

unattended-upgrades (0.93.1ubuntu4) artful; urgency=medium

* Add UbuntuESM to the list of sources automatically upgraded from by
    default.  LP: #1687129.

unattended-upgrades (0.93.1ubuntu3) artful; urgency=medium

* Complete the solution for the unattended-upgrades.service unit not
    correctly working (LP: #1654600):
    - d/rules : Remove the override_dh_installinit. The stop option is no longer
      available so the command falls back to default. This is the normal
      behavior so the override is not required
    - d/unattended-upgrades.init : Add Default-Start runlevels, otherwise the
      unattended-upgrades.service unit cannot be enabled on boot
    - d/postinst : Cleanup the stop symlinks created by the wrong
      override_dh_installinit. Without that, the systemd unit cannot be
      enabled correctly.
      Force disable the service before deb-systemd-helper runs so the old
      symlink is not left dangling (workaround for Debian Bug #797108).
      Force enable and start of the systemd unit to work around Debian Bug #797108
      which fails to enable systemd units correctly when WantedBy= statement
      is changed which is the case here.
    - d/unattended-upgrades.service : Fix the service so it runs correctly on
      shutdown :
        Remove DefaultDependencies=no : Breaks normal shutdown dependencies
        Set After= to network.target and local-fs.target. Since our service is
        now ExecStop, it will run before network and local-fs become unavailable.
        Add RequiresMountsFor=/var/log /var/run /var/lib /boot : Necessary if
        /var is a separate file system. Set WantedBy= to multi-user.target
    - Add DEP8 tests to verify the following :
      Verify that the unattended-upgrades.service unit is enabled and started.
      Verify that InstallOnShutdown works when configured.

unattended-upgrades (0.93.1ubuntu2) zesty; urgency=medium

* The systemd unit needs to be an ExecStop since it is is activated on
    shutdown. Otherwise, it will get scheduled after completion of
    the local-fs.target. In the case where /var is a separate
    filesystem, unattended-upgrade-shutdown will hang until timeout
    since /var/run is expected but no longer there (LP: #1654600)

unattended-upgrades (0.93.1ubuntu1) zesty; urgency=medium

[ Brian Murray ]
  * When performing a sanity check for packages to install or upgrade return
    false when either there are no packages in the cache or the package to
    upgrade is not in the change set. (LP: #1654070)
  * Do not mark packages for deletion / autoremoval if unattended-upgrades is
    being run in dry-run mode. (LP: #1544942)

[ Louis Bouchard ]
  * Store delay command line option as an int not a string since we do maths
    with it.

unattended-upgrades (0.93.1) unstable; urgency=medium

[ Brian Murray ]
  * Create logfile_dpkg if it doesn't exist
  * Make sure the statedir exists too
  * ensure network and local-fs are available in shutdown

[ Michael Vogt ]
  * fix incorrect "needrestart" package name, move to sugests
    (Closes: #844051, #846652)

[ Manuel "Venturi" Porras Peralta ]
  * [INTL:es] Spanish po translation (Closes: #817160)

[ Takuma Yamada ]
  * [INTL:ja] Japanese translation of po file update (Closes: #820755)

[ Jonatan Nyberg ]
  * [INTL:sv] Swedish strings for unattended-upgrades debconf (Closes: #822119)

[ Frans Spiesschaert ]
  * [INTL:nl] Dutch po file for the unattended-upgrades package
    (Closes: #823975)

unattended-upgrades (0.93) unstable; urgency=medium

[ Michael Vogt ]
  * Ensure to keep "automatic install" information (Closes: #828215)
  * add recommends to "need-restart" to ensure that all running serivces
    affected by library updates get restarted

[ Brian Murray ]
  * Update 50unattended-upgrades.Ubuntu

[ Germar Reitze ]
  * enable escaped colons in Unattended-Upgrade::Allowed-Origins
  * fix pep8 warning

unattended-upgrades (0.92) unstable; urgency=medium

[ Matt Bearup ]
  * Add support for logging to syslog

[ Raphael Geissert ]
  * Fix bug in minimal upgrade step calculation

unattended-upgrades (0.91) unstable; urgency=medium

* Updated japanese debconf templates.
    Thanks to Takuma Yamada (Closes: 815389)
  * Increase TimeoutStartSec in the shutdown script
  * Document how to set Dpkg::Options.
    Thanks to Matt Bearup
  * add Unattended-Upgrade::Update-Days config
  * [INTL:pt_BR] Brazilian Portuguese.
    Thanks to Adriano Rafael Gomes (Closes: #805460)

-- Balint Reczey <rbalint@ubuntu.com>  Thu, 21 Feb 2019 15:36:42 +0100

Changed in unattended-upgrades (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Ubuntu
unattended-upgrades package

unattended-upgrades crashes without writing to the log on invalid config file entries

Bug Description

Other bug subscribers

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	unattended-upgrades (Ubuntu)	Fix Released	Medium	Brian Murray
	Xenial	Fix Released	Undecided	Unassigned

Ubuntuunattended-upgrades package

unattended-upgrades crashes without writing to the log on invalid config file entries

Bug Description

Other bug subscribers

Remote bug watches

Ubuntu
unattended-upgrades package