unattended-upgrades would benefit from an apport package hook

[Brian Murray]

It'd be useful if there were an apport package hook for unattended-upgrades.

At a minimum it should collect /etc/apt/apt.conf.d/50unattended-upgrades and /etc/apt/apt.conf.d/10periodic.

It'd be nice if it gathered /var/log/unattended-upgrades/unattended-upgrades.log

[Nicolas Valcarcel (nvalcarcel)]

Attaching patch

[Brian Murray (brian-murray)]

Thanks for finding this and working on it. I don't think /var/log/unattended-upgrades/unattended-upgrades would include any sensitive information so it could / should be included all the time. Also /etc/apt/apt.conf.d/50-unattended-upgrades is a conffile so we could use apport's attach_conffiles routine which only adds information about modified or deleted conffiles. Please let me know if you want to make these changes, if not I'll do it when sponsoring the patch.

[Nicolas Valcarcel (nvalcarcel)]

When changing the hook used on the logs i get this:

== .var.log.unattended.upgrades.unattended.upgrades =================================
Error: [Errno 2] No such file or directory: '/var/log/unattended-upgrades/unattended-upgrades'

That's why i used attach_if_exists

Also, using attach_conffiles i'm getting this:
dpkg-query: no packages found matching /etc/apt/apt.conf.d/50unattended-upgrades

[Brian Murray (brian-murray)]

The attach_conffiles error is because it takes a package as an argument.

def attach_conffiles(report, package, conffiles=None, ui=None):
    '''Attach information about any modified or deleted conffiles.

    If conffiles is given, only this subset will be attached. If ui is given,
    ask whether the contents of the file may be added to the report; if this is
    denied, or there is no UI, just mark it as "modified" in the report.
    '''

[Brian Murray (brian-murray)]

I wasn't suggesting to change how (attach_file_if_exists) the unattended-upgrades log file is collected, rather when and that it should be collected all the time as it will not contain sensitive information.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unattended-upgrades - 0.82.7

---------------
unattended-upgrades (0.82.7) unstable; urgency=low

  [ Michael Stapelberg ]
  * Add native systemd service file (closes: #745992)

  [ Brian Murray ]
  * add in an apport package hook (LP: #1078386)

 -- Michael Vogt <email address hidden> Fri, 16 May 2014 08:33:23 +0200