| 2019-01-09 19:01:47 |
Jamie Strandboge |
bug |
|
|
added bug |
| 2019-01-09 19:01:47 |
Jamie Strandboge |
attachment added |
|
code-changes-bionic-to-disco.diff https://bugs.launchpad.net/bugs/1811129/+attachment/5228042/+files/code-changes-bionic-to-disco.diff |
|
| 2019-01-09 19:05:57 |
Jamie Strandboge |
nominated for series |
|
Ubuntu Disco |
|
| 2019-01-09 19:05:57 |
Jamie Strandboge |
bug task added |
|
ufw (Ubuntu Disco) |
|
| 2019-01-09 19:05:57 |
Jamie Strandboge |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-01-09 19:05:57 |
Jamie Strandboge |
bug task added |
|
ufw (Ubuntu Bionic) |
|
| 2019-01-09 19:05:57 |
Jamie Strandboge |
nominated for series |
|
Ubuntu Cosmic |
|
| 2019-01-09 19:05:57 |
Jamie Strandboge |
bug task added |
|
ufw (Ubuntu Cosmic) |
|
| 2019-01-09 19:06:08 |
Jamie Strandboge |
ufw (Ubuntu Disco): status |
New |
Fix Released |
|
| 2019-01-09 23:16:26 |
Jamie Strandboge |
ufw (Ubuntu Bionic): status |
New |
In Progress |
|
| 2019-01-09 23:16:28 |
Jamie Strandboge |
ufw (Ubuntu Cosmic): status |
New |
In Progress |
|
| 2019-01-09 23:17:33 |
Jamie Strandboge |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-03-25 21:12:42 |
Jamie Strandboge |
description |
[Impact]
This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixes in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.
[Test Case]
In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).
[Regression Potential]
In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:
* only comment changes to conf/sysctl.conf
* only comment changes to conf/ufw.defaults
* doc/systemd.example is updated (but unused in our packaging)
* various man page updates
* ufw.pot is refreshed
* various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
* src/applications.py has only whitespace and comment changes
The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.
[Other Info]
Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian last month (and it migrated automatically to disco shortly after) with no new bug reports in either.
The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds. |
[Impact]
This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixes in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.
[Test Case]
In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).
[Regression Potential]
In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:
* only comment changes to conf/sysctl.conf
* only comment changes to conf/ufw.defaults
* doc/systemd.example is updated (but unused in our packaging)
* various man page updates
* ufw.pot is refreshed
* various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
* src/applications.py has only whitespace and comment changes
The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.
In addition to the SRU bugs listed in the changelog, 0.36 also fixes the following upstream bugs not already in 0.35-5:
* bug 1782384 - ufw-framework document error
* bug 1695718 - UFW rule for Transmission only allows 51413/tcp while 51413/udp is used for DHT
* bug 1377600 - ufw errors after ctr+c interupt
* bug 1586258 - Rule insertion fails if ruleset is empty
* bug 1558068 - remove extraneous source quench rule
* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884932 - cannot preseed package configuration in debian-installer
(other bugs in the 0.36-1 changelog are dupes of the above)
[Other Info]
Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian last month (and it migrated automatically to disco shortly after) with no new bug reports in either.
The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds. |
|
| 2019-03-26 14:06:41 |
Jamie Strandboge |
description |
[Impact]
This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixes in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.
[Test Case]
In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).
[Regression Potential]
In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:
* only comment changes to conf/sysctl.conf
* only comment changes to conf/ufw.defaults
* doc/systemd.example is updated (but unused in our packaging)
* various man page updates
* ufw.pot is refreshed
* various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
* src/applications.py has only whitespace and comment changes
The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.
In addition to the SRU bugs listed in the changelog, 0.36 also fixes the following upstream bugs not already in 0.35-5:
* bug 1782384 - ufw-framework document error
* bug 1695718 - UFW rule for Transmission only allows 51413/tcp while 51413/udp is used for DHT
* bug 1377600 - ufw errors after ctr+c interupt
* bug 1586258 - Rule insertion fails if ruleset is empty
* bug 1558068 - remove extraneous source quench rule
* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884932 - cannot preseed package configuration in debian-installer
(other bugs in the 0.36-1 changelog are dupes of the above)
[Other Info]
Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian last month (and it migrated automatically to disco shortly after) with no new bug reports in either.
The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds. |
[Impact]
This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixed in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.
[Test Case]
In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).
[Regression Potential]
In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:
* only comment changes to conf/sysctl.conf
* only comment changes to conf/ufw.defaults
* doc/systemd.example is updated (but unused in our packaging)
* various man page updates
* ufw.pot is refreshed
* various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
* src/applications.py has only whitespace and comment changes
The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.
In addition to the SRU bugs listed in the changelog, 0.36 also fixes the following upstream bugs not already in 0.35-5:
* bug 1782384 - ufw-framework document error
* bug 1695718 - UFW rule for Transmission only allows 51413/tcp while 51413/udp is used for DHT
* bug 1377600 - ufw errors after ctr+c interupt
* bug 1586258 - Rule insertion fails if ruleset is empty
* bug 1558068 - remove extraneous source quench rule
* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884932 - cannot preseed package configuration in debian-installer
(other bugs in the 0.36-1 changelog are dupes of the above)
[Other Info]
Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian last month (and it migrated automatically to disco shortly after) with no new bug reports in either.
The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds. |
|
| 2019-03-26 14:09:16 |
Jamie Strandboge |
description |
[Impact]
This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixed in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.
[Test Case]
In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).
[Regression Potential]
In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:
* only comment changes to conf/sysctl.conf
* only comment changes to conf/ufw.defaults
* doc/systemd.example is updated (but unused in our packaging)
* various man page updates
* ufw.pot is refreshed
* various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
* src/applications.py has only whitespace and comment changes
The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.
In addition to the SRU bugs listed in the changelog, 0.36 also fixes the following upstream bugs not already in 0.35-5:
* bug 1782384 - ufw-framework document error
* bug 1695718 - UFW rule for Transmission only allows 51413/tcp while 51413/udp is used for DHT
* bug 1377600 - ufw errors after ctr+c interupt
* bug 1586258 - Rule insertion fails if ruleset is empty
* bug 1558068 - remove extraneous source quench rule
* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884932 - cannot preseed package configuration in debian-installer
(other bugs in the 0.36-1 changelog are dupes of the above)
[Other Info]
Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian last month (and it migrated automatically to disco shortly after) with no new bug reports in either.
The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds. |
[Impact]
This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixed in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.
[Test Case]
In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).
[Regression Potential]
In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:
* only comment changes to conf/sysctl.conf
* only comment changes to conf/ufw.defaults
* doc/systemd.example is updated (but unused in our packaging)
* various man page updates
* ufw.pot is refreshed
* various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
* src/applications.py has only whitespace and comment changes
The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.
In addition to the SRU bugs listed in the changelog, 0.36 also fixes the following upstream bugs not already in 0.35-5:
* bug 1782384 - ufw-framework document error
* bug 1695718 - UFW rule for Transmission only allows 51413/tcp while 51413/udp is used for DHT
* bug 1377600 - ufw errors after ctr+c interupt
* bug 1586258 - Rule insertion fails if ruleset is empty
* bug 1558068 - remove extraneous source quench rule
* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884932 - cannot preseed package configuration in debian-installer
(other bugs in the 0.36-1 changelog are dupes of the above)
[Other Info]
Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian in December (and it migrated automatically to disco shortly after) with no new ufw bug reports in either. Buster will release with 0.36-1.
The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds. |
|
| 2019-03-26 22:33:32 |
Brian Murray |
ufw (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2019-03-26 22:33:36 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2019-03-26 22:33:40 |
Brian Murray |
tags |
|
verification-needed verification-needed-cosmic |
|
| 2019-03-26 22:38:12 |
Brian Murray |
ufw (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-03-26 22:38:18 |
Brian Murray |
tags |
verification-needed verification-needed-cosmic |
verification-needed verification-needed-bionic verification-needed-cosmic |
|
| 2019-03-28 12:33:44 |
Jamie Strandboge |
tags |
verification-needed verification-needed-bionic verification-needed-cosmic |
verification-done verification-done-bionic verification-done-cosmic |
|
| 2019-04-03 13:46:47 |
Launchpad Janitor |
ufw (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2019-04-03 13:47:08 |
Robie Basak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-04-03 13:47:28 |
Launchpad Janitor |
ufw (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
