udev: add key release quirk for Samsung Q210/P210

Bug #530093 reported by Andy Whitcroft on 2010-03-01
This bug affects 1 person
Affects Status Importance Assigned to Milestone
udev (Ubuntu)
Martin Pitt

Bug Description

Binary package hint: udev

We are dropping the temporary quirk below from the kernel and we need this added to the udev quirks:

commit 2677b2a82e60de22d285c47fa04b22937185a172
Author: Keng-Yu Lin <email address hidden>
Date: Fri Dec 11 11:24:39 2009 +0800

    UBUNTU: SAUCE: input: Add hotkey quirk for Samsung Q210/P210 laptops

    BugLink: http://bugs.launchpad.net/bugs/385683

    Hotkeys do not produce release events. Add the quirk to force a key release.

    In 2.6.32, a /sys interface is provided to handle setting from userspace.
    It is not necessary to apply this patch to newer version than 2.6.31.

    OriginalAuthor: Alexander Huhlaev <email address hidden>
    Signed-off-by: Keng-Yu Lin <email address hidden>
    Acked-by: Tim Gardner <email address hidden>
    Acked-by: Colin King <email address hidden>
    Signed-off-by: Stefan Bader <email address hidden>
    Signed-off-by: Andy Whitcroft <email address hidden>

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 4b22bb7..77a8068 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1676,6 +1676,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
   .driver_data = atkbd_samsung_forced_release_keys,
+ .ident = "Samsung Q210/P210",
+ .matches = {
+ },
+ .callback = atkbd_setup_forced_release,
+ .driver_data = atkbd_samsung_forced_release_keys,
+ },
+ {
   .ident = "Fujitsu Amilo PA 1510",
   .matches = {

Andy Whitcroft (apw) on 2010-03-01
Changed in udev (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
Martin Pitt (pitti) wrote :
Changed in udev (Ubuntu):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package udev - 151-6

udev (151-6) lucid; urgency=low

  * Merge some fixes from GIT HEAD:
    - key release quirk for Fujitsu Amilo 1848+u (LP: #530089)
    - key release quirk for Samsung Q210/P210 (LP: #530093)
    - key maps for Acer TravelMate 6593G and Acer Aspire 1640 (LP: #536914)
    - Decrease buffer size when advancing past NUL byte, to fix a buffer
      overflow the buffer if space is tight.
    - udev-acl: Correctly handle ENV{ACL_MANAGE}==0
    - input_id: Fix linking
    - firmware: fix possible segfault when firmware device goes away while
    - Fix switching Logitech bluetooth adapters into HCI mode. (LP: #444420)
    - cdrom_id: Open non-mounted optical media with O_EXCL. This should
      prevent confusing drives during CD burning sessions.
 -- Martin Pitt <email address hidden> Wed, 24 Mar 2010 18:47:51 +0100

Changed in udev (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers