udev: add key release quirk for Fujitsu Amilo 1848+u

Bug #530089 reported by Andy Whitcroft on 2010-03-01
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
udev (Ubuntu)
Undecided
Martin Pitt

Bug Description

We are dropping the temporary quirk below from the kernel and we need this added to the udev quirks:

commit fa01ca919b30bc635fb058edec0ae551577b6bf0
Author: Pascal Bach <email address hidden>
Date: Thu Oct 22 21:54:44 2009 +0200

    UBUNTU: SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Fujitsu Amilo 1848+u

    Volume keys do not produce release events. Add the quirk to force a key release.

    In 2.6.32, a /sys interface is provided to handle setting from userspace.
    It is not necessary to apply this patch to newer version than 2.6.31.

    BugLink: http://bugs.launchpad.net/bugs/458503

    Signed-off-by: Keng-Yu Lin <email address hidden>
    Acked-by: Tim Gardner <email address hidden>
    Acked-by: Colin King <email address hidden>
    Signed-off-by: Stefan Bader <email address hidden>
    Signed-off-by: Andy Whitcroft <email address hidden>

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 77a8068..bf8dbe9 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -905,6 +905,13 @@ static unsigned int atkbd_amilo_pi3525_forced_release_keys[] = {
 };

 /*
+ * Amilo Si 1848 key release for Fn+Volume keys not working
+ */
+static unsigned int atkbd_amilo_si1848_forced_release_keys[] = {
+ 0xa0, 0xae, 0xb0, -1U
+};
+
+/*
  * Amilo Xi 3650 key release for light touch bar not working
  */
 static unsigned int atkbd_amilo_xi3650_forced_release_keys[] = {
@@ -1694,6 +1701,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
   .driver_data = atkbd_volume_forced_release_keys,
  },
  {
+ .ident = "Fujitsu Amilo Si 1848+u",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Si 1848+u"),
+ },
+ .callback = atkbd_setup_forced_release,
+ .driver_data = atkbd_amilo_si1848_forced_release_keys,
+ },
+ {
   .ident = "Fujitsu Amilo Pi 3525",
   .matches = {
    DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),

Andy Whitcroft (apw) on 2010-03-01
affects: ubuntu → udev (Ubuntu)
Andy Whitcroft (apw) on 2010-03-01
Changed in udev (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
Martin Pitt (pitti) wrote :
Changed in udev (Ubuntu):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package udev - 151-6

---------------
udev (151-6) lucid; urgency=low

  * Merge some fixes from GIT HEAD:
    - key release quirk for Fujitsu Amilo 1848+u (LP: #530089)
    - key release quirk for Samsung Q210/P210 (LP: #530093)
    - key maps for Acer TravelMate 6593G and Acer Aspire 1640 (LP: #536914)
    - Decrease buffer size when advancing past NUL byte, to fix a buffer
      overflow the buffer if space is tight.
    - udev-acl: Correctly handle ENV{ACL_MANAGE}==0
    - input_id: Fix linking
    - firmware: fix possible segfault when firmware device goes away while
      loading
    - Fix switching Logitech bluetooth adapters into HCI mode. (LP: #444420)
    - cdrom_id: Open non-mounted optical media with O_EXCL. This should
      prevent confusing drives during CD burning sessions.
 -- Martin Pitt <email address hidden> Wed, 24 Mar 2010 18:47:51 +0100

Changed in udev (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers