twisted 13.2.0 broke u1trial

Bug #1267982 reported by dobey on 2014-01-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntuone-dev-tools
Undecided
dobey
ubuntuone-dev-tools (Ubuntu)
Undecided
dobey

Bug Description

The new twisted 13.2.0 in trusty changed some argument handling in trial, which breaks the u1trial wrapper around trial. This results in the following error:

./run-tests
Traceback (most recent call last):
  File "bin/u1trial", line 40, in <module>
    main()
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/runners/__init__.py", line 273, in main
    runner, options = _get_runner_options(runner_name)
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/runners/__init__.py", line 255, in _get_runner_options
    options = runner.TestOptions()
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/runners/txrunner.py", line 113, in __init__
    super(TestOptions, self).__init__(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/scripts/trial.py", line 217, in __init__
    usage.Options.__init__(self)
  File "/usr/lib/python2.7/dist-packages/twisted/python/usage.py", line 154, in __init__
    super(Options, self).__init__()
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/runners/__init__.py", line 205, in __init__
    super(BaseTestOptions, self).__init__(*args, **kwargs)
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/utils.py", line 75, in __init__
    (long_opts, short_opts, docs, defaults, syns, dispatch) = _get()
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/utils.py", line 180, in _get_params
    has_default=True)
  File "/tmp/adt-run.0Uomvo/dsc0-build/ubuntuone-dev-tools-13.10/ubuntuone/devtools/utils.py", line 143, in _parse_arguments
    raise ValueError('Failed to parse argument: %s' % _arg)
ValueError: Failed to parse argument: ['order', 'o', None, 'Specify what order to run test cases and methods. See --help-orders for more info.', <function _checkKnownRunOrder at 0x2742f50>]
make[1]: *** [override_dh_auto_test] Error 1

The new twisted has also removed the _parse function from twisted.web.client, which breaks some further tests.

Related branches

dobey (dobey) on 2014-01-10
Changed in ubuntuone-dev-tools (Ubuntu):
status: New → In Progress
assignee: nobody → Rodney Dawes (dobey)
Changed in ubuntuone-dev-tools:
status: New → In Progress
assignee: nobody → Rodney Dawes (dobey)
Changed in ubuntuone-dev-tools:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-dev-tools - 13.10-0ubuntu2

---------------
ubuntuone-dev-tools (13.10-0ubuntu2) trusty; urgency=medium

  * debian/control:
    - Update standards version.
  * debian/patches/00_bzr-twisted-regression.patch:
    - Update code to work with API breaks in twisted 13.2.0. (LP: #1267982)
 -- Rodney Dawes <email address hidden> Fri, 10 Jan 2014 17:26:39 -0500

Changed in ubuntuone-dev-tools (Ubuntu):
status: In Progress → Fix Released
dobey (dobey) on 2016-04-12
Changed in ubuntuone-dev-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers