nothing listens to keyringError signal
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
ubuntuone-credentials (Ubuntu) |
Fix Released
|
Critical
|
dobey | ||
ubuntuone-credentials (Ubuntu RTM) |
Fix Released
|
Critical
|
Unassigned |
Bug Description
several places in keyring.cpp emit keyringError, which is not listened to by ssoservice.
It should be listened to and forwarded as an error to the client of ssoservice.
I noticed this after the following UOA errors:
2014-02-19 21:33:54,704 - DEBUG - after startDownload in run()
2014-02-19 21:33:54,704 - DEBUG - findToken(): Using Ubuntu One account ' 215 '.
2014-02-19 21:33:54,705 - DEBUG - ../../.
2014-02-19 21:33:54,706 - DEBUG - ../../.
2014-02-19 21:33:54,706 - DEBUG - ../../.
2014-02-19 21:33:54,708 - DEBUG - ../../.
2014-02-19 21:33:54,780 - DEBUG - ../../.
2014-02-19 21:33:54,780 - CRITICAL - Error: "userActionFinished error: 10"
Note the final CRITICAL line, that comes from keyring.cpp's keyringError function.
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Alejandro J. Cura (community): Approve
-
Diff: 96 lines (+22/-1)5 files modifieddebian/libubuntuoneauth-2.0-0.symbols (+2/-0)
libubuntuoneauth/keyring.cpp (+7/-1)
libubuntuoneauth/keyring.h (+1/-0)
libubuntuoneauth/ssoservice.cpp (+11/-0)
libubuntuoneauth/ssoservice.h (+1/-0)
- Alejandro J. Cura (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 96 lines (+22/-1)5 files modifieddebian/libubuntuoneauth-2.0-0.symbols (+2/-0)
libubuntuoneauth/keyring.cpp (+7/-1)
libubuntuoneauth/keyring.h (+1/-0)
libubuntuoneauth/ssoservice.cpp (+11/-0)
libubuntuoneauth/ssoservice.h (+1/-0)
Changed in ubuntuone-credentials (Ubuntu): | |
importance: | High → Critical |
status: | New → Triaged |
Changed in ubuntuone-credentials (Ubuntu RTM): | |
status: | New → Triaged |
importance: | Undecided → Critical |
Changed in ubuntuone-credentials (Ubuntu): | |
status: | Triaged → In Progress |
Changed in ubuntuone-credentials (Ubuntu): | |
assignee: | nobody → Rodney Dawes (dobey) |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
milestone: | ww05-2015 → ww07-2015 |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Released |
I have no idea how to reproduce the actual error it got, since I don't know what caused it.
I did get a notification bubble warning me that applications might not be able to access my UOA accounts, but that wasn't very helpful.
Also, it was intermittent - when I restarted the scope and tried again, it worked.
So, I think that just surfacing errors in keyring and making sure you can start over cleanly is the best we can do here.