nothing listens to keyringError signal

[Mike McCracken]

several places in keyring.cpp emit keyringError, which is not listened to by ssoservice.

It should be listened to and forwarded as an error to the client of ssoservice.

I noticed this after the following UOA errors:

2014-02-19 21:33:54,704 - DEBUG - after startDownload in run()
2014-02-19 21:33:54,704 - DEBUG - findToken(): Using Ubuntu One account ' 215 '.
2014-02-19 21:33:54,705 - DEBUG - ../../../../lib/SignOn/identityimpl.cpp 96 updateState Updating state: "PendingRegistration" SignOn::IdentityImpl(0x42e8ab98)
2014-02-19 21:33:54,706 - DEBUG - ../../../../lib/SignOn/authsessionimpl.cpp 94 initInterface
2014-02-19 21:33:54,706 - DEBUG - ../../../../lib/SignOn/authsessionimpl.cpp 94 initInterface
2014-02-19 21:33:54,708 - DEBUG - ../../../../lib/SignOn/identityimpl.cpp 96 updateState Updating state: "Ready" SignOn::IdentityImpl(0x42e8ab98)
2014-02-19 21:33:54,780 - DEBUG - ../../../../lib/SignOn/authsessionimpl.cpp 184 errorSlot QDBusError("com.google.code.AccountsSSO.SingleSignOn.Error.UserInteraction", "userActionFinished error: 10")
2014-02-19 21:33:54,780 - CRITICAL - Error: "userActionFinished error: 10"

Note the final CRITICAL line, that comes from keyring.cpp's keyringError function.

[Mike McCracken (mikemc)]

I have no idea how to reproduce the actual error it got, since I don't know what caused it.

I did get a notification bubble warning me that applications might not be able to access my UOA accounts, but that wasn't very helpful.

Also, it was intermittent - when I restarted the scope and tried again, it worked.

So, I think that just surfacing errors in keyring and making sure you can start over cleanly is the best we can do here.

[Pat McGowan (pat-mcgowan)]

part of fix for bug 1376445

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntuone-credentials - 14.04+15.04.20150120

---------------
ubuntuone-credentials (14.04+15.04.20150120) vivid; urgency=low

  [ Rodney Dawes ]
  * Set the default ACL as ["unconfined"] for the account. (LP:
    #1376445)
  * Handle keyringError from the keyring, by deleting token. (LP:
    #1282392)
 -- Ubuntu daily release <email address hidden> Tue, 20 Jan 2015 18:09:09 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntuone-credentials - 14.04+15.04.20150122~rtm

---------------
ubuntuone-credentials (14.04+15.04.20150122~rtm) 14.09; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Rodney Dawes ]
  * Handle keyringError from the keyring, by deleting token. (LP:
    #1282392)
  * Set the default ACL as ["unconfined"] for the account. (LP:
    #1376445)

ubuntuone-credentials (14.04+14.10.20140910) utopic; urgency=low

  [ CI bot ]
  * Resync trunk

  [ Rodney Dawes ]
  * Add new ctor for Token to accept created/updated date strings. Use
    the new ctor when creating the token from the REST response. Turn
    the date string returned from the server into an ISO string for
    parsing. Add more tests. (LP: #1366998)

  [ Sebastien Bacher ]
  * Set wrapmode to avoid having a label cut (LP: #1366294)
 -- Ubuntu daily release <email address hidden> Thu, 22 Jan 2015 16:16:46 +0000