Network class leaks _request variable

Bug #1270969 reported by Mike McCracken
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntuone-credentials (Ubuntu)
Triaged
High
Unassigned

Bug Description

via valgrind:

==17330== 353 (4 direct, 349 indirect) bytes in 1 blocks are definitely lost in loss record 1,234 of 1,272
==17330== at 0x402A05C: operator new(unsigned int) (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==17330== by 0x45F14D4: UbuntuOne::Network::Network(QObject*) (network.cpp:38)
==17330== by 0x45EF91A: UbuntuOne::IdentityProvider::IdentityProvider(QObject*) (identityprovider.cpp:31)
==17330== by 0x45E329F: UbuntuOne::SSOService::SSOService(QObject*) (ssoservice.cpp:35)
==17330== by 0x4609906: ClickScope::DownloadManager::DownloadManager(QObject*) (download-manager.cpp:44)
==17330== by 0x8051F28: char TestRunner::RegisterTest<TestDownloadManager>(char*) (test_download_manager.h:101)
==17330== by 0x804D1AA: _GLOBAL__sub_I__ZN23TestableDownloadManager25setShouldSignalCredsFoundEb (test_download_manager.h:137)
==17330== by 0x8052E11: __libc_csu_init (in /home/mmccrack/src/unity-scope-click/cxx-dlmgr-tests/build/scope/tests/test-click-scope)
==17330== by 0x4732899: (below main) (libc-start.c:219)

from the code:

    /* either shared pointer or delete this */
    _nam = new QNetworkAccessManager(this);
    _request = new QNetworkRequest();

why not pass this as parent to QNetworkRequest?

dobey (dobey)
affects: ubuntuone-credentials → ubuntuone-credentials (Ubuntu)
dobey (dobey)
Changed in ubuntuone-credentials (Ubuntu):
status: New → Triaged
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.