uneven padding on dashboard left and right side

Bug #738017 reported by Robert Roth on 2011-03-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Control Panel
Medium
Natalia Bidart
ubuntuone-control-panel (Ubuntu)
Medium
Natalia Bidart

Bug Description

Binary package hint: ubuntuone-control-panel

The left padding of the "Edit account details" button and the right padding of the "Buy more storage and new plans" button are two different (16px vs 4px), thus the latter button seems too close to the window's right border. I suggest adding a left padding of 12 to the vbox containing the services info to make it a bit cleaner. Small change, but looks better. Check the attachment to see the dashboard before and after.

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: ubuntuone-control-panel 0.9.1-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-7.35-generic-pae 2.6.38
Uname: Linux 2.6.38-7-generic-pae i686
Architecture: i386
Date: Sat Mar 19 07:59:03 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110202)
ProcEnviron:
 LANGUAGE=en_US:en
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: ubuntuone-control-panel
UpgradeStatus: Upgraded to natty on 2011-03-09 (9 days ago)

Related branches

Robert Roth (evfool) wrote :
Natalia Bidart (nataliabidart) wrote :

Hi Robert,

Thanks a lot for your constant contribution to the project.
I'm assigning this to our designer, but I think this will end up closed as Invalid since the current layout is the default when using frames. So, basically, each group of information is a frame where, each frame content has a right padding of 12px. So, the whole tab has a consistent border of 4px.

If we change this somehow, we should re-organized the information within each frame. We will not add a fixed 12px padding to the rightmost frame (as your branch does).

Cheers, Natalia.

Changed in ubuntuone-control-panel:
status: New → Incomplete
assignee: nobody → Daniel Fore (daniel-p-fore)
Changed in ubuntuone-control-panel (Ubuntu):
status: New → Incomplete
assignee: nobody → Naty Bidart (nataliabidart)
Daniel Fore (danrabbit) wrote :

Hey Naty, I think Robert's fix is a correct solution. And in fact there is something else wrong here since the HIG states that there should be a 12px border around the entirety of the window. As you stated, there is currently only a 4px border.

In all honesty, I'm not sure frames are really meant to be used side-by-side in this manner. So Robert's fix is more likely a work-around for using frames in a way they weren't intended to be used.

Natalia Bidart (nataliabidart) wrote :

Hi Daniel,

IMHO the adding of a fixed amount of padding to the right is a hack. If possible, I would like to avoid adding hacks to the UI code.
If you think you can propose a better organization of that tab, I'm happy to implement. We have a few hours until UI freeze, and if you provide something quick I will be able to implement.

Please let me know!
In the mean time, I have no problem of setting 12px border to the main window, as you requested.

Natalia Bidart (nataliabidart) wrote :

After a live talk with Daniel over IRC, I'm proposing a branch with fixes.

Changed in ubuntuone-control-panel:
assignee: Daniel Fore (daniel-p-fore) → Naty Bidart (nataliabidart)
status: Incomplete → In Progress
Changed in ubuntuone-control-panel (Ubuntu):
status: Incomplete → Triaged
Changed in ubuntuone-control-panel:
importance: Undecided → Medium
Changed in ubuntuone-control-panel (Ubuntu):
importance: Undecided → Medium
Changed in ubuntuone-control-panel:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 0.9.3-0ubuntu1

---------------
ubuntuone-control-panel (0.9.3-0ubuntu1) natty; urgency=low

  * New upstream release:

    [ Natalia B. Bidart <email address hidden> ]
      - Restoring some EventBoxes to play along with the theming (LP: #738017).
      - Added proper domain setting to the GTK UI (LP: #735957).
      - Added border to the overview panel (LP: #739538).
      - Removed the event box behing the banner image to avoid different
        background colors.
      - Name for notebook's tab-buttons have now a more realistic name, and
        also match those from the theme ("ModeLeft" and "ModeRight").
      - After initial computer adding, the user is redirected to the Services
        tab (LP: #739576).
      - Replaced the AspectFrame for a plain Frame to fix the different width
        issue (LP: #729382).
      - Changed the legend for plugin/extension installs (LP: #732820).
    [ <email address hidden> ]
      - Use the new service.in file in setup.py
      - Added service file template (will need a packaging branch to actually
        install it) (LP: #728722).
      - Make bin/ubuntuone-control-panel-gtk not open a new panel if one is
        already open.
    [ Alejandro J. Cura <email address hidden> ]
      - Simplify the PanelTitle; instead of a Label within an EventBox, it will
        just be a Label (LP: #737336).

  * debian/ubuntuone-control-panel-gtk.install:
    - Added dbus gui service file path so ise installed (LP: #739714).
 -- Natalia Bidart (nessita) <email address hidden> Wed, 23 Mar 2011 13:39:40 -0300

Changed in ubuntuone-control-panel (Ubuntu):
status: Triaged → Fix Released
Changed in ubuntuone-control-panel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers