OrientationHelper tests are useless
Bug #1626063 reported by
Tim Peeters
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned | ||
Bug Description
tst_orientation does not test that settings are actually effective, because there is a QSKIP in there that skips the useful tests. It is only tested that there are no warnings when initializing OrientationHelper.
The test that follows the QSKIP is not valid because contentOrientation (enum) is compared with orientationAngle (degrees). So that will fail when QSKIP is removed. We need a proper test for the effectiveness of the OrientationHelper, if we still use the OrientationHelper.
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Confirmed |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.