Scrollbar thumb shows as hovered after touch release
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Canonical System Image |
High
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu) |
High
|
Andrea Bernabei | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
Undecided
|
Unassigned |
Bug Description
ubuntu-ui-toolkit r2079
The fix to bug #1608897 created another issue.
Since MouseArea does not get the exited() signal on touch release (to be investigated if that's intended), dragging the thumb with touchscreen and releasing while the finger is still inside the area of the thumb will cause the thumb to show as hovered even after release.
Related branches
- ubuntu-sdk-build-bot: Needs Fixing (continuous-integration) on 2016-08-29
- Christian Dywan: Approve on 2016-08-29
-
Diff: 662 lines (+290/-154)3 files modifiedsrc/Ubuntu/Components/Themes/Ambiance/1.3/ScrollbarStyle.qml (+49/-28)
tests/unit/visual/ScrollbarTestCase13.qml (+3/-0)
tests/unit/visual/tst_scrollbar.13.qml (+238/-126)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Andrea Bernabei (faenil) |
importance: | Undecided → High |
status: | New → Triaged |
summary: |
- Scrollbar shows as hovered after touch release + Scrollbar thumb shows as hovered after touch release |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Triaged → In Progress |
Andrea Bernabei (faenil) wrote : | #1 |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Łukasz Zemczak (sil2100) wrote : | #2 |
This bug was fixed in the package ubuntu-ui-toolkit 1.3.2104+
---------------
ubuntu-ui-toolkit (1.3.2104+
[ Andrea Bernabei ]
* Scrollbar: more hover related bugfixes and unit tests.
Fixes: LP: #1616868, LP: #1616926
[ Christian Dywan ]
* QuickUtils.
* Correctly test and fix trigger override of ComboButton. Fixes: LP: #1614045
[ Zoltan Balogh ]
Increase the top marging when scrolling upwards. Fixes LP: 1618581
[ Timo Jyrinki ]
* Temporarily skip unit tests on xenial while not all MPs to fix Qt 5.6 issues
have landed yet.
[ Michael Terry ]
* Make ActivityIndicator spinner blue instead of orange. Fixes: LP: #1577828.
[ Loïc Molinari ]
* Changed src/ directory layout. Made the source directory layout consistent
with Qt libs. The C++ libraries have been moved to src/ and the QML modules
to src/imports/. That also makes it easier to differentiate between modules
and libraries since we have a bunch of them now.
* Moved internal tools meant to generate code for the toolkit lib from the QML
module directory to the lib directory where it makes more sense.
* Fixed the build as a Qt submodule.
* Fixed, cleaned up and standardised header inclusions. Apart from the clean
up and the readability improvements, this fixes a bunch of broken private
header inclusions (#include "foo_p.h" in private headers instead of
"private/
be included by the users withour compilation issues. It also removes a bunch
of direct includes from sources and a few INCLUDEPATHs hacks.See the CODING
file for more details.
* Cleaned up ubuntu_
1/ Moved the common config options from the pro files to the prf file to
avoid duplications and simplify the files.
2/ Removed the useless "TEMPLATE=lib" and "load(qt_
the pro files since it's done for us by qt_module.prf.
3/ Use QT= instead of QT*= since it's well defined that by default its
content is "core gui".
4/ Prefixed headers and sources by $$PWD/ and sorted the lines
5/ Merged the SOURCES declarations in UbuntuToolkit.pro.
6/ Removed the useless "DEFINES += QT_USE_
7/ Removed the useless "QMAKE_CXXFLAGS -= -Werror=
and "DEFINES -= QT_DEPRECATED_
since it's already done in ubuntu_
8/ Added a few comments.
* Made use of Qt builtin to check GCC version.
[ Tim Peeters ]
* Improve the initialization of Action when it gets both iconName and
iconSource from an external component when iconSource is undefined. This
fixes the some times missing overflow button in the ActionBar with Qt 5.6.
I also removed action: modelData from the OverflowPanel because this is
a...
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
status: | New → Fix Released |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
milestone: | none → backlog |
Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2104+
---------------
ubuntu-ui-toolkit (1.3.2104+
[ Andrea Bernabei ]
* Scrollbar: more hover related bugfixes and unit tests.
Fixes: LP: #1616868, LP: #1616926
[ Christian Dywan ]
* QuickUtils.
* Correctly test and fix trigger override of ComboButton. Fixes: LP: #1614045
[ Zoltan Balogh ]
Increase the top marging when scrolling upwards. Fixes LP: 1618581
[ Timo Jyrinki ]
* Temporarily skip unit tests on xenial while not all MPs to fix Qt 5.6 issues
have landed yet.
[ Michael Terry ]
* Make ActivityIndicator spinner blue instead of orange. Fixes: LP: #1577828.
[ Loïc Molinari ]
* Changed src/ directory layout. Made the source directory layout consistent
with Qt libs. The C++ libraries have been moved to src/ and the QML modules
to src/imports/. That also makes it easier to differentiate between modules
and libraries since we have a bunch of them now.
* Moved internal tools meant to generate code for the toolkit lib from the QML
module directory to the lib directory where it makes more sense.
* Fixed the build as a Qt submodule.
* Fixed, cleaned up and standardised header inclusions. Apart from the clean
up and the readability improvements, this fixes a bunch of broken private
header inclusions (#include "foo_p.h" in private headers instead of
"private/
be included by the users withour compilation issues. It also removes a bunch
of direct includes from sources and a few INCLUDEPATHs hacks.See the CODING
file for more details.
* Cleaned up ubuntu_
1/ Moved the common config options from the pro files to the prf file to
avoid duplications and simplify the files.
2/ Removed the useless "TEMPLATE=lib" and "load(qt_
the pro files since it's done for us by qt_module.prf.
3/ Use QT= instead of QT*= since it's well defined that by default its
content is "core gui".
4/ Prefixed headers and sources by $$PWD/ and sorted the lines
5/ Merged the SOURCES declarations in UbuntuToolkit.pro.
6/ Removed the useless "DEFINES += QT_USE_
7/ Removed the useless "QMAKE_CXXFLAGS -= -Werror=
and "DEFINES -= QT_DEPRECATED_
since it's already done in ubuntu_
8/ Added a few comments.
* Made use of Qt builtin to check GCC version.
[ Tim Peeters ]
* Improve the initialization of Action when it gets both iconName and
iconSource from an external component when iconSource is undefined. This
fixes the some times missing overflow button in the ActionBar with Qt 5.6.
I also removed action: modelData from the OverflowPanel because this is
already set automatically in ActionSelection
initia...
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Fix Committed → Fix Released |
Implemented solution: since touch does not fire onEntered, when the user is dragging using touch the hover logic is not called. Hence we should not call handleHover in onReleased of the MouseArea because that also fires when touch is released.
We should instead call it in the Mouse.onReleased ignoreSynthesiz edEvents: true" so Mouse.onReleased will not fire on touch release, just mouse release, which is what we want.
The area handling the interaction with the thumb has "Mouse.