Activity log for bug #1566231

Date Who What changed Old value New value Message
2016-04-05 10:13:02 Tim Peeters bug added bug
2016-04-05 10:13:11 Tim Peeters ubuntu-ui-toolkit (Ubuntu): importance Undecided High
2016-04-05 10:13:14 Tim Peeters ubuntu-ui-toolkit (Ubuntu): assignee Tim Peeters (tpeeters)
2016-04-05 10:43:13 Tim Peeters description Currently when Page.header = header1, and then you set Page.header = header2, header1.parent will be reverted to the parent that header1 had before it was assigned to Page.header (and thus re-parented to that page). Currently when Page.header = header1, and then you set Page.header = header2, header1.parent will be reverted to the parent that header1 had before it was assigned to Page.header (and thus re-parented to that page). Motivation: You want only one header at the same time to touch the topMargins of a flickable. We will not set the flickable margins for a header that is not visible or has parent null. So unsetting the parent when the header is no longer active will revert the flickable margins. Here we choose to change header.parent because header.visible may have other bindings that we do not need to break this way.
2016-04-05 10:54:24 Tim Peeters description Currently when Page.header = header1, and then you set Page.header = header2, header1.parent will be reverted to the parent that header1 had before it was assigned to Page.header (and thus re-parented to that page). Motivation: You want only one header at the same time to touch the topMargins of a flickable. We will not set the flickable margins for a header that is not visible or has parent null. So unsetting the parent when the header is no longer active will revert the flickable margins. Here we choose to change header.parent because header.visible may have other bindings that we do not need to break this way. Currently when Page.header = header1, and then you set Page.header = header2, header1.parent will be reverted to the parent that header1 had before it was assigned to Page.header (and thus re-parented to that page). Motivation: You want only one header at the same time to touch the topMargins of a flickable. We will not set the flickable margins for a header that is not visible or has parent null. So unsetting the parent when the header is no longer active will revert the flickable margins. Here we choose to change header.parent because header.visible may have other bindings that we do not need to break this way. Note: There will be no ownership transfer. We are changing the parentItem, not the QObject parent.
2016-04-05 12:00:35 Tim Peeters ubuntu-ui-toolkit (Ubuntu): status New In Progress
2016-04-05 12:26:06 Launchpad Janitor branch linked lp:~tpeeters/ubuntu-ui-toolkit/invisible-header-topmargin
2016-04-12 11:17:52 Timo Jyrinki bug task added ubuntu-ui-toolkit (Ubuntu RTM)
2016-04-12 11:18:05 Timo Jyrinki bug task added canonical-devices-system-image
2016-04-12 11:18:17 Timo Jyrinki canonical-devices-system-image: assignee Zoltan Balogh (bzoltan)
2016-04-12 11:18:19 Timo Jyrinki canonical-devices-system-image: importance Undecided High
2016-04-12 11:18:21 Timo Jyrinki canonical-devices-system-image: milestone 11
2016-04-12 11:52:57 Timo Jyrinki ubuntu-ui-toolkit (Ubuntu RTM): status New Fix Committed
2016-04-12 11:53:00 Timo Jyrinki ubuntu-ui-toolkit (Ubuntu RTM): importance Undecided High
2016-04-12 11:53:01 Timo Jyrinki ubuntu-ui-toolkit (Ubuntu): status In Progress Fix Committed
2016-04-12 11:53:03 Timo Jyrinki canonical-devices-system-image: status New In Progress
2016-04-14 14:34:56 Ɓukasz Zemczak ubuntu-ui-toolkit (Ubuntu RTM): status Fix Committed Fix Released
2016-04-14 16:52:54 Jean-Baptiste Lallement canonical-devices-system-image: status In Progress Fix Committed
2016-04-18 11:09:20 Tim Peeters ubuntu-ui-toolkit (Ubuntu RTM): assignee Tim Peeters (tpeeters)
2016-05-30 15:39:00 Launchpad Janitor ubuntu-ui-toolkit (Ubuntu): status Fix Committed Fix Released
2016-06-02 12:16:03 Pat McGowan canonical-devices-system-image: status Fix Committed Fix Released