ListItemLayout documentation: UbuntuColors.Orange should be UbuntuColors.orange instead

Bug #1561861 reported by XiaoGuo, Liu on 2016-03-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Low
Andrea Bernabei

Bug Description

https://developer.ubuntu.com/api/apps/qml/sdk-15.04.1/Ubuntu.Components.ListItemLayout/

The code:

    ListItemLayout {
        id: layout
        title.text: "Hello..."
        title.color: UbuntuColors.Orange
        subtitle.text: "...world!"
        Rectangle {
            SlotsLayout.position: SlotsLayout.Leading
            color: "pink"
            height: units.gu(6)
            width: height
        }

UbuntuColors.Orange should be Ubuntu.orange

Best regards,
XiaoGuo

Related branches

Christian Dywan (kalikiana) wrote :

I don't understand what the request is here - UbuntuColors.Orange is the correct API.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Incomplete
XiaoGuo, Liu (liu-xiao-guo) wrote :

Hi,

I have a test code at https://github.com/liu-xiao-guo/testubuntucolor. If I run the app, I end up with the error like:

qrc:///Main.qml:32:26: Unable to assign [undefined] to QColor

line 32 is exactly:

            title.color: UbuntuColors.Orange

Have you tried to run the code?

Launchpad Janitor (janitor) wrote :

[Expired for ubuntu-ui-toolkit (Ubuntu) because there has been no activity for 60 days.]

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Incomplete → Expired
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Expired → New
Andrea Bernabei (faenil) wrote :

Hi liu-xiao-guo,
I have just sent an MR that fixes the typo you reported.

Sorry if it took so long, I was not aware of this bug (as I'm not in the SDK team, but I implemented ListItemLayout) and only just found it while I was doing a random text search for launchpad bugs that were affecting components I wrote.

Thanks for reporting the bug, it's important to have a polished and reliable documentation!

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Andrea Bernabei (faenil)
importance: Undecided → Low
status: New → In Progress
Andrea Bernabei (faenil) on 2016-10-07
summary: - UbuntuColors.Orange should be Ubuntu.orange instead
+ UbuntuColors.Orange should be UbuntuColors.orange instead
summary: - UbuntuColors.Orange should be UbuntuColors.orange instead
+ ListItemLayout documentation: UbuntuColors.Orange should be
+ UbuntuColors.orange instead
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Andrea Bernabei (faenil)
no longer affects: ubuntu-ui-toolkit (Ubuntu RTM)
XiaoGuo, Liu (liu-xiao-guo) wrote :

It was great to see that it was fixed :) Thanks for your work.

Andrea Bernabei (faenil) wrote :

Thank you for reporting it! And sorry it took so long! Feel free to directly assign ListItemLayout/SlotsLayout bug to me, to make sure I'm aware of their existance ;)

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2166+17.04.20170130

---------------
ubuntu-ui-toolkit (1.3.2166+17.04.20170130) zesty; urgency=medium

  [ Andrea Bernabei ]
  * ListItemLayout documentation: fix typo in color usage of a code example.
    Fixes LP: #1561861

  [ Zsombor Egri ]
  * Get tst_listitem_focus_13 back alive. Fixes LP: #1624331.

  [ Arthur Mello ]
  * Add support for interacting with Content Hub Clipboard UI via DBus calls.
    Fixes LP: #1563440.

  [ Daniel d'Andrada ]
  * If GRID_UNIT_PX set, always use it. It should override scaling information
    from the QPA.

  [ Adnane Belmadiaf ]
  * Expose append method in TextArea. Fixes LP: #1658121.

  [ Tim Peeters ]
  * Toolbar visual refresh to scroll the icons instead of using an overflow
    panel. Fixes LP: #1558018.
  * Add missing dependency for the UITK gallery. Fixes lLP: #1640135

  [ Sergio Cazzolato ]
  * This change is done to remove the dependencies with upstart in the tests.
    To start apps with env vars is gonna be used the launch_test_application
    method provided by autopilot in its test base class which is a wrapper for
    the ubuntu-app-launch tools (API). This change removes all the dependencies
    with upstart, so all the projects which are using the initctl api and
    fixtures will be impacted. An update in the documentation or in the blog is
    gonna be done also to communicate this change to the developers.

  [ Christian Dywan ]
  * Add visualRoot property to MainWindow. Fixes LP: #1504551, LP: #1656857.
  * Add python3-debian to control.gles and harden package-sorting.sh.
  * Add organizationName property to MainWindow
  * Add MainWindow to Ubuntu.Components.Labs.
    Fixes LP: #1573118, LP: #1587431, LP: #1647415

  [ Albert Astals Cid ]
  * Labs is at 1.0.
  * You can't save the focus after the popup/dialog has been created, at that
    stage the dialog has focus already, you need to do it before creating it.

 -- Zoltán Balogh <email address hidden> Mon, 30 Jan 2017 11:30:03 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers