The reason for using backgroundTertiaryText in SectionsStyle is unclear.

Bug #1561668 reported by Nekhelesh Ramananthan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Triaged
Medium
Jamie Young
ubuntu-ui-toolkit (Ubuntu)
Confirmed
Medium
Unassigned

Bug Description

Looking at SectionStyle.qml [1], it seems the section headers use theme.palette.selected.backgroundTertiaryText to set the color. As I understand backgroundText, backgroundSecondaryText and backgroundTertiaryText are used to denote levels. The page sections have only 1 label and thereby should use theme.palette.selected.backgroundText instead.

On talking to timp, he did make me understand that the main page header uses backgroundText while the section headers uses tertiaryText which does make sense. But that is something other app devs won't think of. May be the solution is to show a visual illustration where each SDK component shows what palette color it is using.

Do note that this is not about which set (normal, disabled, selected, highlighted) to use, but rather the actual palette value.

[1] http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/staging/view/head:/src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml

Revision history for this message
Tim Peeters (tpeeters) wrote :

The palette is global, per-app, so not per component. That means if text in two different components need to have a different color, we need two separate entries in the palette.

Having a visual mock-up of an app showing all the components in all the states, with the colors listed would help.

Changed in ubuntu-ux:
assignee: nobody → Jamie Young (jamiedawsonyoung)
Tim Peeters (tpeeters)
summary: - SectionStyle shouldn't use backgroundTertiaryText to set the color of
- selected section
+ The reason for using backgroundTertiaryText in SectionsStyle is unclear.
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Tim Peeters (tpeeters)
Tim Peeters (tpeeters)
Changed in ubuntu-ux:
status: New → Confirmed
Revision history for this message
Tim Peeters (tpeeters) wrote :

The solution that we discussed for this bug was for Jamie to publish an overview graphic (or multiple) that shows all the components and their color (in different themes). That way it is easy to look up what the colors are used for.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Invalid
importance: Undecided → Medium
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Invalid → Confirmed
Revision history for this message
Jamie Young (jamiedawsonyoung) wrote :

Assigning this to Rae. We've discussed a short-term solution and Pierre is building something for a more longer term one too.

Changed in ubuntu-ux:
assignee: Jamie Young (jamiedawsonyoung) → Rae Shambrook (raecontreras)
Changed in ubuntu-ux:
assignee: Rae Shambrook (raecontreras) → Jamie Young (jamiedawsonyoung)
importance: Undecided → Medium
Revision history for this message
Jamie Young (jamiedawsonyoung) wrote :

The most sensible place for these reference graphics to live is the tutorial: https://developer.ubuntu.com/en/phone/apps/qml/tutorials/ubuntu-ui-toolkit-palette/

We can reference the different components, their palette values as well as explain the palette in one place.

Revision history for this message
Tim Peeters (tpeeters) wrote :

Sounds good :)

Paty Davila (dizzypaty)
Changed in ubuntu-ux:
status: Confirmed → Triaged
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: Tim Peeters (tpeeters) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.