don't change window title to name of settings panel
Bug #1542099 reported by
Bill Filler
This bug report is a duplicate of:
Bug #1341677: Window title should not be set from page title.
Edit
Remove
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Confirmed
|
Medium
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu) |
In Progress
|
Medium
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
In Progress
|
Medium
|
Zoltan Balogh |
Bug Description
per design:
In windowed mode, the window title should remain 'System Settings'. Currently it changes to "Bluetooth" or whatever the name of the current panel is, but design does not want it to do this.
Related branches
lp:~mpt/ubuntu-ui-toolkit/1542099-window-title
Rejected
for merging
into
lp:ubuntu-ui-toolkit
- Zsombor Egri: Disapprove
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 21 lines (+0/-11)1 file modifiedsrc/Ubuntu/Components/1.3/MainView.qml (+0/-11)
Changed in ubuntu-system-settings (Ubuntu): | |
importance: | Undecided → Medium |
assignee: | nobody → Ken VanDine (ken-vandine) |
Changed in canonical-devices-system-image: | |
importance: | Undecided → Medium |
assignee: | nobody → Bill Filler (bfiller) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zoltan Balogh (bzoltan) |
Changed in canonical-devices-system-image: | |
assignee: | Bill Filler (bfiller) → Zoltan Balogh (bzoltan) |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
no longer affects: | ubuntu-system-settings (Ubuntu) |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Zoltan Balogh (bzoltan) |
Changed in canonical-devices-system-image: | |
milestone: | ww08-2016 → 11 |
Changed in canonical-devices-system-image: | |
status: | In Progress → Confirmed |
Changed in canonical-devices-system-image: | |
milestone: | 11 → 12 |
To post a comment you must log in.
I think (though I’m not sure) that I saw this in an app that wasn’t System Settings, too. If so, it’s a toolkit bug, not a System Settings bug.
A quick browse of the toolkit code reveals two instances of "window.title = headerItem.title", which doesn’t seem right. Setting the window title to be the same as the header title immediately below it would be ugly repetition. <https:/ /bazaar. launchpad. net/~ubuntu- sdk-team/ ubuntu- ui-toolkit/ trunk/view/ head:/src/ Ubuntu/ Components/ 1.3/MainView. qml#L186>