AppHeader has no background
Bug #1531457 reported by
Tim Peeters
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Tim Peeters |
Bug Description
The clipping of the Page not to overlap with the AppHeader (which has transparent background) was removed in this MR: https:/
So in the AdaptivePageLayout, the Page contents, and the header contents may now overlap, and because the AppHeader has no background, that is wrong.
The AppHeader in MainView still has the clipping enabled, but this may poorly affect performance and it is no longer needed if we give the header a background, as is the case in all the new designs.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/headerNoClip
- Zsombor Egri: Approve
- Andrew Hayzen (community): Approve (functional)
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 90 lines (+18/-20)4 files modifiedsrc/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+1/-0)
src/Ubuntu/Components/1.3/AppHeader.qml (+5/-0)
src/Ubuntu/Components/1.3/MainView.qml (+3/-20)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+9/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Tim Peeters (tpeeters) |
status: | New → In Progress |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → Zoltan Balogh (bzoltan) |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1872+ 16.04.20160308- 0ubuntu1
--------------- 16.04.20160308- 0ubuntu1) xenial; urgency=medium
ubuntu-ui-toolkit (1.3.1872+
[ Timo Jyrinki ]
* Fix gles unit test skipping.
* Add s390x to the unit test skipping architectures
* UITK test plan - wily -> xenial. Fixes LP: #1544490
[ Christian Dywan ] visible flakes on non-arm. Fixes LP: #1534651 Test::doubleCli cked. Fixes LP: #1542215
* Print errors when QuickUtils fails to create a component.
* unit tests shouldn't use deprecated Dialog.callera
* Correctly count only test case results. The result= value is used in suites
and results.
* Skip tst_pagehead_
* Skip flaky tst_mousefilter
* Suppress click signal if releasing outside of ListItem. Fixes LP: #1541148.
* Use gdb in runtest.sh to produce backtraces.
* Arrow keys change value of a Slider. Fixes LP: #1523824.
* Only use Maliit when enabled explicitly in the environment
[ Oliver Tilloy ] ress".
* Do not try to assign to non-existent property "activeFocusOnP
Fixes LP: #1532953
* Bubble up ESC key press event if there is no popover to close.
Fixes LP: #1546627
[ Loïc Molinari ]
* Added private items and nodes for the new component styles.
Fixes LP: #1523836
* Made use of new private Frame item for the focusing.
* Fixed performance monitor crash because of a NULL timer pointer dereference.
Fixes LP: #1546986
* Fixed performance monitor dangling pointer crash. Fixes LP: #1546984
* [ProportionalShape] Ensured width/height ratio is correct with default values.
Fixes LP: #1546546
* Added a workaround to prevent a crash while changing the QPA scale factor.
[ Florian Boucault ]
* Always on performance monitor that logs frames that too long to render.
* MainView: proceed to selecting the theme automatically at startup too.
Fixes LP: #1535819
* MainView: when no gradient color is needed for the background, rely on
QQuickWindow's GL clear color. Lessens overdraw considerably for most
apps. Fixes LP: #1439133.
* Panel: MathUtils used without import prefix was leading to undefined
reference.
* Label: use native rendering on low dpi screens (GRID_UNIT_PX <= 10) for
sharper looking text.
* Gallery: added palette browser to Colors page.
[ Tim Peeters ]
* Support scrolling in ListViews with horizontal orientation to the
qquicklistview CPO.
* Add background to AppHeader and remove contents clipping from MainView.
Fixes LP: #1531016, LP: #1531457.
* Hide AppHeader when using AdaptivePageLayout. Fixes bug 1531871.
Fixes LP: #1531871.
* Implement horizontal flicking in the flickable autopilot CPO.
* Re-order to list of pages in the gallery to be alphabetical.
* Fix the autopilot failures introduced with the horizontal scrolling in
the Flickable CPO.
* Update documentation for MainView, Page, AdaptivePageLayout to use the new
PageHeader in all examples. Deprecate old properties. Fixes LP: #1540574
* Add 'animate' property to new internal AppHeaderBase, and do not show a
header animation when starting an app without header.
Fixes LP: #1518002, LP: #1524901.
...