Online accounts buttons not sensitive

[Allan LeSage]

In arale and krillin, fresh flash r198 and r208:

TEST CASE
1. Open system settings
2. Tap 'Accounts', accounts view opens, "No accounts" configured
3. Tap on Google item

EXPECTED
Google online sign-in appears

ACTUAL
Goose egg

davmor2 expecting a UITK fix to have landed to fix, fresh image doesn't fix, feel free to mark as dupe of whatever UITK bug if fix still pending.

[Alberto Mardegan (mardy)]

Given that we haven't changed anything in that code recently, and that I cannot spot anything wrong with the code itself (while I can also reproduce the bug on the Nexus 4, with image r320), I'm moving this to the UITK team for investigation.

The button is created here:
http://bazaar.launchpad.net/~online-accounts/ubuntu-system-settings-online-accounts/trunk/view/head:/system-settings-plugin/ProvidersList.qml#L61

In case you want to play with this on a live image, the file is installed as /usr/share/ubuntu/settings/system/qml-plugins/online-accounts/ProvidersList.qml

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Alberto Mardegan (mardy)]

I have now downgraded the UITK packages to 1.3.1742+15.04.20151209-0ubuntu1 (without touching any other packages) and with this version the buttons are working, so this looks like a regression in the UITK itself.

[Tim Peeters (tpeeters)]

It appears that when tapping the list items (ListItem.Standard), there is no triggered signal. Only clicked.

This is a bug we need to fix. But as a quick workaround you could use onClicked: instead of onTriggered.

[Tim Peeters (tpeeters)]

We have a fix for ActionItem.trigger included in our current landing, see https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/switchAndCheckboxFix/+merge/280844

That might fix the issue, but I haven't confirmed that yet.

[Tim Peeters (tpeeters)]

I can reproduce the issue with this test program:

import QtQuick 2.4
import Ubuntu.Components 1.3
import Ubuntu.Components.ListItems 1.3

Rectangle {
    width: 800
    height: 600

    Standard {
        anchors.fill: parent
        text: "bla"
        onTriggered: print("bad")
        onClicked: print("good")
    }

}

when clicking, onClicked is triggered but onTriggered is not.

[Tim Peeters (tpeeters)]

The bug was introduced in UITK staging r1760 (the above test program fails in r1760 and works fine in r1759), and unfortunately the switchAndCheckboxFix branch does not fix it.

[Tim Peeters (tpeeters)]

Fixed in the attached MR.

[Łukasz Zemczak (sil2100)]

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1778+15.04.20151221-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1778+15.04.20151221-0ubuntu1) vivid; urgency=medium

  [ Tim Peeters ]
  * Fix issue with trigger() for ListItems.Standard. (LP: #1527811)

ubuntu-ui-toolkit (1.3.1778+16.04.20151217.1-0ubuntu1) xenial; urgency=medium

  [ Andrea Bernabei ]
  * Rework Scrollbars and add ScrollView component.

  [ Zsombor Egri ]
  * Refactor UCSwipeAreaPrivate to use QQuickItemPrivate instead of being
    a QObject.

  [ Tim Peeters ]
  * Reduce toolbar height on phone in landscape orientation.
    Fixes LP: #1336793.
  * Introduce the new Toolbar component for the header edit mode.
  * Reduce the PageHeader height by 1 GU on phone in landscape orientation.
    Fixes LP: #1336793
  * Fix AppHeader 1.2 to use the new MathUtils. This fixes a failing autopilot
    CPO test.

  [ Zoltan Balogh ]
  * Do not wipe when provisioning for normal use and improve
    regression detection.
  * Try to link Gestures more explicitely. (kudos to xnox).

  [ Christian Dywan ]
  * Proper keyboard navigation and focus visuals for buttons.
    Fixes LP: #1225139, LP: #1514850
  * Escape should close popover. Fixes LP: #1523828
  * Surround state overloading message with static boolean. Fixes LP: #1523399
  * Don't exit, return 1 from export_modules_dir.sh.

  [ Michael Sheldon ]
  * Set the activeFocus on the input component when a text input area receive
    focus. Fixes LP: #1518352

  [ Benjamin Zeller ]
  * Move PageTreeNode to C++.
  * Custom property flag needs to be set always even when the value itself does not change.

  [ Albert Astals Cid ]
  * Make some more members slots
    This way we can use them in unity8 to make the drag areas more easily
    testable by making the times to recognize the gestures longer.

  [ CI Train Bot ]
  * No-change rebuild.

 -- Zoltan Balogh <email address hidden> Mon, 21 Dec 2015 21:09:04 +0000