Ubuntu
ubuntu-ui-toolkit package

Escape key needs to close popovers

Bug #1523828 reported by Cris Dywan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Cris Dywan

Bug Description

Pressing Escape should close an open Popover.

Related branches

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hideAndSeekPopover
Zsombor Egri: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 102 lines (+26/-2)
6 files modified
src/Ubuntu/Components/1.3/TextArea.qml (+3/-0)
src/Ubuntu/Components/1.3/TextField.qml (+3/-0)
src/Ubuntu/Components/1.3/TextInputPopover.qml (+6/-0)
src/Ubuntu/Components/Popups/1.3/Popover.qml (+2/-1)
tests/unit_x11/tst_components/tst_focus.qml (+1/-1)
tests/unit_x11/tst_components/tst_popover13.qml (+11/-0)
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → In Progress
assignee: nobody → Christian Dywan (kalikiana)
importance: Undecided → High
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1778+16.04.20151221-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1778+16.04.20151221-0ubuntu1) xenial; urgency=medium

  [ Tim Peeters ]
  * Fix issue with trigger() for ListItems.Standard. (LP: #1527811)

 -- Zoltan Balogh <email address hidden> Mon, 21 Dec 2015 21:09:04 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Olivier Tilloy (osomon) wrote :

The implementation is not correct: because the foreground item handles the escapePressed event, it doesn’t give app developers a chance to override this behaviour for their popovers. They might want to handle the escapePressed event to e.g. do some specific processing before closing the popover (which they wouldn’t do when closing the popover in another way, e.g. when pressing Enter).

Revision history for this message
Olivier Tilloy (osomon) wrote :

I filed bug #1546677 to track the issue mentioned above.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.