UbuntuShape shouldn't emit redundant deprecation warnings
Bug #1481791 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Critical
|
Cris Dywan |
Bug Description
What it says on the tin. UCDeprecatedTheme keeps a hash of warnings based on the filename. UbuntuShape should be using that.
Related branches
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/shapeNotes
Rejected
for merging
into
lp:ubuntu-ui-toolkit/staging
- Cris Dywan: Disapprove
- PS Jenkins bot: Approve (continuous-integration)
- Loïc Molinari: Pending requested
-
Diff: 239 lines (+38/-42)5 files modifiedsrc/Ubuntu/Components/plugin/ucapplication.cpp (+20/-0)
src/Ubuntu/Components/plugin/ucapplication.h (+5/-0)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+6/-28)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.h (+0/-5)
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+7/-9)
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/silentShape
- Loïc Molinari (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 85 lines (+32/-8)1 file modifiedsrc/Ubuntu/Components/plugin/ucubuntushape.cpp (+32/-8)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Christian Dywan (kalikiana) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | High → Critical |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → Fix Committed |
To post a comment you must log in.
Some numbers: the existing deprecation warnings in Ubuntu.Components 1.2 from uor own Theme using deprecated API cause a 7s penality in System Settings in the Storage page.