UbuntuShape shouldn't emit redundant deprecation warnings
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Critical
|
Christian Dywan |
Bug Description
What it says on the tin. UCDeprecatedTheme keeps a hash of warnings based on the filename. UbuntuShape should be using that.
Related branches
- Christian Dywan: Disapprove on 2015-08-07
- PS Jenkins bot: Approve (continuous-integration) on 2015-08-05
- Loïc Molinari: Pending requested 2015-08-05
-
Diff: 239 lines (+38/-42)5 files modifiedsrc/Ubuntu/Components/plugin/ucapplication.cpp (+20/-0)
src/Ubuntu/Components/plugin/ucapplication.h (+5/-0)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+6/-28)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.h (+0/-5)
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+7/-9)
- Loïc Molinari (community): Approve on 2015-08-07
- PS Jenkins bot: Approve (continuous-integration) on 2015-08-07
-
Diff: 85 lines (+32/-8)1 file modifiedsrc/Ubuntu/Components/plugin/ucubuntushape.cpp (+32/-8)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Christian Dywan (kalikiana) |
Christian Dywan (kalikiana) wrote : | #1 |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | High → Critical |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → Fix Committed |
Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1627+
---------------
ubuntu-ui-toolkit (1.3.1627+
[ Zsombor Egri ]
* Implement list item expansion.
* Turn AdaptivePageLayout page creation to be asynchronous.
* Fix ListItem swipe handling when gesture is initiated over an overlay
MouseArea which does not accept pressed event. Fixes LP: #1484545
* AbstractButton to C++. Fixes LP: #1365471, LP: #1458028
* Haptics singleton moved to C++.
* ActionItem moved to C++.
* Making columns resizable in an AdaptivePageLayout.
* Introducing column configuration into AdaptivePageLayout.
[ Benjamin Zeller ]
* Fix build inside qt and shadowbuild.
[ Tim Peeters ]
* Remove old and unused header-related files, and update unit test filenames.
* Don't unset the subheader style when Page.head changes because that unsets
the parent of Page.head.contents. Fixes LP: #1488922
* Fix the theming of the MainView.
* Fix the background color of the overflow panel.
[ Christian Dywan ]
* Include change signals with arguments in .api.
* A public QML type with no version is an error. Rather than silently breaking
as QML does normally at least apicheck can make this fatal.
* UbuntuShape shouldn't emit redundant deprecation warnings. Fixes LP: #1481791
* Update .bzrignore to new upstream style layout. Fixes LP: #1433308
* Revert unnecessary change of Popover minimumWidth. Fixes LP: #1483708
[ Ken VanDine ]
* Fixed a few typos in the api docs for StateSaver.
[ Olivier Tilloy ]
* Take custom key indexes into account to allow sorting on custom roles.
Fixes LP: #1485674
[ Albert Astals Cid ]
* Properly free shapeTextures[
will still be around when the opengl context is destroyed, but that seldom
happens so connect the signal to a lambda that will be there and does the
cleanup properly. Without this patch testDirectional
hitting the qFatal because it ran out of space in shapeTextures.
[ Richard Huddie ]
* Remove all usage of the autopilot simulated keyboard when the OSK is being
used. Fixes LP: 31483668
[ Gerry Boland ]
* Compensate for Qt's device pixel ratio multiplier.
Fixes: LP: #1207270, LP: #1275748, LP: #1468402
[ Nick Dedekind ]
* Added relative date time i18n.
[ CI Train Bot ]
* Resync trunk.
-- Zoltan Balogh <email address hidden> Tue, 08 Sep 2015 04:10:50 +0000
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Fix Committed → Fix Released |
Some numbers: the existing deprecation warnings in Ubuntu.Components 1.2 from uor own Theme using deprecated API cause a 7s penality in System Settings in the Storage page.