Ubuntu
ubuntu-ui-toolkit package

Remove warning on deprecated theme for versions < 1.3

Bug #1467851 reported by Alberto Mardegan
32
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Zoltan Balogh
Canonical System Image ww34-2015 "ota6"
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Critical
Cris Dywan

Bug Description

This is slightly related to bug 1457528.

In my case, I have an application using the 14.10 framework and importing Ubuntu.Components 1.0.
In that version, Theme *is not deprecated*, therefore I shouldn't see any warnings.

That should be the case up to 1.2, where Theme is still documented as not being deprecated.

Related branches

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/optInDeprecationWarnings
PS Jenkins bot: Approve (continuous-integration)
Zoltan Balogh: Approve
Diff: 165 lines (+49/-27)
4 files modified
src/Ubuntu/Components/plugin/quickutils.cpp (+9/-0)
src/Ubuntu/Components/plugin/quickutils.h (+1/-0)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+6/-5)
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+33/-22)
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/optInDeprecationWarningsTrunk
PS Jenkins bot: Approve (continuous-integration)
Ubuntu SDK team: Pending requested
Diff: 145 lines (+37/-12)
4 files modified
src/Ubuntu/Components/plugin/quickutils.cpp (+9/-0)
src/Ubuntu/Components/plugin/quickutils.h (+1/-0)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+6/-4)
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+21/-8)
PS Jenkins bot: Needs Fixing (continuous-integration)
Ubuntu SDK team: Pending requested
Diff: 3600 lines (+1505/-353) (has conflicts)
79 files modified
debian/changelog (+50/-0)
examples/ubuntu-ui-toolkit-gallery/po/de.po (+24/-22)
examples/ubuntu-ui-toolkit-gallery/po/el.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/es.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/fr.po (+412/-0)
examples/ubuntu-ui-toolkit-gallery/po/gl.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/hu.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/nl.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/pl.po (+412/-0)
examples/ubuntu-ui-toolkit-gallery/po/pt_BR.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/ru.po (+2/-2)
examples/ubuntu-ui-toolkit-gallery/po/uk.po (+1/-1)
po/am.po (+3/-4)
po/ar.po (+3/-4)
po/ast.po (+12/-13)
po/az.po (+3/-4)
po/be.po (+14/-13)
po/bg.po (+3/-4)
po/br.po (+2/-2)
po/bs.po (+3/-4)
po/ca.po (+3/-4)
po/ca@valencia.po (+3/-4)
po/ce.po (+3/-4)
po/cs.po (+3/-4)
po/da.po (+3/-4)
po/de.po (+3/-4)
po/el.po (+3/-4)
po/en_AU.po (+3/-4)
po/en_GB.po (+3/-4)
po/eo.po (+140/-0)
po/es.po (+3/-4)
po/eu.po (+3/-4)
po/fa.po (+3/-4)
po/fi.po (+3/-4)
po/fr.po (+3/-4)
po/fr_CA.po (+3/-4)
po/ga.po (+3/-4)
po/gd.po (+3/-4)
po/gl.po (+3/-4)
po/he.po (+3/-4)
po/hi.po (+3/-4)
po/hr.po (+3/-4)
po/hu.po (+3/-4)
po/ia.po (+5/-5)
po/id.po (+3/-4)
po/it.po (+3/-4)
po/ja.po (+6/-11)
po/km.po (+9/-8)
po/kn.po (+7/-6)
po/ko.po (+6/-11)
po/lv.po (+3/-4)
po/mr.po (+3/-4)
po/ms.po (+3/-4)
po/my.po (+10/-11)
po/nb.po (+3/-4)
po/nl.po (+5/-5)
po/oc.po (+3/-4)
po/pa.po (+3/-4)
po/pl.po (+5/-5)
po/pt.po (+3/-4)
po/pt_BR.po (+3/-4)
po/ro.po (+3/-4)
po/ru.po (+3/-4)
po/sk.po (+3/-4)
po/sl.po (+3/-4)
po/sq.po (+3/-4)
po/sr.po (+3/-4)
po/sv.po (+3/-4)
po/ta.po (+2/-2)
po/th.po (+140/-0)
po/tr.po (+3/-4)
po/ug.po (+7/-6)
po/uk.po (+5/-5)
po/zh_CN.po (+24/-25)
po/zh_TW.po (+3/-4)
src/Ubuntu/Components/plugin/quickutils.cpp (+9/-0)
src/Ubuntu/Components/plugin/quickutils.h (+1/-0)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+6/-4)
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+39/-0)
lp:ubuntu/wily/ubuntu-ui-toolkit
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
Revision history for this message
Cris Dywan (kalikiana) wrote :

What's the exact message we are talking about here?

Revision history for this message
Alberto Mardegan (mardy) wrote :

Here they are:

<Unknown File>: QML UCDeprecatedTheme: Theme.palette is deprecated. Use ThemeSettings instead.
<Unknown File>: QML UCDeprecatedTheme: Theme.createStyleComponent() is deprecated. Use ThemeSettings instead.
[...]
<Unknown File>: QML UCDeprecatedTheme: Theme.name is deprecated. Use ThemeSettings instead.

Revision history for this message
Cris Dywan (kalikiana) wrote :

The ones with 'unknown file' shouldn't be showing up anymore - I suspect the fix didn't make it to the vivd overlay.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Alberto Mardegan (mardy) wrote :

You are probably right: with the fix for bug 1457528, these warning should not be displayed anymore.
I'll comment on that bug.

Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: High → Critical
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: none → ww34-2015
assignee: nobody → Zoltan Balogh (bzoltan)
importance: Undecided → High
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: Zsombor Egri (zsombi) → Christian Dywan (kalikiana)
status: Incomplete → In Progress
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1603+15.10.20150824.1-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1603+15.10.20150824.1-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * Resync trunk. added: po/eo.po

  [ Christian Dywan ]
  * Make deprecation warnings from C++ opt-in (LP: #1467851)

 -- CI Train Bot <email address hidden> Mon, 24 Aug 2015 20:49:45 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.