[Document-Viewer] Re-enable swipe gestures of list items

Bug #1447995 reported by Stefano Verzegnassi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Document Viewer App
Fix Released
Medium
Stefano Verzegnassi
Ubuntu UX
Fix Released
Medium
Olga Kemmet

Bug Description

STEP TO REPRODUCE THIS ISSUE:
1. Open Document Viewer. The list of documents in $HOME/Documents will be shown.
2. Delete an entry in the list (N.B. not the grid), by swiping to right the corrisponding list item.

WHAT HAPPENS:
The list item can not be swipped

WHAT SHOULD HAPPENS:
The list item can be swipped to right, and a red-coloured action is shown.
Currently, to delete an item we need to switch to the multi-selection mode.

DESIRED SOLUTION:
See "Option A" in the comment #4.

Tags: usability

Related branches

summary: - [documentPage] Re-enable swipe gestures of list items
+ [SDK] Re-enable swipe gestures of list items
Changed in ubuntu-ux:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Olga Kemmet (olga-kemmet)
tags: added: usability
Revision history for this message
Olga Kemmet (olga-kemmet) wrote : Re: [SDK] Re-enable swipe gestures of list items

According to the description is seems to be an implementation issue on the app, and not SDK related...? The current toolkit list items do accommodate a delete if swiped to the right.

Changed in ubuntu-ux:
status: Triaged → Incomplete
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Hi Olga,

Sorry for the bad explanation of the issue. Yes, it's an app-related issue: we already have the code for swiping the list item, but we disabled it.
The task in this bug report was basically a to-do entry for me, rather than an explicit request to the ux team. My fault!

The problem is that we need to provide those actions (e.g. delete a document, move to sd card, etc.), which are activated by a swipe, also in the grid view, but the swipe gesture does not seem to be suitable for being used in a grid.
A solution we were considering was to use a context menu, triggerable by a button placed in the grid delegate, as done for example in the Android Google Play app[1].

I'm not sure though whether it fits with the Ubuntu UX guidelines.

The page which requires this improvement is the first/welcome/main page of the app, where the user can scroll a list of documents in the device, and pick one to be opened and read by the PDF viewer.

[1] http://imgur.com/y3vlMmi

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

For some reason, the link I pasted from my phone is broken.
I link an image I found on the web: http://www.strappysolutions.com/googleplay.png

summary: - [SDK] Re-enable swipe gestures of list items
+ [Document-Viewer] Re-enable swipe gestures of list items
Revision history for this message
Olga Kemmet (olga-kemmet) wrote :

Hi Stefano
Thank you for the detailed explanation, I understand the issue now better.
Indeed, we do not have any pattern for this particular use case at the moment. I would recommend you to do something similar as per your Android example:
- A: You include on the tile on the top right an overflow menu where you could put any additional actions or
- B: you include a text link saying "more..." in the bottom right of the tile which triggers a popover. The popover can be a list view with any additional actions for that tile.
I included a sketched wireframe to illustrate what I mean. Hope it helps.

Changed in ubuntu-ux:
status: Incomplete → Fix Committed
Revision history for this message
James Mulholland (jamesmulholland) wrote :

As per the discussion with popey & sverzegnassi, we'll precede with option A as outlined in Olga's sketch.

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

I'm working on the overflow menu as per specifications.

I'm currently using the standard APIs provided by the Ubuntu.Components.Popups QML module, and I feel that the position of the menu is confusing (see attachment - the menu actions are related to the "1.pdf" document, stored in the internal storage).

Would it be better to switch to an ActionSelectionPopover or add a arrow pointing to the hamburger icon?

Changed in ubuntu-docviewer-app:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Stefano Verzegnassi (verzegnassi-stefano)
description: updated
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

I've added a darker background that becomes visible when the overflow panel is visible.
This seems to make clearer to which delegate the panel is related.

However we may want in future to add an arrow pointing to the tile, although it would require a bit more of work, since this is not currently allowed by the UITK when the popover uses a squared style.

Because of this, I look forward for your reply, and I'll eventually consider to open a separate bug report with a lower priority for updating to the following design advices.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-docviewer-app at revision 174, scheduled for release in ubuntu-docviewer-app, milestone 2014-10-30

Changed in ubuntu-docviewer-app:
status: In Progress → Fix Committed
Revision history for this message
Zsombor Egri (zsombi) wrote :

Was this reported for the new ListItem from 1.2?

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Incomplete
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

@Zsombor: No, that's due to a misunderstanding of the terrible explanation I gave at first. The bug should be marked as "Invalid" for ubuntu-ui-toolkit.

Changed in ubuntu-docviewer-app:
status: Fix Committed → Fix Released
no longer affects: ubuntu-ui-toolkit (Ubuntu)
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.