Alarms API should expose a unique permanent alarm ID that clock app can use to open an alarm
Bug #1426361 reported by
Nekhelesh Ramananthan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Triaged
|
High
|
Zsombor Egri |
Bug Description
Alarms API should expose a unique permanent alarm ID that clock app can use to open an alarm instead of just the alarm index that varies based on the alarm date dynamically.
Use Case: Bug 1387210 Indicator-datetime will pass the QOrganizerItemId (unique alarm ID) to clock app when the user clicks on an alarm in the indicator-datetime. But the current Alarms API does not allow clock app to open the alarm using that unique ID which results in clock app not knowing which alarm to show to the user.
Related branches
lp:~zsombi/ubuntu-ui-toolkit/expose-alarm-id
On hold
for merging
into
lp:ubuntu-ui-toolkit/staging
- Cris Dywan: Needs Information
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Nekhelesh Ramananthan: Pending requested
-
Diff: 639 lines (+268/-31)14 files modifiedcomponents.api (+5/-3)
src/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+149/-18)
src/Ubuntu/Components/plugin/adapters/alarmsadapter_p.h (+19/-0)
src/Ubuntu/Components/plugin/alarmmanager_p.cpp (+5/-0)
src/Ubuntu/Components/plugin/alarmmanager_p.h (+2/-0)
src/Ubuntu/Components/plugin/alarmmanager_p_p.h (+1/-0)
src/Ubuntu/Components/plugin/plugin.cpp (+2/-0)
src/Ubuntu/Components/plugin/ucalarm.cpp (+12/-1)
src/Ubuntu/Components/plugin/ucalarm.h (+3/-0)
src/Ubuntu/Components/plugin/ucalarm_p.h (+2/-0)
src/Ubuntu/Components/plugin/ucalarmmodel.cpp (+25/-9)
src/Ubuntu/Components/plugin/ucalarmmodel.h (+4/-0)
tests/resources/alarm/Alarms.qml (+2/-0)
tests/unit/tst_alarms/tst_alarms.cpp (+37/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Zsombor Egri (zsombi) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
To post a comment you must log in.
See also: https:/ /bugs.launchpad .net/ubuntu/ +source/ indicator- datetime/ +bug/1426519
I think what we want to do is move the logic out of datetime if possible so that datetime can move from seeing things as "everything's a clock-app alarm or calendar event" to being a passthrough with less hardcoded logic in it. The rationale for this is we now want to add support for the reminder app, and we also want to support 3rd party apps.
So this bug has the right idea, but it would be better if, instead of a unique ID that datetime had to be coded to understand, that ui-toolkit or clock-app generated a url that datetime could blindly pass to url-dispatch().