i18n.noop function for tagging strings for gettext extraction
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
High
|
Zoltan Balogh | ||
| | ubuntu-ui-toolkit (Ubuntu) |
High
|
Christian Dywan | ||
| | Vivid |
Undecided
|
Unassigned | ||
| | ubuntu-ui-toolkit (Ubuntu RTM) |
Undecided
|
Unassigned | ||
Bug Description
It would be extremely useful for apps providing infographics if a pass through function for tagging existed in i18n.
e.g. i18n.noop("my string to extract but not translate")
This would be the equivalent of the N_ / gettext_noop function, but for QML.
Related branches
- Tim Peeters: Approve on 2015-02-05
- PS Jenkins bot: Approve (continuous-integration) on 2015-02-04
-
Diff: 221 lines (+95/-5)9 files modified.bzrignore (+1/-0)
components.api (+7/-0)
modules/Ubuntu/Components/plugin/i18n.cpp (+40/-1)
modules/Ubuntu/Components/plugin/i18n.h (+3/-1)
po/update-pot.sh (+2/-1)
tests/unit/tst_i18n/po/en_US.po (+7/-0)
tests/unit/tst_i18n/src/LocalizedApp.qml (+15/-1)
tests/unit/tst_i18n/src/tst_i18n.cpp (+13/-0)
tests/unit/tst_i18n/tst_i18n.pro (+7/-1)
- Tim Peeters: Approve on 2015-02-11
-
Diff: 144 lines (+58/-3)8 files modifiedcomponents.api (+3/-0)
modules/Ubuntu/Components/plugin/i18n.cpp (+27/-0)
modules/Ubuntu/Components/plugin/i18n.h (+1/-0)
po/update-pot.sh (+1/-1)
tests/unit/tst_i18n/po/en_US.po (+3/-0)
tests/unit/tst_i18n/src/LocalizedApp.qml (+7/-0)
tests/unit/tst_i18n/src/tst_i18n.cpp (+9/-1)
tests/unit/tst_i18n/tst_i18n.pro (+7/-1)
| David Planella (dpm) wrote : | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Christian Dywan (kalikiana) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| summary: |
- i18n.tag function for tagging strings for gettext extraction + i18n.noop function for tagging strings for gettext extraction |
| description: | updated |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Confirmed → Fix Committed |
| Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1403+
---------------
ubuntu-ui-toolkit (1.1.1403+
[ Albert Astals Cid ]
* Adapt to behaviour change in handling of QVariants from QML to
C++ in Qt 5.4
* Don't use Qt::PopupFocusR
is the correct reason QtQuick is since 5.4 ignoring focus changes
due to PopupFocusReason. Fixes LP: #1395014.
* Fix test failure with Qt 5.4 ExpandablesColu
In Qt 5.4 an alias to a null variable is correctly null instead of
undefined like it was in 5.3, since we still want 5.3 support i'm
conveting it to a verify with == that uses JS loose comparison to
accept both null and undefined. Fixes LP: #1395012.
[ Alexandre Abreu ]
* Remove the unecessary DBUS bindingi to global address
org.
for confined apps and the uri-dispatcher anyway does not work by
directly calling into the exposed "well known names" exposed on
the bus as TEd explains here LP: #1342129 but by directly calling
into the process dbus connection. Fixes LP: #1378823.
[ Benjamin Zeller ]
* Fix scripts to work in shadowbuild mode.
* Shadowbuild support for ubuntu-ui-toolkit.
[ Christian Dywan ]
* Abort export_
absent. Fixes LP: #1415973.
* Asterisk are needed for cp -R.
* Ensure adb is running (and fallback arch if dpkg-dev is missing).
Fixes LP: #1417997.
* Get arch for push_to_phone.sh from device and handle adb refusal.
* Implement and unit-test i18n.(c)tag. Fixes LP: #1417031.
* Print component creation errors in popupUtils.open.
Fixes LP: #1418507.
* Use correct unfocussed text field color. Fixes LP: #1396062.
[ Daniel d'Andrada ]
* Refactor OrientationHelper Simplify animation code and make it
more robust. It now survives changes in Screen.
and Screen.orientation happening one right after the other.
[ Daniel Holbach ]
* Fix broken link to developer site.
[ Giulio Collura ]
* This is a bugfix for bug LP: #1341814 and bug LP: #1400297.
Essentially we have to force the removal of the previous
'contents' item by removing its parent. This way we ensure that
the contents are correctly hidden, focused and removed, without
destroying them.
[ Loïc Molinari ]
* Removed unused variables breaking debug builds.
[ Michael Sheldon ]
* Only use stableOrientati
the orientationAngle has been set automatically.
Fixes LP: #1409027.
[ Niklas Wenzel ]
* Fixes LP: #1395118
[ nskaggs ]
* Re-add autopilot helper documentation and update. Fixes
LP: #1409778, LP: #1410477.
[ Tim Peeters ]
* Add a preview of the new list items to the UITK component gallery.
* Add performance test for MainView.
* Clean python code to follow pep257 standards.
* Fix incorrect header contents width when navigating back from a
page with a lot of actions. Fixes LP: #1408481.
* Split up MainView in MainView and ...
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Pete Woods (pete-woods) wrote : | #4 |
HI Pat, could you make a decision on if we can backport this fix to RTM?
It should be super low risk, and will un-block a fix for infographics translations: bug #1327419
| Pat McGowan (pat-mcgowan) wrote : | #5 |
pre-requisite to fix the other customer reported issue
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → High |
| milestone: | none → ww09-2015 |
| status: | New → In Progress |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Zoltan Balogh (bzoltan) |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
| status: | New → Fix Released |


Perhaps we could name it i18n.noop() to follow the gettext convention? It seems N_ is generally an alias to the gettext_noop macro [1]:
#define N_(String) gettext_noop (String)
[1] http:// www.gnu. org/software/ gettext/ manual/ gettext. html