Header divider is invisible on very dark backgrounds

Bug #1408643 reported by Michael Zanetti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Committed
High
Jouni Helminen
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Tim Peeters

Bug Description

The color for the header divider is calculated by Qt.darker(backgroundColor). If backgroundColor is already very dark or black, this leads to an invisible header divider. Probably it needs to check for a certain darkness threshold and use Qt.lighter(backgroundColor) instead.

Ideally the app developer could also override the color for the divider so that it can match the foregroundColor, meaning the divider would be the same color as the text and icons inside the header.

Tags: design-sync
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
Revision history for this message
Tim Peeters (tpeeters) wrote :

Currently we have this in MainView.qml:

            dividerColor: Qt.darker(background.headerColor, 1.1)
            panelColor: Qt.lighter(background.headerColor, 1.1)

I propose, as Michael said, to use a "darkness threshold" and if the color is too dark, use dividerColor: Qt.lighter(...) instead of Qt.darker().

Ideally we should also make all the color properties available so that they can be change din the header style.

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Tim Peeters (tpeeters)
tags: added: design-ync
tags: added: design-sync
removed: design-ync
Changed in ubuntu-ux:
assignee: nobody → Jouni Helminen (jounihelminen)
status: New → Triaged
importance: Undecided → High
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → High
Revision history for this message
Jouni Helminen (jounihelminen) wrote :

App devs should definitely be able to define the divider colour so they can match it with their app.

If we can do that automatically, even better.

We are in the process of redesigning the large divider( with a shadow and highlight) and reducing it to single thin line - should have that work approved in 2 weeks. Probably makes sense to do the implementation after that

Changed in ubuntu-ux:
status: Triaged → Fix Committed
Revision history for this message
Tim Peeters (tpeeters) wrote :

This is fixed with the new header and new theming with palette.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.