It should be possible to make Dialog respect its parent
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Medium
|
Zsombor Egri |
Bug Description
In the future unity8 will rotate instead of having apps rotating themselves. So that launcher, edge gestures, panel and application UI all have the same orientation and rotate together nicely. This includes the dialogs shown by unity8, such as the power dialog that pops up when you long-press the power button.
This is unity8's hierarchy:
// the root item
OrientedShell {
// the actual Shell UI, which gets rotated
Shell {
rotation: someAngle
Loader {
Dialog {
}
}
}
}
So we need the Dialogs to keep their parents so that they carry on the transformations applied to Shell, instead of being a sibling of it. This should be simple to accomplish as Dialog is an Item, and items are expected to respect their parents instead of reparenting themselves. So I'm just asking Dialog to *do less*.
Dialog is an Item and thus inherits its public API. Items have a parent property that is free for the user to manipulate it. Dialog should respect it.
Otherwise we will have to poke into Dialogs private API to achieve that, which is a fragile approach as that can break at any future release without warnings. Another bad option would be forking Dialog code, copying it over to unity8 code base (as we already do for the splash screen feature).
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 28 lines (+14/-3)1 file modifiedmodules/Ubuntu/Components/Popups/PopupBase.qml (+14/-3)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 45 lines (+13/-3)2 files modifiedcomponents.api (+1/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+12/-3)
description: | updated |
description: | updated |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → Medium |
status: | New → Triaged |
no longer affects: | ubuntu-ui-toolkit |
Changed in canonical-devices-system-image: | |
status: | New → Fix Released |
no longer affects: | ubuntu-ui-toolkit (Ubuntu Vivid) |
adding to canonical- devices- system- image as we would need this bug fix to land along with any shell rotation work.