It should be possible to make Dialog respect its parent
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Canonical System Image |
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu) |
Medium
|
Zsombor Egri |
Bug Description
In the future unity8 will rotate instead of having apps rotating themselves. So that launcher, edge gestures, panel and application UI all have the same orientation and rotate together nicely. This includes the dialogs shown by unity8, such as the power dialog that pops up when you long-press the power button.
This is unity8's hierarchy:
// the root item
OrientedShell {
// the actual Shell UI, which gets rotated
Shell {
rotation: someAngle
Loader {
Dialog {
}
}
}
}
So we need the Dialogs to keep their parents so that they carry on the transformations applied to Shell, instead of being a sibling of it. This should be simple to accomplish as Dialog is an Item, and items are expected to respect their parents instead of reparenting themselves. So I'm just asking Dialog to *do less*.
Dialog is an Item and thus inherits its public API. Items have a parent property that is free for the user to manipulate it. Dialog should respect it.
Otherwise we will have to poke into Dialogs private API to achieve that, which is a fragile approach as that can break at any future release without warnings. Another bad option would be forking Dialog code, copying it over to unity8 code base (as we already do for the splash screen feature).
Related branches
- PS Jenkins bot: Approve (continuous-integration) on 2014-12-03
- Zsombor Egri: Approve on 2014-12-03
-
Diff: 28 lines (+14/-3)1 file modifiedmodules/Ubuntu/Components/Popups/PopupBase.qml (+14/-3)
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-11-20
- Ubuntu SDK team: Pending requested 2014-11-20
-
Diff: 45 lines (+13/-3)2 files modifiedcomponents.api (+1/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+12/-3)
description: | updated |
description: | updated |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → Medium |
status: | New → Triaged |
no longer affects: | ubuntu-ui-toolkit |
kevin gunn (kgunn72) wrote : | #1 |
Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+
---------------
ubuntu-ui-toolkit (1.1.1364+
[ Zsombor Egri ]
* Theming fixes: application theming, binding loop fix, auto-theming
moved into MainView and it is applicable only on Ambiance and
SuruDark, SuruGradient is no longer auto-themed.
Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
LP: #1389792.
* ServiceProperties component to Ubuntu.Components 1.1.
Fixes: LP: #1391877.
* New ListItem component base. Support for leading/trailing actions.
Exported in Ubuntu.Components 1.2 UNSTABLE release.
Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
* removing failing ServiceProperties and app-theming branches
* Application theming ant other theming related binding loop fixes
* ServiceProperties DBus property watcher
[ Christian Dywan ]
* Do the default theme check properly: for non-debug and without
build errors.
* Don't activate the control in ListItem.Standard implicitly.
Fixes: LP: #1372563.
* Improve AutoPilot caret dragging test cases.
* Use new qt_gl_set_
Fixes: LP: #1397979.
* Add sortCaseSensitivity to the SortFilterModel example.
Fixes: LP: #1391034.
* Change offending links into bold font. Fixes: LP: #1395011.
[ Daniel d'Andrada ]
* This is needed by unity8 for the "shell rotation" feature (ie
shell does all the rotation work instead of apps rotating
themselves). unity8's dialogs (like the power dialog when you
long press the power button) should follow its parent item
rotation and size, as one would expect, and not be sneakily
reparented to the scene root item, in which case the shell
UI would be rotated but its dialog would not.
Related bug LP: #1394511. Fixes: LP: #1394511.
[ Tim Peeters ]
* Remove the old header separator style. Fixes: LP: #1372590.
[ Loïc Molinari ]
* Made the UCAlarmPrivate destructor private.
[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in canonical-devices-system-image: | |
status: | New → Fix Released |
no longer affects: | ubuntu-ui-toolkit (Ubuntu Vivid) |
adding to canonical- devices- system- image as we would need this bug fix to land along with any shell rotation work.