It should be possible to make Dialog respect its parent

Bug #1394511 reported by Daniel d'Andrada on 2014-11-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Medium
Zsombor Egri

Bug Description

In the future unity8 will rotate instead of having apps rotating themselves. So that launcher, edge gestures, panel and application UI all have the same orientation and rotate together nicely. This includes the dialogs shown by unity8, such as the power dialog that pops up when you long-press the power button.

This is unity8's hierarchy:

// the root item
OrientedShell {

    // the actual Shell UI, which gets rotated
    Shell {
        rotation: someAngle

        Loader {
            Dialog {
            }
        }
    }
}

So we need the Dialogs to keep their parents so that they carry on the transformations applied to Shell, instead of being a sibling of it. This should be simple to accomplish as Dialog is an Item, and items are expected to respect their parents instead of reparenting themselves. So I'm just asking Dialog to *do less*.

Dialog is an Item and thus inherits its public API. Items have a parent property that is free for the user to manipulate it. Dialog should respect it.

Otherwise we will have to poke into Dialogs private API to achieve that, which is a fragile approach as that can break at any future release without warnings. Another bad option would be forking Dialog code, copying it over to unity8 code base (as we already do for the splash screen feature).

Related branches

description: updated
description: updated
Zoltan Balogh (bzoltan) on 2014-11-20
Changed in ubuntu-ui-toolkit:
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → Medium
status: New → Triaged
Zoltan Balogh (bzoltan) on 2014-11-24
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → Medium
status: New → Triaged
Zoltan Balogh (bzoltan) on 2014-11-24
no longer affects: ubuntu-ui-toolkit
kevin gunn (kgunn72) wrote :

adding to canonical-devices-system-image as we would need this bug fix to land along with any shell rotation work.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+15.04.20141209-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1364+15.04.20141209-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Theming fixes: application theming, binding loop fix, auto-theming
    moved into MainView and it is applicable only on Ambiance and
    SuruDark, SuruGradient is no longer auto-themed.
    Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
           LP: #1389792.
  * ServiceProperties component to Ubuntu.Components 1.1.
    Fixes: LP: #1391877.
  * New ListItem component base. Support for leading/trailing actions.
    Exported in Ubuntu.Components 1.2 UNSTABLE release.
    Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
  * removing failing ServiceProperties and app-theming branches
  * Application theming ant other theming related binding loop fixes
  * ServiceProperties DBus property watcher

  [ Christian Dywan ]
  * Do the default theme check properly: for non-debug and without
    build errors.
  * Don't activate the control in ListItem.Standard implicitly.
    Fixes: LP: #1372563.
  * Improve AutoPilot caret dragging test cases.
  * Use new qt_gl_set_global_share_context setter with Qt 5.4.
    Fixes: LP: #1397979.
  * Add sortCaseSensitivity to the SortFilterModel example.
    Fixes: LP: #1391034.
  * Change offending links into bold font. Fixes: LP: #1395011.

  [ Daniel d'Andrada ]
  * This is needed by unity8 for the "shell rotation" feature (ie
    shell does all the rotation work instead of apps rotating
    themselves). unity8's dialogs (like the power dialog when you
    long press the power button) should follow its parent item
    rotation and size, as one would expect, and not be sneakily
    reparented to the scene root item, in which case the shell
    UI would be rotated but its dialog would not.
    Related bug LP: #1394511. Fixes: LP: #1394511.

  [ Tim Peeters ]
  * Remove the old header separator style. Fixes: LP: #1372590.

  [ Loïc Molinari ]
  * Made the UCAlarmPrivate destructor private.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Triaged → Fix Released
Changed in canonical-devices-system-image:
status: New → Fix Released
no longer affects: ubuntu-ui-toolkit (Ubuntu Vivid)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers