TextArea cursor does not regard font size
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | ubuntu-ui-toolkit (Ubuntu) |
Medium
|
Christian Dywan | ||
| | Vivid |
Undecided
|
Unassigned | ||
| | ubuntu-ui-toolkit (Ubuntu RTM) |
Undecided
|
Unassigned | ||
Bug Description
Set this html text to a TextArea:
<!DOCTYPE html><html>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; padding-left:0px; text-indent:
move the cursor between the different sized text elements.
Actual:
The cursor stays the same
Expected:
The cursor should scale with the text size
Related branches
- Zsombor Egri (community): Approve on 2015-02-23
-
Diff: 1349 lines (+395/-290)25 files modifiedexamples/ubuntu-ui-toolkit-gallery/TextInputs.qml (+5/-2)
modules/Ubuntu/Components/InputHandler.qml (+15/-37)
modules/Ubuntu/Components/TextArea.qml (+3/-5)
modules/Ubuntu/Components/TextCursor.qml (+70/-67)
modules/Ubuntu/Components/TextField.qml (+5/-9)
modules/Ubuntu/Components/TextInputPopover.qml (+6/-3)
modules/Ubuntu/Components/Themes/Ambiance/SelectionCursorStyle.qml (+0/-92)
modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml (+2/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+5/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextFieldStyle.qml (+1/-0)
modules/Ubuntu/Components/Themes/Ambiance/ToolbarButtonStyle.qml (+3/-3)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+0/-3)
modules/Ubuntu/Components/plugin/quickutils.cpp (+4/-1)
modules/Ubuntu/Components/plugin/quickutils.h (+1/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/popups.py (+5/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml (+69/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+42/-24)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml (+10/-1)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml (+11/-1)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml (+47/-12)
tests/launcher/launcher.cpp (+5/-3)
tests/unit/tst_quickutils/tst_quickutils.cpp (+60/-0)
tests/unit/tst_quickutils/tst_quickutils.pro (+2/-0)
tests/unit/unit.pro (+2/-1)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+22/-6)
- PS Jenkins bot: Approve (continuous-integration) on 2015-03-11
- Zsombor Egri (community): Approve on 2015-03-11
-
Diff: 1199 lines (+276/-291)19 files modifiedexamples/ubuntu-ui-toolkit-gallery/TextInputs.qml (+5/-2)
modules/Ubuntu/Components/InputHandler.qml (+15/-37)
modules/Ubuntu/Components/TextArea.qml (+3/-5)
modules/Ubuntu/Components/TextCursor.qml (+70/-67)
modules/Ubuntu/Components/TextField.qml (+5/-9)
modules/Ubuntu/Components/TextInputPopover.qml (+6/-3)
modules/Ubuntu/Components/Themes/Ambiance/SelectionCursorStyle.qml (+0/-92)
modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml (+2/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+5/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextFieldStyle.qml (+1/-0)
modules/Ubuntu/Components/Themes/Ambiance/ToolbarButtonStyle.qml (+3/-3)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+0/-3)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/popups.py (+5/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml (+43/-3)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+34/-24)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml (+6/-2)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml (+7/-2)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml (+44/-13)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+22/-6)
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Christian Dywan (kalikiana) |
| status: | New → Confirmed |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Undecided → Medium |
| status: | Confirmed → In Progress |
| Christian Dywan (kalikiana) wrote : | #1 |
| Michael Zanetti (mzanetti) wrote : | #2 |
You're right. However, using the upstream TextArea I did not notice this as a bug while the smaller cursor of Ubuntu's TextArea immediately jumped into my eyes. So I guess as long as the cursor is never smaller as the current font size we're good.
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Christian Dywan (kalikiana) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| no longer affects: | ubuntu-ui-toolkit |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.2.1450+
---------------
ubuntu-ui-toolkit (1.2.1450+
[ Timo Jyrinki ]
* Clean QML cache after updating package, before reboot. LP: #1431228
[ Zoltán Balogh ]
* Improved test plan script. Fixes LP: #1430201
[ Christian Dywan ]
* New text handler visuals and improved behavior.
Fixes LP: #1391335, LP: #1407723, LP: #1415548
* Split off test verification and run it once only for 'make check'.
Fixes LP: #1431698
* Tweak assert_
Fixes LP: #1432611
[ Tim Peeters ]
* Make the filenames for header and navigation tests consistent and
split up the big tabbed header.qml into multiple smaller test files.
Fixes LP: #1429838
[ Loïc Molinari ]
* Optimized Slider and ProgressBar components. Switched to the native
UbuntuShape
the progression in the Slider and ProgressBar components. The
rendering is now faster since it removes an FBO indirection and
enables batching by the QtQtuick renderer.
Fixes LP: #1398370, LP: #1427169
* Added a dedicated overlay shape. Made use of the new UbuntuShape
architecture to create an extended shape with efficient overlay
rendering. Fixes LP: #1396170
* Removed misleading statement from UbuntuShape documentation.
Fixes LP: #1430198
* Renamed the overlayGeometry property to overlayRect. The
overlayGeometry being of type QRect, using overlayRect instead
makes it more precise, less generic. Fixes LP: #1430278
* Converted sourceOpacity from float to qreal. Respect the same
guideline QtQuick items use to expose floating-point properties.
That doesn't break the QML API since there's no precision loss
from single to double precision, the cast is implicit.
Fixes LP: #1430267
* Fixed embedded QML code snippets indentation. Fixes LP: #1430274
[ Florian Boucault ]
* CheckBox: apply clipping to the Ubuntu shape and not to the CheckBox
itself so that the tick never overflows. Fixes LP: #1430191
[ Daniel Holbach ]
* A number of links changed on design.ubuntu.com - let's make sure
they're fixed in our docs. Fixes LP: #1428051
[ CI Train Bot ]
* New rebuild forced.
-- CI Train Bot <email address hidden> Wed, 18 Mar 2015 12:23:35 +0000
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Fix Committed → Fix Released |
I pushed a branch for making the cursor change size depending on the cursor height. Note that apparently QML's TextInput always assumes the largest font size in any one line. So it seems this requires an additional upstream fix to work as requested.