Listitems without actions shouldn't animate on click events
Bug #1362305 reported by
Sebastien Bacher
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
Using current utopic, doing a tap/click on a ListItem.Standard with only a text define (e.g no action) leads to have visual feedback about the click, whic seems to lead to confusion (see e.g bug #1360364 "rows can be clicked, give feedback, do nothing")
Would it make sense to have the animation only enable if the is an action/control for the widget?
(Not to be confused with bug 1289329, where an item normally would respond to a tap, but has been held down too long.)
Related branches
lp:~zsombi/ubuntu-ui-toolkit/78-action-property
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 388 lines (+169/-6)8 files modifiedcomponents.api (+1/-0)
modules/Ubuntu/Components/plugin/ucaction.h (+1/-0)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+80/-4)
modules/Ubuntu/Components/plugin/uclistitem.h (+3/-1)
modules/Ubuntu/Components/plugin/uclistitem_p.h (+3/-0)
modules/Ubuntu/Components/plugin/ucstyleditembase.cpp (+1/-0)
tests/resources/listitems/ListItemTest.qml (+20/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+60/-0)
summary: |
- ListIiems without actions should animate on click events + Listitems without actions should animate on click events |
summary: |
- Listitems without actions should animate on click events + Listitems without actions shouldn't animate on click events |
affects: | ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit |
description: | updated |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Zsombor Egri (zsombi) |
Changed in ubuntu-ui-toolkit: | |
importance: | Undecided → Low |
tags: | added: listitem |
Changed in ubuntu-ui-toolkit: | |
importance: | Low → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Confirmed |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.