Listitems without actions shouldn't animate on click events
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | ubuntu-ui-toolkit (Ubuntu) |
High
|
Zsombor Egri | ||
| | Vivid |
Undecided
|
Unassigned | ||
Bug Description
Using current utopic, doing a tap/click on a ListItem.Standard with only a text define (e.g no action) leads to have visual feedback about the click, whic seems to lead to confusion (see e.g bug #1360364 "rows can be clicked, give feedback, do nothing")
Would it make sense to have the animation only enable if the is an action/control for the widget?
(Not to be confused with bug 1289329, where an item normally would respond to a tap, but has been held down too long.)
Related branches
- PS Jenkins bot: Approve (continuous-integration) on 2015-02-05
- Tim Peeters: Approve on 2015-02-05
-
Diff: 388 lines (+169/-6)8 files modifiedcomponents.api (+1/-0)
modules/Ubuntu/Components/plugin/ucaction.h (+1/-0)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+80/-4)
modules/Ubuntu/Components/plugin/uclistitem.h (+3/-1)
modules/Ubuntu/Components/plugin/uclistitem_p.h (+3/-0)
modules/Ubuntu/Components/plugin/ucstyleditembase.cpp (+1/-0)
tests/resources/listitems/ListItemTest.qml (+20/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+60/-0)
| summary: |
- ListIiems without actions should animate on click events + Listitems without actions should animate on click events |
| summary: |
- Listitems without actions should animate on click events + Listitems without actions shouldn't animate on click events |
| Launchpad Janitor (janitor) wrote : | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Confirmed |
| affects: | ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit |
| description: | updated |
| Matthew Paul Thomas (mpt) wrote : | #2 |
I just discussed this with Giorgio. Specification updated. <http://
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Undecided → Low |
| tags: | added: listitem |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Low → High |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| no longer affects: | ubuntu-ui-toolkit |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Confirmed → In Progress |
| Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1403+
---------------
ubuntu-ui-toolkit (1.1.1403+
[ Albert Astals Cid ]
* Adapt to behaviour change in handling of QVariants from QML to
C++ in Qt 5.4
* Don't use Qt::PopupFocusR
is the correct reason QtQuick is since 5.4 ignoring focus changes
due to PopupFocusReason. Fixes LP: #1395014.
* Fix test failure with Qt 5.4 ExpandablesColu
In Qt 5.4 an alias to a null variable is correctly null instead of
undefined like it was in 5.3, since we still want 5.3 support i'm
conveting it to a verify with == that uses JS loose comparison to
accept both null and undefined. Fixes LP: #1395012.
[ Alexandre Abreu ]
* Remove the unecessary DBUS bindingi to global address
org.
for confined apps and the uri-dispatcher anyway does not work by
directly calling into the exposed "well known names" exposed on
the bus as TEd explains here LP: #1342129 but by directly calling
into the process dbus connection. Fixes LP: #1378823.
[ Benjamin Zeller ]
* Fix scripts to work in shadowbuild mode.
* Shadowbuild support for ubuntu-ui-toolkit.
[ Christian Dywan ]
* Abort export_
absent. Fixes LP: #1415973.
* Asterisk are needed for cp -R.
* Ensure adb is running (and fallback arch if dpkg-dev is missing).
Fixes LP: #1417997.
* Get arch for push_to_phone.sh from device and handle adb refusal.
* Implement and unit-test i18n.(c)tag. Fixes LP: #1417031.
* Print component creation errors in popupUtils.open.
Fixes LP: #1418507.
* Use correct unfocussed text field color. Fixes LP: #1396062.
[ Daniel d'Andrada ]
* Refactor OrientationHelper Simplify animation code and make it
more robust. It now survives changes in Screen.
and Screen.orientation happening one right after the other.
[ Daniel Holbach ]
* Fix broken link to developer site.
[ Giulio Collura ]
* This is a bugfix for bug LP: #1341814 and bug LP: #1400297.
Essentially we have to force the removal of the previous
'contents' item by removing its parent. This way we ensure that
the contents are correctly hidden, focused and removed, without
destroying them.
[ Loïc Molinari ]
* Removed unused variables breaking debug builds.
[ Michael Sheldon ]
* Only use stableOrientati
the orientationAngle has been set automatically.
Fixes LP: #1409027.
[ Niklas Wenzel ]
* Fixes LP: #1395118
[ nskaggs ]
* Re-add autopilot helper documentation and update. Fixes
LP: #1409778, LP: #1410477.
[ Tim Peeters ]
* Add a preview of the new list items to the UITK component gallery.
* Add performance test for MainView.
* Clean python code to follow pep257 standards.
* Fix incorrect header contents width when navigating back from a
page with a lot of actions. Fixes LP: #1408481.
* Split up MainView in MainView and ...
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |


Status changed to 'Confirmed' because the bug affects multiple users.