Remove qtwebkit from touch image
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
High
|
David Barth | ||
| | Cordova Ubuntu |
High
|
Maxim Ermilov | ||
| | webapps-sprint |
High
|
David Barth | ||
| | webbrowser-app |
Fix Released
|
High
|
Alexandre Abreu | |
| | signon-plugin-oauth2 (Ubuntu) |
High
|
Alberto Mardegan | ||
| | signon-ui (Ubuntu) |
High
|
Alberto Mardegan | ||
| | ubuntu-html5-theme (Ubuntu) |
High
|
Alexandre Abreu | ||
| | ubuntu-touch-meta (Ubuntu) |
Critical
|
Pat McGowan | ||
| | webbrowser-app (Ubuntu) |
High
|
Alexandre Abreu | ||
Bug Description
The argument to remove this is based on the following:
The qtwebkit webview is deprecated for our sdk and we will not be supporting it long term
We are supporting an Oxide/Chromium solution for the Ubuntu.Webview
This was done largely for security reasons
The qtwebkit package is large and we would like to reduce image and install size
We want to discourage app devs from using this api any longer, the review tools have indicated this for several months
Related branches
- Daniel Holbach: Approve on 2015-03-16
-
Diff: 24 lines (+1/-2)2 files modifiedsdk-libs (+1/-1)
sdk-libs-dev (+0/-1)
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-03-30
- Olivier Tilloy: Approve on 2015-03-30
- Ubuntu HTML5 Theme Developers: Pending requested 2015-03-24
-
Diff: 56 lines (+1/-12)4 files modifieddebian/control (+0/-1)
examples/html5-theme/ui-gallery/qml/main.qml (+1/-1)
src/plugin/Ubuntu/WebApps/WebAppContainer.qml (+0/-6)
src/ubuntu-html5-app-launcher/main.cpp (+0/-4)
- David Barth (community): Approve on 2015-03-19
- PS Jenkins bot (community): Approve (continuous-integration) on 2015-03-19
-
Diff: 25 lines (+6/-1)2 files modifieddebian/changelog (+6/-0)
debian/control (+0/-1)
- Olivier Tilloy: Approve on 2015-04-09
- PS Jenkins bot: Approve (continuous-integration) on 2015-04-07
- David Barth (community): Needs Fixing on 2015-04-03
- Timo Jyrinki: Approve on 2015-03-28
-
Diff: 1539 lines (+14/-1266)20 files modifieddebian/control (+1/-5)
src/Ubuntu/Components/Extras/Browser/ItemSelector01.qml (+0/-63)
src/Ubuntu/Components/Extras/Browser/UbuntuWebView01.qml (+0/-278)
src/Ubuntu/Components/Extras/Browser/UserAgent01.qml (+0/-90)
src/Ubuntu/Components/Extras/Browser/dummysingleton.qml (+0/-28)
src/Ubuntu/Components/Extras/Browser/hyperlinks.js (+0/-52)
src/Ubuntu/Components/Extras/Browser/qmldir (+0/-4)
src/Ubuntu/Components/Extras/Browser/selection01.js (+0/-200)
src/Ubuntu/Components/Extras/Browser/ua-overrides.js (+0/-115)
src/Ubuntu/Web/plugin.cpp (+0/-13)
src/app/BrowserWindow.qml (+0/-1)
src/app/PermissionRequest.qml (+0/-47)
src/app/webcontainer/WebApp.qml (+10/-21)
src/app/webcontainer/WebViewImplWebkit.qml (+0/-173)
src/app/webcontainer/WebappContainerWebview.qml (+1/-5)
src/app/webcontainer/webapp-container.cpp (+1/-38)
src/app/webcontainer/webapp-container.h (+0/-1)
src/app/webcontainer/webapp-container.qml (+1/-3)
tests/unittests/qml/tst_UbuntuWebView01.qml (+0/-46)
tests/unittests/qml/tst_UserAgent01.qml (+0/-83)
| Pat McGowan (pat-mcgowan) wrote : | #1 |
| Pat McGowan (pat-mcgowan) wrote : | #2 |
Bug 1260016 added for an API to allow defining custom URL scheme delegates
| Pat McGowan (pat-mcgowan) wrote : | #3 |
We need to remove the dependency from the html container, which depends on Oxide 1.3 which supports script injection.
| Pat McGowan (pat-mcgowan) wrote : | #4 |
We also need to update all webapps using a policy < 1.1
There are 24 such apps in the store
phablet@
ubuntu-webapp */current/*.json | grep policy_version | grep 1.0
com.and.
com.lastpass.
com.ubuntu.
"policy_version": 1.0
com.ubuntu.
com.ubuntu.
com.ubuntu.
com.ubuntu.
"policy_version": 1.0
com.ubuntu.
"policy_version": 1.0
com.ubuntu.
"policy_version": 1.0
com.ubuntu.
"policy_version": 1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
1.0
com.ubuntu.
"policy_version": 1.0
com.ubuntu.
"policy_version": 1.1
com.ubuntu.
1.0
net.launchpad.
"policy_version": 1.0
net.launchpad.
net.launchpad.
| tags: | added: touch-2014-09-25 |
| Changed in ubuntu-touch-meta (Ubuntu): | |
| assignee: | nobody → Pat McGowan (pat-mcgowan) |
| status: | Triaged → In Progress |
| Pat McGowan (pat-mcgowan) wrote : | #5 |
The bug to add script injection to oxide for use in the html container is bug #1221996
| Pat McGowan (pat-mcgowan) wrote : | #6 |
This may not make rtm and isnt critical
| tags: |
added: ota-1 removed: touch-2014-09-25 |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Canonical Devices Products (canonical-devices-products-team) |
| importance: | Undecided → High |
| milestone: | none → r1 |
| status: | New → Confirmed |
| Changed in webbrowser-app: | |
| importance: | Undecided → High |
| assignee: | nobody → Olivier Tilloy (osomon) |
| Bill Filler (bfiller) wrote : | #7 |
opened a webbrowser-app task to track if there is any work needed on the browser or container side to remove this dependency. please mark invalid if not.
| tags: | added: ww51 |
| Olivier Tilloy (osomon) wrote : | #8 |
I installed all 624 apps from the store (as of today) on a Nexus 7 running vivid-proposed (image #42), and grepped through them to get a picture of which still use QtWebKit. Here’s a summary:
- 15 applications import (and supposedly use) QtWebKit directly:
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
fr.
ir.
- 10 applications import (and supposedly use) Ubuntu.
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
- 4 applications import Ubuntu.
com.
com.
com.
com.
- 16 applications import Ubuntu.Web 0.2 (i.e. Oxide under the hood), no change needed:
com.
com.
com.
com.viclog.2048
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
com.
cx.
- 12 applications import com.canonical.
com.
com.
com.popey.sst
com.
com.
com.
com.
com.
com.
com.
com.
com.
- Additionally, there are still 15 webapps using version 1.0 of the policy, ...
| Olivier Tilloy (osomon) wrote : | #9 |
All the apps that still use QtWebKit (either explicitly or through Ubuntu.
There are two exceptions, which might not be that easy to port (if possible at all, assessing that would require in-depth analysis of their code):
com.
com.
| Changed in webbrowser-app: | |
| status: | New → Triaged |
| Olivier Tilloy (osomon) wrote : | #10 |
Leaving the webbrowser-app task open as the webapp container is currently built with QtWebKit support (for web applications that still use version 1.0 of the policy). Once those applications are updated to use version 1.1 of the policy, we can remove QtWebKit support, and a lot of conditional code with it.
| David Barth (dbarth) wrote : | #11 |
For webapp-container, ie webapps, I have sent emails to the maintainers of all the 20 webapps still using the 13.10 framework.
As of today, we have 8 of them already updated to 14.04, and 12 still pending.
For the Cordova sample app, we should be able to upload a new version shortly with the new cordova release which now supports Oxide directly.
| David Barth (dbarth) wrote : | #12 |
Keep in mind also that you can't transparently migrate apps to Oxide, because of the framework they are attached to. Apps still using the 13.10 framework will need an explicit upload, as the apparmor policy will only let them use Oxide if they declare 14.04+ and add the 'webview' policy_group. I counted 120 apps still using 13.10, out of which 20 are webapps.
| Changed in cordova-ubuntu: | |
| assignee: | nobody → Maxim Ermilov (zaspire) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| status: | Confirmed → Triaged |
| Pat McGowan (pat-mcgowan) wrote : | #13 |
Pushing out due to all the moving pieces
| Changed in canonical-devices-system-image: | |
| milestone: | ww51-2014 → ww05-2015 |
| tags: | removed: ww51 |
| Pat McGowan (pat-mcgowan) wrote : | #14 |
make it part of move to vivid
| Changed in canonical-devices-system-image: | |
| milestone: | ww05-2015 → ww11-2015 |
| Timo Jyrinki (timo-jyrinki) wrote : | #15 |
On latest vivid, the following binary packages still depend on libqt5webkit5, making it stay on the image:
signon-ui-x11 (signon-ui): libqt5webkit5
ubuntu-
webapp-container (webbrowser-app): qml-module-qtwebkit
qtdeclarative5-
ubuntu-sdk-libs (ubuntu-
| David Barth (dbarth) wrote : | #16 |
The Cordova runtime has been updated to only use Oxide.
| Changed in ubuntu-html5-theme (Ubuntu): | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in signon-ui (Ubuntu): | |
| assignee: | nobody → Alberto Mardegan (mardy) |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in ubuntu-html5-theme (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Olivier Tilloy (osomon) |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in cordova-ubuntu: | |
| status: | Triaged → Fix Released |
| Olivier Tilloy (osomon) wrote : | #17 |
As of today, com.ubuntu.
| David Barth (dbarth) wrote : | #18 |
For reference all published webapps have been migrated to the newer framework which uses Oxide:
- the upload of new webapp mandates the use of the Oxide-oriented frameworks for a few months
- developers have been informed of the change on the ubuntu-phone mailing list
- developers of webapps requiring a framework upgrade have been contacted individually and guided to upload updated click packages
| Pat McGowan (pat-mcgowan) wrote : | #19 |
What is left before this can be removed?
| Changed in canonical-devices-system-image: | |
| assignee: | Canonical Devices Products (canonical-devices-products-team) → David Barth (dbarth) |
| milestone: | ww11-2015 → ww13-2015 |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Timo Jyrinki (timo-jyrinki) wrote : | #20 |
All of comment #15 is still valid: signon-ui, ubuntu-html5-theme and webbrowser-app need to stop using/depending on it.
I'll propose a branch against the seed to remove that depedency.
| Launchpad Janitor (janitor) wrote : | #21 |
This bug was fixed in the package ubuntu-touch-meta - 1.216
---------------
ubuntu-touch-meta (1.216) vivid; urgency=medium
[ Timo Jyrinki ]
* Refreshed dependencies
* Added liboxideqt-
* Removed libqt5webkit5-dev from sdk-libs-dev (LP: #1362640)
* Removed qml-module-qtwebkit from sdk-libs
-- Daniel Holbach <email address hidden> Mon, 16 Mar 2015 10:11:26 +0100
| Changed in ubuntu-touch-meta (Ubuntu): | |
| status: | In Progress → Fix Released |
| Timo Jyrinki (timo-jyrinki) wrote : | #22 |
The meta package update means webkit would drop from the images if the three remaining source packages would stop depending on it in the binaries installed on device.
| Changed in ubuntu-html5-theme (Ubuntu): | |
| status: | Triaged → In Progress |
| Timo Jyrinki (timo-jyrinki) wrote : | #23 |
Adding signon-
| Changed in signon-plugin-oauth2 (Ubuntu): | |
| importance: | Undecided → High |
| assignee: | nobody → Alberto Mardegan (mardy) |
| Timo Jyrinki (timo-jyrinki) wrote : | #24 |
Correction: not Recommends, but Depends: signon-ui-x11 | ubuntu-
| Alberto Mardegan (mardy) wrote : | #25 |
Removing signon-ui. The fix will happen on the signon-
| Changed in signon-ui (Ubuntu): | |
| status: | Triaged → Invalid |
| Changed in signon-plugin-oauth2 (Ubuntu): | |
| status: | New → In Progress |
| Launchpad Janitor (janitor) wrote : | #26 |
This bug was fixed in the package signon-
---------------
signon-
[ Alberto Mardegan ]
* Remove dependency on signon-ui (LP: #1362640)
-- CI Train Bot <email address hidden> Thu, 19 Mar 2015 15:42:31 +0000
| Changed in signon-plugin-oauth2 (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app: | |
| status: | Triaged → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | Olivier Tilloy (osomon) → Alexandre Abreu (abreu-alexandre) |
| Changed in webbrowser-app: | |
| assignee: | Olivier Tilloy (osomon) → Alexandre Abreu (abreu-alexandre) |
| Launchpad Janitor (janitor) wrote : | #27 |
This bug was fixed in the package ubuntu-html5-theme - 0.1.2+15.
---------------
ubuntu-html5-theme (0.1.2+
[ Alexandre Abreu ]
* Remove QtWebkit support code (LP: #1362640)
[ CI Train Bot ]
* New rebuild forced.
-- CI Train Bot <email address hidden> Fri, 10 Apr 2015 13:32:34 +0000
| Changed in ubuntu-html5-theme (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| milestone: | ww13-2015 → ww17-2015 |
| Changed in webapps-sprint: | |
| assignee: | nobody → David Barth (dbarth) |
| importance: | Undecided → High |
| status: | New → In Progress |
| milestone: | none → sprint-8 |
| Launchpad Janitor (janitor) wrote : | #28 |
This bug was fixed in the package webbrowser-app - 0.23+15.
---------------
webbrowser-app (0.23+15.
[ Alexandre Abreu ]
* remove qtwebkit deps (LP: #1362640) (LP: #1362640)
[ CI Train Bot ]
* New rebuild forced.
[ Justin McPherson ]
* Command line options for media-hub use through Oxide.
[ Olivier Tilloy ]
* Update translation template.
-- CI Train Bot <email address hidden> Fri, 10 Apr 2015 13:33:24 +0000
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
| Timo Jyrinki (timo-jyrinki) wrote : | #29 |
Removed from image #172 onwards:
http://
Space savings from those four dropped packages: 380 + 614 + 500 + 22739 = 24233kB.
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
\o/
On Wed, Apr 15, 2015 at 8:26 AM, Timo Jyrinki <email address hidden>
wrote:
> Removed from image #172 onwards:
>
> http://
>
> Space savings from those four dropped packages: 380 + 614 + 500 + 22739
> = 24233kB.
>
> ** Changed in: canonical-
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are a bug assignee.
> https:/
>
> Title:
> Remove qtwebkit from touch image
>
> To manage notifications about this bug go to:
>
> https:/
>
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
| Changed in webapps-sprint: | |
| status: | In Progress → Fix Released |
The current use by 20 apps in the store:
- 2 apps that cannot be ported as of today
- one app that would require a sizeable amount of work
- one app that would require some work
- 5 apps that would require minimal changes
- 11 apps that wouldn’t require any changes (other than the imports)
(9) no specific QtWebKit API used, can be replaced by Ubuntu WebView without any changes:
com.ubuntu.
com.ubuntu.
com.ubuntu.
com.ubuntu.
com.ubuntu.
com.ubuntu.
com.ubuntu.
com.ubuntu.
ir.oneapp.
(2) actually uses an UbuntuWebView (version 0.1), can be replaced by Ubuntu WebView without any changes
com.ubuntu.
com.ubuntu.
(4) uses WebView.
com.nucleussy
com.ubuntu.
com.ubuntu.
com.ubuntu.
(1) uses onLoadProgressC
fr.skimbo.skimbou
(1) relies on the fact that QtWebKit’s WebView is a flickable, shouldn’t be too hard to port to Ubuntu WebView
com.ubuntu.
(1) uses lots of QtWebKit experimental APIs (it’s a browser app), sizeable amount of work to migrate to Ubuntu WebView (or more likely a raw Oxide WebView)
com.ubuntu.
(2) uses QtWebKit experimental APIs such as urlSchemeDelegates, cannot be replaced by Ubuntu/Oxide WebView as is
com.ubuntu.
com.ubuntu.