Window buttons are small in a maximized Chromium window

Bug #1782038 reported by Thomas Anderson on 2018-07-16
30
This bug affects 3 people
Affects Status Importance Assigned to Milestone
ubuntu-themes (Ubuntu)
Medium
Marco Trevisan (Treviño)
Bionic
Undecided
Unassigned

Bug Description

[ Impact ]

In maximized google-chrome / chromium window buttons for close, minimize, and restore buttons should be normal-sized, but instead appear small.

[ Test case ]

1. Use the Ambiance or Radiance themes.
2. Launch a Chromium or Google Chrome window.
3. Ensure that in chrome settings, the "Use system borders" option is unchecked
4. Maximize.
5. Window buttons should have normal size.

[ Regression potential ]

Other windows buttons could loose the padding used for being closed.

---

Repro:
1. Use the Ambiance or Radiance themes.
2. Launch a Chromium window.
3. Maximize.

The window close, minimize, and restore buttons should be normal-sized, but instead appear small.

This is because the buttons have a padding of 9px on the top and bottom, causing Chromium to think they're taller than they really are, so it downsizes them to fit the smaller headerbar on the maximized window.

The attached patch removes the padding. There are no changes in behavior in apps other than Chromium.

Related branches

tags: added: patch
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-themes (Ubuntu):
status: New → Confirmed

The attachment "patch.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

no longer affects: ubuntu-themes
Changed in ubuntu-themes (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → Medium
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)

Thanks for the patch, that was fine for chrome, but it broke the activation area for other apps, so I've reduced the selector to only chrom{e,ium} buttons.

summary: - [Patch included] Window buttons are small in a maximized Chromium window
+ Window buttons are small in a maximized Chromium window
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+18.10.20181005-0ubuntu1

---------------
ubuntu-themes (16.10+18.10.20181005-0ubuntu1) cosmic; urgency=medium

  [ Khurshid Alam ]
  * Remove nonexistent gnome-builder.css (LP: #1773045)

  [ Marco Trevisan (Treviño) ]
  * Radiance: fix typo in assets link for focused buttons (LP: #1781736)
  * Radiance: Use scaled image for buttons border (LP: #1781736)
  * Ambiance, Radiance: don't use padding on window buttons for chromium
    (LP: #1782038)
  * Ambiance: use default foreground color for toolbar menus (LP:
    #1758841)
  * Ambiance, Radiance: show proper arrow in combobox (LP: #1743373)
  * Ambiance, Radiance: use default disabled color for actions headerbar
    buttons (LP: #1785699)
  * Ambiace, Radiance: use headerbar destructive-action definition for
    buttons
  * Ambiance, Radiance: fix list selected color for gnome-boxes (LP:
    #1761684)
  * Ambiance, Radiance: properly theme disabled and hovered accelerators
    (LP: #1795895)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 05 Oct 2018 00:13:07 +0000

Changed in ubuntu-themes (Ubuntu):
status: In Progress → Fix Released

Hello Thomas, or anyone else affected,

Accepted ubuntu-themes into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-themes/16.10+18.04.20181005-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-themes (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers