Ubuntu

There is no dark toolbar for symbolic theming

Reported by George Karavasilev on 2013-02-07
88
This bug affects 17 people
Affects Status Importance Assigned to Milestone
Ubuntu theme
High
Dimitri John Ledkov
ubuntu-themes (Ubuntu)
High
James Schriver

Bug Description

As you know Nautilus 3.6, the new System Settings (both in 13.04 come OTB), Font Viewer, Evince (soon) and more and more gnome apps in time use the new Gnome flat symbolic theming.
Here is how a toolbar with it looks like:
http://i.imgur.com/RIDKGhF.png
Here is how the normal toolbar looks like:
http://i.imgur.com/vu5fsDr.png
Now - replicating the standard toolbar theming on the symbolic one is not 100% possible (symbolic one is flat one), however there is nothing wrong with making the symbolic one dark. This is possible, see this for example:
http://www.webupd8.org/2013/01/beautiful-mediterraneannight-gtk-36.html
NOTE: The class of the normal toolbar is "primary-toolbar" and the one on the gnome style toolbar is just "toolbar"

description: updated
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

affects: light-themes → ubuntu-themes (Ubuntu)
Changed in ubuntu-themes (Ubuntu):
status: New → Confirmed
Changed in ubuntu-themes (Ubuntu):
status: New → Confirmed
J M (dolsilwa) wrote :

Symbolic toolbar don't have to be flat - you can put gradient on it. However if you try tu edit .toolbar class in theme there is some inconsistencies - because developers of rhythmbox and unity tweak tool put .toolbar in the middle of their freaking apps.

@dolsilwa, I am one of UTT creators and filed a bug against the toolbars in our Overview page: https://bugs.launchpad.net/unity-tweak-tool/+bug/1172314
We will try to fix it as soon as possible.

J M (dolsilwa) wrote :

@George Karavasilev, dont't get me wrong - app itself is really good and i use it on a daily basis, but we - themers - are getting more and more grumpy with every new Ubuntu release.

@dolsilwa, no worries, if anything I am grateful that you said that on this bug report so the bug got discovered. It's being worked upon and a fix should land pretty soon, maybe even in the next PPA release.

@dolsilwa As you can see now, this bug is now fixed in Unity Tweak Tool - https://bugs.launchpad.net/unity-tweak-tool/+bug/1172314

Exalm (exalm) wrote :

I've fixed that. The correct selector is .menubar.toolbar, not just .toolbar. Rhythmbox also works fine. With this toolbars look absolutely identical to "normal" ones. (As far as I tested it.)

Exalm (exalm) wrote :

Screenshot of the patch above.

Exalm (exalm) wrote :

Noticed a bug, fixed.

Tested on GNOME control center, Nautilus, GNOME clocks, log viewer, Contacts. (I don't use Contacts, so I don't know how exactly it should look, but the toolbar is dark and has gradient.)

Doesn't work on font viewer and Baobab. The first one has light toolbar, the second has dark toolbar without gradient.

The attachment "ubuntu-themes-toolbar-fix.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Exalm (exalm) wrote :

The recent update broke GNOME clocks, so I've updated the patch. Font viewer and Baobab now also work, and few glitches in the new Evince are gone. Inactive combobox button in Evince has wrong border though, not sure how to fix it.

Exalm (exalm) wrote :

Fixed Evince combobox.

Hello there, Exalm!
Whilst applying your patch I get this console output:
http://pastebin.ubuntu.com/5877321/
Which means that your patch isn't made for the trunk version of light-themes and it should be.
Grab the trunk by executing:
bzr branch lp:ubuntu/light-themes
and then make the patch suitable for it and upload the new version here.
Cheers! =)

Exalm (exalm) wrote :

Hello!
The patch applies perfectly to the trunk of lp:ubuntu/ubuntu-themes, for which the bug is reported.
I've just looked at the changelog of both, the last change in light-themes was made on 28 Sep 2012, and the last change in ubuntu-themes — on 12 Jul 2013.

Oh my god, how didn't I noticed that ... :D
Anyways,proposed this for merging (and of course mentioned you in the commit):
https://code.launchpad.net/~kokoto-java/ubuntu-themes/dark-symbolic-toolbars/+merge/174767
Now fingers crossed this bug will bite the dust! =)

Changed in ubuntu-themes (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → High
Doug McMahon (mc3man) wrote :

If you're going to fix this then why not also fix the gtk2 menus as in - Bug 961679, (synaptic is no longer affected, rest mentioned still are. Can be fixed up in /gtk-2.0/gtkrc

Exalm (exalm) wrote :

The linked branch seems to have older version of the patch. James Schriver, update it please. :)

James Schriver (dashua) on 2013-07-29
Changed in ubuntu-themes:
assignee: nobody → James Schriver (dashua)
Changed in ubuntu-themes (Ubuntu):
assignee: nobody → James Schriver (dashua)
Changed in ubuntu-themes:
status: New → In Progress
importance: Undecided → High
assignee: James Schriver (dashua) → Dmitrijs Ledkovs (xnox)
Changed in ubuntu-themes:
status: In Progress → Fix Committed
Changed in ubuntu-themes (Ubuntu):
status: Triaged → In Progress
Exalm (exalm) wrote :

Facepalm. Why merge the patch with broken Evince, when the fixed one is available one line lower?

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 13.04+13.10.20130802-0ubuntu1

---------------
ubuntu-themes (13.04+13.10.20130802-0ubuntu1) saucy; urgency=low

  [ James Schriver / Exalm ]
  * Fix regression, bring back dark toolbars in Gtk+3 apps. (LP: #1118838)
  * Apply dark toolbar fixes for Evince.

  [ Alberts Muktupavels ]
  * Restore padding between texts 'Applications' and 'Places' in
    gnome-panel, currently there is no space running
    gnome-session-fashback. (LP: #1154814)

  [ Nick Dedekind ]
  * Add missing battery icon links to ubuntu-mobile theme, needed for
    indicator-power.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 302
 -- Ubuntu daily release <email address hidden> Fri, 02 Aug 2013 00:02:43 +0000

Changed in ubuntu-themes (Ubuntu):
status: In Progress → Fix Released
Exalm (exalm) wrote :

The merged patch is still outdated.

Exalm (exalm) wrote :

No, I was wrong. Only images (Combobox borders) are missing.

I will propose a branch for merging. Sorry that I didn't do this at the beginning.

Changed in ubuntu-themes:
status: Fix Committed → In Progress
James Schriver (dashua) wrote :

@exalm - merged. Sorry for confusion :-)

Changed in ubuntu-themes:
status: In Progress → Fix Committed
Exalm (exalm) wrote :

Thanks. :)
The next time I will just propose a branch myself, as I had to learn bzr anyway. :)

Changed in ubuntu-themes:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers