Font size too big on phone, and display too tall with devicePixelRatio
Bug #1532950 reported by
Andrea Cimitan
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Terminal App |
Fix Released
|
Undecided
|
Niklas Wenzel | ||
ubuntu-terminal-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
as summary, needs some size adjustments with devicePixelRatio*
* To enable manually, easiest is to edit /etc/environment and add the line "QT_DEVICE_
Related branches
lp:~nikwen/ubuntu-terminal-app/font-size-fix
- Jenkins Bot: Approve (continuous-integration)
- Stefano Verzegnassi: Approve
-
Diff: 28 lines (+4/-4)2 files modifiedsrc/app/qml/TerminalComponent.qml (+1/-1)
src/app/qml/TerminalSettings.qml (+3/-3)
Changed in ubuntu-terminal-app: | |
status: | New → In Progress |
Changed in ubuntu-terminal-app: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-terminal-app (Ubuntu): | |
status: | Confirmed → Fix Released |
To post a comment you must log in.
My 2 cents. Would it make more sense to use the font size of a UITK Label (textSize: Label.Medium) as a reference unit, and provide only a setting for a multiplier of the resulting pixelSize?
That way the font size would be automatically adjusted according to GRID_UNIT_PX or QT_DEVICE_ PIXEL_RATIO variables, and it would behave consistently with the rest of the platform.