[time-date] it appears that more than one timezone is selected

[Jonas G. Drange]

Reproduce:
1. Enter Time & Date
2. Choose a timezone different than the current one
3. Re-enter timezone picker

What happens:
If I select Boston, Massachusetts I also see South Bostno, Massachusetts as selected

What should happen:
Boston, Massachusetts should be the only one selected

<https://wiki.ubuntu.com/TimeAndDate#Time_zone>: "If one of the search results is the current manually-chosen location, it should be shown as a selected radio item."

[Sebastien Bacher (seb128)]

Well, all the selected items are the one matching the selected timezone. We don't have more information stored to do more precise matching at the moment.

We could work out on a system storing the text of the tz selected but it feels like that wouldn't be robust (e.g if you change tz using other ways or get automatic tz from the carrier).

Do you have some ideas on what we should do?

[Iain Lane (laney)]

From the spec: "Whenever any of the search results are the current time zone, it should be shown as a selected radio item"

[Jonas G. Drange (jonas-drange)]

I'm okay with that. It was just a bit unexpected in some cases. Marked invalid.

[Matthew Paul Thomas (mpt)]

Oh dear. When I wrote "Whenever any of the search results are the current time zone, it should be shown as a selected radio item", I did not mean that *more than one* ever should! That would be violating the basic rule of radio controls: only one selection at a time. But I realize I was imprecise.

Specification updated. <https://wiki.ubuntu.com/TimeAndDate?action=diff&rev2=108&rev1=107>

[Iain Lane (laney)]

> + <https://wiki.ubuntu.com/TimeAndDate#Time_zone>: "If one of the search
> + results is the current manually-chosen location, it should be shown as a
> + selected radio item."

Then we have to store the location that has been selected and the
timezone this maps to (so we can mostly know if it was changed
externally), and not just use the timezone that the system tells us is
in use.

This will of course only work if they have chosen their timezone from
system-settings.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Sebastien Bacher (seb128)]

How do we expect that to even work once we get NITZ/automatic tz info from the carrier?

[Iain Lane (laney)]

It's on the manual selection screen so it can only work if you're using that

[Sebastien Bacher (seb128)]

well, assume you are on auto tz, change to manual and enter the screen for the first time, what should happen then?

[Iain Lane (laney)]

It can't know what the last selected location was. It can only know that if there is one.

[Matthew Paul Thomas (mpt)]

Right. If the current time zone was automatically set, it doesn't matter whether you have just switched to manual. There is no "current manually-chosen location", and therefore no items should be selected.