typing in search field of date/time settings blocks UI
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
Medium
|
Bill Filler | ||
| | ubuntu-system-settings (Ubuntu) |
Medium
|
Jonas G. Drange | ||
Bug Description
Steps to reproduce:
- reflash your phone
- go to date/time settings
- start typing "Boston" in search field
Expected results:
- Should see the text "Boston" immediately entered into the search field, with results updated as each letter is typed
Actual results:
- I only see "B" entered into the text field and everything blocks until the first set of search results comes back, then "Boston" is filled in the text field
Seems the search must be happening in the same thread as UI which is causing typing of the search string to block
Related branches
- Ken VanDine: Approve on 2015-09-14
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-09-11
-
Diff: 177 lines (+37/-29)4 files modifiedplugins/time-date/ChooseTimeZone.qml (+4/-2)
plugins/time-date/PageComponent.qml (+3/-1)
plugins/time-date/timezonelocationmodel.cpp (+23/-20)
plugins/time-date/timezonelocationmodel.h (+7/-6)
| Changed in canonical-devices-system-image: | |
| milestone: | none → ww40-2015 |
| assignee: | nobody → Bill Filler (bfiller) |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in ubuntu-system-settings (Ubuntu): | |
| assignee: | nobody → Jonas G. Drange (jonas-drange) |
| importance: | Undecided → Medium |
| Iain Lane (laney) wrote : Re: [Bug 1492260] [NEW] typing in search field of date/time settings blocks UI | #1 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | New → In Progress |
| Jonas G. Drange (jonas-drange) wrote : | #2 |
It seems we can improve the following and kill this bug in the process:
* move qSort out of GUI thread into the worker thread,
* instantiate timedatepanel plugin only once,
* and move away from the deprecated pattern of subclassing QThread.
| Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package ubuntu-
---------------
ubuntu-
[ jonas-drange ]
* [hotspot] hide/show based on modem availability from Connectivity
(which also requires a bumped dep). (LP: #1487157)
* [time-date] Migrate threaded code to worker-object pattern, move
sorting to a worker thread from the GUI thread, and only instantiate
UbuntuTimeD
* [wifi/wpa2ep] allow passwords of length 1 for wpa enterprise
authentication schemes. (LP: #1490417)
-- <email address hidden> (Jonas G. Drange) Fri, 18 Sep 2015 14:20:27 +0000
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |


On Fri, Sep 04, 2015 at 01:14:11PM -0000, Bill Filler wrote:
> Public bug reported:
>
> Steps to reproduce:
> - reflash your phone
> - go to date/time settings
> - start typing "Boston" in search field
>
> Expected results:
> - Should see the text "Boston" immediately entered into the search field, with results updated as each letter is typed
>
> Actual results:
> - I only see "B" entered into the text field and everything blocks until the first set of search results comes back, then "Boston" is filled in the text field
>
> Seems the search must be happening in the same thread as UI which is
> causing typing of the search string to block
No, we use QtConcurrent to do that.
It's probably something else, like incorrect blocking or maybe a
different part which is done synchronously.
--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]