wrong symbols in brightness settings

[Rüdiger Kupper]

Ubuntu Phone 15.04 (r3).
In the brightness settings dialog, the symbols for "dark" and "bright" are swapped:
- The left end of the slider shows a "bright sun" symbol (it should be dark).
- The right end of the slider shows a "dark sun" symbol (it should be bright).

[Matthew Paul Thomas (mpt)]

Confirmed. I guess this is because the slider is using Unicode symbols rather than real icons. In the battery menu, the symbols make sense because the text is white, so the solid sun is white. System Settings used to use a light-on-dark color scheme, but now uses a dark-on-light one, so the solid sun is black.

[Charles Kerr (charlesk)]

Looks like this is an issue with the icons rather than the code. System settings is setting the icons in a sane way:

    minIcon: "image://theme/display-brightness-min"
    maxIcon: "image://theme/display-brightness-max"

If you look at Suru's brightness min and max icons, they look good on a dark background (which is why they look OK in the indicator) but bad on a light background.

This is clearly visible not just in systems settings, but if you look at the icons in Nautilus in a light theme too, see attachment.

[Matthew Paul Thomas (mpt)]

I should have realized I was wrong about the menu using symbols, because all the other icons are reversed in indicators vs. System Settings too!

I suggest that the icons be more like the ones I sketched in the wireframe: brightness-min is a small sun, while brightness-max is a big sun. <https://wiki.ubuntu.com/BrightnessAndDisplays#Phone>