network-indicator should provide the "Please enter SIM PIN" text
Bug #1267135 reported by
Albert Astals Cid
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Network Menu |
Fix Released
|
High
|
Antti Kaijanmäki | ||
indicator-network (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-system-settings (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
Fix Released
|
Medium
|
Michael Zanetti |
Bug Description
We are showing the "Please enter SIM PIN" text ourselves but according to Saviq it should come from the indicator and not be in our code.
Related branches
lp:~unity-api-team/unity8/pinunlock-ng
- Michael Zanetti (community): Disapprove
-
Diff: 129 lines (+38/-5)4 files modifiedqml/Components/PinPadButton.qml (+1/-1)
qml/Greeter/Lockscreen.qml (+10/-0)
qml/Greeter/PinLockscreen.qml (+23/-3)
qml/Notifications/NotificationMenuItemFactory.qml (+4/-1)
lp:~unity-api-team/indicator-network/dual_sim_pin_unlock
- Olga Kemmet (community): Approve (design)
- Michael Zanetti (community): Abstain
- PS Jenkins bot (community): Approve (continuous-integration)
- Charles Kerr (community): Approve
-
Diff: 899 lines (+329/-183)9 files modifiedpo/indicator-network.pot (+116/-76)
src/indicator/modem-manager.cpp (+3/-4)
src/indicator/modem.cpp (+2/-2)
src/indicator/sim-unlock-dialog.cpp (+139/-71)
src/indicator/sim-unlock-dialog.h (+1/-0)
src/menumodel-cpp/gio-helpers/variant.h (+28/-0)
src/notify-cpp/snapdecision/sim-unlock.cpp (+38/-28)
src/notify-cpp/snapdecision/sim-unlock.h (+1/-1)
tests/autopilot/indicator_network/data/pin-unlock.xml (+1/-1)
lp:~unity-api-team/unity8/dual_sim_pin_unlock
- Michael Zanetti (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 269 lines (+99/-33)3 files modifiedpo/unity8.pot (+19/-27)
qml/Components/Lockscreen.qml (+3/-1)
qml/Notifications/NotificationMenuItemFactory.qml (+77/-5)
Changed in unity8: | |
assignee: | Antti Kaijanmäki (kaijanmaki) → Michael Zanetti (mzanetti) |
Changed in unity8: | |
status: | In Progress → Fix Released |
Changed in indicator-network: | |
status: | In Progress → Triaged |
importance: | Undecided → High |
tags: | added: rtm14 touch-2014-10-09 |
tags: | removed: rtm14 |
tags: | added: rtm14 |
Changed in indicator-network (Ubuntu): | |
status: | New → In Progress |
Changed in unity8 (Ubuntu): | |
status: | New → In Progress |
Changed in indicator-network: | |
status: | Triaged → In Progress |
Changed in indicator-network: | |
status: | In Progress → Fix Released |
Changed in indicator-network (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Michael Zanetti (mzanetti) |
importance: | Undecided → Medium |
no longer affects: | unity8 |
To post a comment you must log in.
Who's "We"?
Why does Saviq think it should be in the networking indicator code?
With the current design, on the PC a cellular modem might invoke a SIM PIN dialog from the networking menu or from System Settings. But on the phone, the only user-invoked SIM PIN UI is in System Settings.